[PATCH 0/2 v2] pinctrl: bcm: Use dev_err_probe()

[PATCH 0/2 v2] pinctrl: bcm: Use dev_err_probe()

[Florian Fainelli]

[-- Attachment #1.1: Type: text/plain, Size: 496 bytes --]

These two drivers were giving "unable to add GPIO chip data" which
was slightly concerning but did not have any functional impact.

Changes in v2:

- return from dev_err_probe() directly (Andy)

Florian Fainelli (2):
  pinctrl: iproc-gpio: Silence probe deferral messages
  pinctrl: nsp-gpio:  Silence probe deferral messages

 drivers/pinctrl/bcm/pinctrl-iproc-gpio.c | 6 ++----
 drivers/pinctrl/bcm/pinctrl-nsp-gpio.c   | 6 ++----
 2 files changed, 4 insertions(+), 8 deletions(-)

-- 
2.34.1


[-- Attachment #1.2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 1/2 v2] pinctrl: iproc-gpio: Silence probe deferral messages

[Florian Fainelli]

[-- Attachment #1.1: Type: text/plain, Size: 959 bytes --]

We can have gpiochip_add_data() return -EPROBE_DEFER which will make us
produce the "unable to add GPIO chip" message which is confusing. Use
dev_err_probe() to silence probe deferral messages.

Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
---
 drivers/pinctrl/bcm/pinctrl-iproc-gpio.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
index cc3eb7409ab3..0e3f787b93ef 100644
--- a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
+++ b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
@@ -891,10 +891,8 @@ static int iproc_gpio_probe(struct platform_device *pdev)
 	}
 
 	ret = gpiochip_add_data(gc, chip);
-	if (ret < 0) {
-		dev_err(dev, "unable to add GPIO chip\n");
-		return ret;
-	}
+	if (ret < 0)
+		return dev_err_probe(dev, ret, "unable to add GPIO chip\n");
 
 	if (!no_pinconf) {
 		ret = iproc_gpio_register_pinconf(chip);
-- 
2.34.1


[-- Attachment #1.2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 2/2 v2] pinctrl: nsp-gpio: Silence probe deferral messages

[Florian Fainelli]

[-- Attachment #1.1: Type: text/plain, Size: 946 bytes --]

We can have gpiochip_add_data() return -EPROBE_DEFER which will make
us produce the "unable to add GPIO chip" message which is confusing.
Use dev_err_probe() to silence probe deferral messages.

Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
---
 drivers/pinctrl/bcm/pinctrl-nsp-gpio.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c b/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c
index 5045a7e57f1d..7fecd0a10cd1 100644
--- a/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c
+++ b/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c
@@ -686,10 +686,8 @@ static int nsp_gpio_probe(struct platform_device *pdev)
 	}
 
 	ret = devm_gpiochip_add_data(dev, gc, chip);
-	if (ret < 0) {
-		dev_err(dev, "unable to add GPIO chip\n");
-		return ret;
-	}
+	if (ret < 0)
+		return dev_err_probe(dev, ret, "unable to add GPIO chip\n");
 
 	ret = nsp_gpio_register_pinconf(chip);
 	if (ret) {
-- 
2.34.1


[-- Attachment #1.2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 0/2 v2] pinctrl: bcm: Use dev_err_probe()

[Dhruva Gole]

On Aug 08, 2023 at 11:07:31 -0700, Florian Fainelli wrote:
> These two drivers were giving "unable to add GPIO chip data" which
> was slightly concerning but did not have any functional impact.
> 
> Changes in v2:
> 
> - return from dev_err_probe() directly (Andy)

For the series,

Reviewed-by: Dhruva Gole <d-gole@ti.com>

> 
> Florian Fainelli (2):
>   pinctrl: iproc-gpio: Silence probe deferral messages
>   pinctrl: nsp-gpio:  Silence probe deferral messages
> 
>  drivers/pinctrl/bcm/pinctrl-iproc-gpio.c | 6 ++----
>  drivers/pinctrl/bcm/pinctrl-nsp-gpio.c   | 6 ++----
>  2 files changed, 4 insertions(+), 8 deletions(-)
> 
> -- 
> 2.34.1
> 



-- 
Best regards,
Dhruva Gole <d-gole@ti.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/2 v2] pinctrl: iproc-gpio: Silence probe deferral messages

[Linus Walleij]

On Tue, Aug 8, 2023 at 8:07 PM Florian Fainelli
<florian.fainelli@broadcom.com> wrote:

> We can have gpiochip_add_data() return -EPROBE_DEFER which will make us
> produce the "unable to add GPIO chip" message which is confusing. Use
> dev_err_probe() to silence probe deferral messages.
>
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>

Patch applied.

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 2/2 v2] pinctrl: nsp-gpio: Silence probe deferral messages

[Linus Walleij]

On Tue, Aug 8, 2023 at 8:07 PM Florian Fainelli
<florian.fainelli@broadcom.com> wrote:

> We can have gpiochip_add_data() return -EPROBE_DEFER which will make
> us produce the "unable to add GPIO chip" message which is confusing.
> Use dev_err_probe() to silence probe deferral messages.
>
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>

Patch applied.

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel