From: Conor Dooley <conor@kernel.org>
To: Hari Nagalla <hnagalla@ti.com>
Cc: andersson@kernel.org, mathieu.poirier@linaro.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, s-anna@ti.com,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: remoteproc: k3-dsp: correct optional sram properties for AM62A SoCs
Date: Thu, 10 Aug 2023 20:26:44 +0100 [thread overview]
Message-ID: <20230810-dramatic-disregard-c254d763e1fe@spud> (raw)
In-Reply-To: <20230810110545.11644-1-hnagalla@ti.com>
[-- Attachment #1.1: Type: text/plain, Size: 1992 bytes --]
On Thu, Aug 10, 2023 at 06:05:45AM -0500, Hari Nagalla wrote:
> The C7xv-dsp on AM62A have 32KB L1 I-cache and a 64KB L1 D-cache. It
> does not have an addressable l1dram . So, remove this optional sram
> property from the bindings to fix device tree build warnings.
>
> Also set the 'memory-regions' property as optional. This is because
> the remote processors can function without carveout regions.
I thought I already said this today, but must be hallucinating - this
second part here seems like it in an unrelated change that should go in
its own patch..
>
> Signed-off-by: Hari Nagalla <hnagalla@ti.com>
> ---
> .../bindings/remoteproc/ti,k3-dsp-rproc.yaml | 16 ++++++++++++++--
> 1 file changed, 14 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
> index f16e90380df1..8dd22c57e22d 100644
> --- a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
> @@ -111,7 +111,6 @@ else:
> properties:
> compatible:
> enum:
> - - ti,am62a-c7xv-dsp
> - ti,j721e-c71-dsp
> - ti,j721s2-c71-dsp
> then:
> @@ -124,6 +123,20 @@ else:
> items:
> - const: l2sram
> - const: l1dram
> + else:
> + if:
> + properties:
> + compatible:
> + enum:
> + - ti,am62a-c7xv-dsp
> + then:
> + properties:
> + reg:
> + items:
> + - description: Address and Size of the L2 SRAM internal memory region
> + reg-names:
> + items:
> + - const: l2sram
>
> required:
> - compatible
> @@ -135,7 +148,6 @@ required:
> - resets
> - firmware-name
> - mboxes
> - - memory-region
>
> unevaluatedProperties: false
>
> --
> 2.34.1
>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-08-10 19:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 11:05 [PATCH] dt-bindings: remoteproc: k3-dsp: correct optional sram properties for AM62A SoCs Hari Nagalla
2023-08-10 12:21 ` Rob Herring
2023-08-10 19:26 ` Conor Dooley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230810-dramatic-disregard-c254d763e1fe@spud \
--to=conor@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hnagalla@ti.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=robh+dt@kernel.org \
--cc=s-anna@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox