From: Jonathan Cameron <jic23@kernel.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: Jinjie Ruan <ruanjinjie@huawei.com>,
lars@metafoo.de, matthias.bgg@gmail.com,
linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH -next 2/2] iio: adc: mt6577_auxadc: Simplify with device managed function
Date: Wed, 13 Sep 2023 20:17:08 +0100 [thread overview]
Message-ID: <20230913201708.3136e5eb@jic23-huawei> (raw)
In-Reply-To: <09603bb9-59df-a6a4-fda0-c47fa3941659@collabora.com>
On Wed, 13 Sep 2023 10:56:28 +0200
AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> wrote:
> Il 26/08/23 05:54, Jinjie Ruan ha scritto:
> > Add a device managed hook, via devm_add_action_or_reset() and
> > mt6577_power_off(), to power off on device detach.
> >
> > Replace iio_device_register() by devm_iio_device_register() and remove
> > the mt6577_auxadc_remove() function used to unregister the device and
> > power off the device.
> >
> > Remove platform_set_drvdata() from the probe function, since
> > platform_get_drvdata() is not used anymore.
> >
> > Remove mt6577_auxadc_mod_reg() call from the probe function error path.
> >
> > Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
> > Suggested-by: Jonathan Cameron <jic23@kernel.org>
>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>
Just missed. I finally pushed this out as non rebasing (rebased on rc1) on Monday.
Still the patches have a link back to here I think so people can see this if they
come looking!
Thanks
Jonathan
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-09-13 19:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-26 3:54 [PATCH -next 0/2] iio: adc: mt6577_auxadc: Cleanup with the helpers Jinjie Ruan
2023-08-26 3:54 ` [PATCH -next 1/2] iio: adc: mt6577_auxadc: Simplify with dev_err_probe() Jinjie Ruan
2023-09-13 8:56 ` AngeloGioacchino Del Regno
2023-08-26 3:54 ` [PATCH -next 2/2] iio: adc: mt6577_auxadc: Simplify with device managed function Jinjie Ruan
2023-08-27 17:04 ` Jonathan Cameron
2023-09-13 8:56 ` AngeloGioacchino Del Regno
2023-09-13 19:17 ` Jonathan Cameron [this message]
2023-08-27 17:07 ` [PATCH -next 0/2] iio: adc: mt6577_auxadc: Cleanup with the helpers Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230913201708.3136e5eb@jic23-huawei \
--to=jic23@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=ruanjinjie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox