From: Jonathan Cameron <jic23@kernel.org>
To: Jinjie Ruan <ruanjinjie@huawei.com>
Cc: <lars@metafoo.de>, <matthias.bgg@gmail.com>,
<angelogioacchino.delregno@collabora.com>,
<linux-iio@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH -next 0/2] iio: adc: mt6577_auxadc: Cleanup with the helpers
Date: Sun, 27 Aug 2023 18:07:06 +0100 [thread overview]
Message-ID: <20230827180706.09242b5d@jic23-huawei> (raw)
In-Reply-To: <20230826035402.3512033-1-ruanjinjie@huawei.com>
On Sat, 26 Aug 2023 11:54:00 +0800
Jinjie Ruan <ruanjinjie@huawei.com> wrote:
> Use the dev_err_probe() helper to simplify error handling during probe.
> This also handle scenario, when EDEFER is returned and useless
> error is printed.
Just a quick note to the driver maintainers. Whilst I've applied this,
I won't be pushing that out as a non rebasing tree for a few weeks.
As such I'm very happy to add tags, or indeed to drop it if you see
any changes you would like.
Taking it quickly is mostly because I have a huge backlog having been
away and want to get the simple stuff off that list!
Thanks,
Jonathan
>
> And use devm_add_action_or_reset() and devm_iio_device_register()
> to simplify the code.
>
> Jinjie Ruan (2):
> iio: adc: mt6577_auxadc: Simplify with dev_err_probe()
> iio: adc: mt6577_auxadc: Simplify with device managed function
>
> drivers/iio/adc/mt6577_auxadc.c | 60 +++++++++++++--------------------
> 1 file changed, 23 insertions(+), 37 deletions(-)
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-08-27 17:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-26 3:54 [PATCH -next 0/2] iio: adc: mt6577_auxadc: Cleanup with the helpers Jinjie Ruan
2023-08-26 3:54 ` [PATCH -next 1/2] iio: adc: mt6577_auxadc: Simplify with dev_err_probe() Jinjie Ruan
2023-09-13 8:56 ` AngeloGioacchino Del Regno
2023-08-26 3:54 ` [PATCH -next 2/2] iio: adc: mt6577_auxadc: Simplify with device managed function Jinjie Ruan
2023-08-27 17:04 ` Jonathan Cameron
2023-09-13 8:56 ` AngeloGioacchino Del Regno
2023-09-13 19:17 ` Jonathan Cameron
2023-08-27 17:07 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230827180706.09242b5d@jic23-huawei \
--to=jic23@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=ruanjinjie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox