From: Nishanth Menon <nm@ti.com>
To: "J, KEERTHY" <j-keerthy@ti.com>
Cc: <robh+dt@kernel.org>, <vigneshr@ti.com>, <conor+dt@kernel.org>,
<kristo@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<u-kumar1@ti.com>, <linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 5/7] arm64: dts: ti: k3-j784s4-mcu: Add the main domain watchdog instances
Date: Mon, 25 Sep 2023 11:05:43 -0500 [thread overview]
Message-ID: <20230925160543.4q2rjntoxrh27qh6@drivable> (raw)
In-Reply-To: <9fef2589-c864-bcb9-be9d-435d6abd470c@ti.com>
On 21:03-20230925, J, KEERTHY wrote:
>
>
> On 9/25/2023 6:49 PM, Nishanth Menon wrote:
> > On 13:43-20230925, Keerthy wrote:
> > > There are totally 2 instances of watchdog module in MCU domain.
> > >
> > > Signed-off-by: Keerthy <j-keerthy@ti.com>
> > > ---
> > > .../boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi | 20 +++++++++++++++++++
> > > 1 file changed, 20 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi
> > > index a7b5c4cb7d3e..0b7cc277a567 100644
> > > --- a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi
> > > +++ b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi
> > > @@ -714,4 +714,24 @@
> > > ti,esm-pins = <63>;
> > > bootph-pre-ram;
> > > };
> > > +
> > > + mcu_watchdog0: watchdog@40600000 {
> > > + compatible = "ti,j7-rti-wdt";
> > > + reg = <0x00 0x40600000 0x00 0x100>;
> > > + clocks = <&k3_clks 367 1>;
> > > + power-domains = <&k3_pds 367 TI_SCI_PD_EXCLUSIVE>;
> > > + assigned-clocks = <&k3_clks 367 0>;
> > > + assigned-clock-parents = <&k3_clks 367 4>;
> > > + status = "disabled";
> > > + };
> > > +
> > > + mcu_watchdog1: watchdog@40610000 {
> > > + compatible = "ti,j7-rti-wdt";
> > > + reg = <0x00 0x40610000 0x00 0x100>;
> > > + clocks = <&k3_clks 368 1>;
> > > + power-domains = <&k3_pds 368 TI_SCI_PD_EXCLUSIVE>;
> > > + assigned-clocks = <&k3_clks 368 0>;
> > > + assigned-clock-parents = <&k3_clks 368 4>;
> > > + status = "disabled";
> >
> > Explain in commit message as to why these are disabled. I believe it is
> > because this RTI instances are tightly coupled to the micro
> > controllers. but that information needs to be documented.
>
> Sure. I will add that to the commit message.
And inline to code for context, please.
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-09-25 16:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 8:13 [PATCH v4 0/7] arm64: ti: k3-j7: Add the ESM & main domain watchdog nodes Keerthy
2023-09-25 8:13 ` [PATCH v4 1/7] arm64: dts: ti: k3-j721s2: Add ESM instances Keerthy
2023-09-25 8:13 ` [PATCH v4 2/7] arm64: dts: ti: k3-j784s4: " Keerthy
2023-09-25 8:13 ` [PATCH v4 3/7] arm64: dts: ti: k3-j7200: Add MCU domain ESM instance Keerthy
2023-09-25 8:13 ` [PATCH v4 4/7] arm64: dts: ti: k3-j784s4-main: Add the main domain watchdog instances Keerthy
2023-09-25 8:40 ` Krzysztof Kozlowski
2023-09-25 8:13 ` [PATCH v4 5/7] arm64: dts: ti: k3-j784s4-mcu: " Keerthy
2023-09-25 13:19 ` Nishanth Menon
2023-09-25 15:33 ` J, KEERTHY
2023-09-25 16:05 ` Nishanth Menon [this message]
2023-09-25 8:13 ` [PATCH v4 6/7] arm64: dts: ti: k3-j721s2-main: " Keerthy
2023-09-25 8:13 ` [PATCH v4 7/7] arm64: dts: ti: k3-j721s2-mcu: " Keerthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230925160543.4q2rjntoxrh27qh6@drivable \
--to=nm@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=j-keerthy@ti.com \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=u-kumar1@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox