From: Nishanth Menon <nm@ti.com>
To: Nitin Yadav <n-yadav@ti.com>
Cc: <vigneshr@ti.com>, <kristo@kernel.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: boot: dts: ti: k3-am62a-main: Fix GPIO pin count in DT nodes.
Date: Wed, 25 Oct 2023 10:57:43 -0500 [thread overview]
Message-ID: <20231025155743.nk7un6pvib7swtxg@decorator> (raw)
In-Reply-To: <20231025110252.1089979-1-n-yadav@ti.com>
On 16:32-20231025, Nitin Yadav wrote:
> Fix number of gpio pins in main_gpio0 & main_gpio1 DT nodes according
> to AM62a SK datasheet. The Link of datasheet is in the following line:
SK? line?
Please rephrase above and just mention the section of the data sheet to
refer to.
>
> https://www.ti.com/lit/gpn/am62a3
>
> Section: 6.3.10 GPIO (Page No. 52-55)
>
> Fixes: '5fc6b1b62639c ("arm64: dts: ti: Introduce AM62A7 family of SoCs")'
What is the single quote for?
Also note the additional comment in the list to drop the extra EoL.
Did you check the MCU and WKUP GPIO count as well? if there are bugs
around it, fix it in a single commit please.
>
> Signed-off-by: Nitin Yadav <n-yadav@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-am62a-main.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
> index 3198af08fb9f..de36abb243f1 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
> @@ -462,7 +462,7 @@ main_gpio0: gpio@600000 {
> <193>, <194>, <195>;
> interrupt-controller;
> #interrupt-cells = <2>;
> - ti,ngpio = <87>;
> + ti,ngpio = <92>;
> ti,davinci-gpio-unbanked = <0>;
> power-domains = <&k3_pds 77 TI_SCI_PD_EXCLUSIVE>;
> clocks = <&k3_clks 77 0>;
> @@ -480,7 +480,7 @@ main_gpio1: gpio@601000 {
> <183>, <184>, <185>;
> interrupt-controller;
> #interrupt-cells = <2>;
> - ti,ngpio = <88>;
> + ti,ngpio = <52>;
> ti,davinci-gpio-unbanked = <0>;
> power-domains = <&k3_pds 78 TI_SCI_PD_EXCLUSIVE>;
> clocks = <&k3_clks 78 0>;
> --
> 2.25.1
>
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-10-25 15:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 11:02 [PATCH] arm64: boot: dts: ti: k3-am62a-main: Fix GPIO pin count in DT nodes Nitin Yadav
2023-10-25 12:43 ` Krzysztof Kozlowski
2023-10-25 15:57 ` Nishanth Menon [this message]
2023-10-26 6:47 ` Nitin Yadav
2023-10-26 11:35 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231025155743.nk7un6pvib7swtxg@decorator \
--to=nm@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=n-yadav@ti.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox