* [PATCH v3 1/1] ARM: kprobes: Explicitly reserve r7 for local variables
@ 2023-11-20 3:29 Maria Yu
2023-11-21 16:11 ` Ard Biesheuvel
0 siblings, 1 reply; 3+ messages in thread
From: Maria Yu @ 2023-11-20 3:29 UTC (permalink / raw)
To: Nathan Chancellor, linux, ardb, mhiramat
Cc: Maria Yu, kernel, linux-arm-kernel, linux-arm-msm, linux-kernel,
quic_lijuang, stable
Registers r7 is removed in clobber list, so compiler may choose r7 for
local variables usage, while r7 will be actually updated by the inline asm
code. This caused the runtime behavior wrong.
While those kind of reserved registers cannot be set to clobber list
because of error like "inline asm clobber list contains reserved
registers".
Explicitly reserve r7 by adding attribute no-omit-frame-pointer for this
file, then in T32 asm code r7 is used as a frame pointer and is not
available for use as a general-purpose register.
Note that "no-omit-frame-pointer" will make the code size a little bigger
to store the stack frame pointer.
Fixes: dd12e97f3c72 ("ARM: kprobes: treat R7 as the frame pointer register in Thumb2 builds")
Suggested-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Maria Yu <quic_aiquny@quicinc.com>
Cc: stable@vger.kernel.org
---
arch/arm/probes/kprobes/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/probes/kprobes/Makefile b/arch/arm/probes/kprobes/Makefile
index 6159010dac4a..b1f21e78950b 100644
--- a/arch/arm/probes/kprobes/Makefile
+++ b/arch/arm/probes/kprobes/Makefile
@@ -8,6 +8,7 @@ test-kprobes-objs := test-core.o
ifdef CONFIG_THUMB2_KERNEL
obj-$(CONFIG_KPROBES) += actions-thumb.o checkers-thumb.o
+CFLAGS_actions-thumb.o += -fno-omit-frame-pointer
test-kprobes-objs += test-thumb.o
else
obj-$(CONFIG_KPROBES) += actions-arm.o checkers-arm.o
base-commit: 98b1cc82c4affc16f5598d4fa14b1858671b2263
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v3 1/1] ARM: kprobes: Explicitly reserve r7 for local variables
2023-11-20 3:29 [PATCH v3 1/1] ARM: kprobes: Explicitly reserve r7 for local variables Maria Yu
@ 2023-11-21 16:11 ` Ard Biesheuvel
2023-11-21 16:38 ` Nathan Chancellor
0 siblings, 1 reply; 3+ messages in thread
From: Ard Biesheuvel @ 2023-11-21 16:11 UTC (permalink / raw)
To: Maria Yu
Cc: Nathan Chancellor, linux, mhiramat, kernel, linux-arm-kernel,
linux-arm-msm, linux-kernel, quic_lijuang, stable
On Sun, 19 Nov 2023 at 22:29, Maria Yu <quic_aiquny@quicinc.com> wrote:
>
> Registers r7 is removed in clobber list, so compiler may choose r7 for
> local variables usage, while r7 will be actually updated by the inline asm
> code. This caused the runtime behavior wrong.
> While those kind of reserved registers cannot be set to clobber list
> because of error like "inline asm clobber list contains reserved
> registers".
> Explicitly reserve r7 by adding attribute no-omit-frame-pointer for this
> file, then in T32 asm code r7 is used as a frame pointer and is not
> available for use as a general-purpose register.
> Note that "no-omit-frame-pointer" will make the code size a little bigger
> to store the stack frame pointer.
>
> Fixes: dd12e97f3c72 ("ARM: kprobes: treat R7 as the frame pointer register in Thumb2 builds")
> Suggested-by: Ard Biesheuvel <ardb@kernel.org>
> Signed-off-by: Maria Yu <quic_aiquny@quicinc.com>
> Cc: stable@vger.kernel.org
> ---
> arch/arm/probes/kprobes/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/probes/kprobes/Makefile b/arch/arm/probes/kprobes/Makefile
> index 6159010dac4a..b1f21e78950b 100644
> --- a/arch/arm/probes/kprobes/Makefile
> +++ b/arch/arm/probes/kprobes/Makefile
> @@ -8,6 +8,7 @@ test-kprobes-objs := test-core.o
>
> ifdef CONFIG_THUMB2_KERNEL
> obj-$(CONFIG_KPROBES) += actions-thumb.o checkers-thumb.o
> +CFLAGS_actions-thumb.o += -fno-omit-frame-pointer
> test-kprobes-objs += test-thumb.o
> else
> obj-$(CONFIG_KPROBES) += actions-arm.o checkers-arm.o
>
If Nathan is happy with this, I think we can drop this into the patch tracker.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v3 1/1] ARM: kprobes: Explicitly reserve r7 for local variables
2023-11-21 16:11 ` Ard Biesheuvel
@ 2023-11-21 16:38 ` Nathan Chancellor
0 siblings, 0 replies; 3+ messages in thread
From: Nathan Chancellor @ 2023-11-21 16:38 UTC (permalink / raw)
To: Ard Biesheuvel
Cc: Maria Yu, linux, mhiramat, kernel, linux-arm-kernel,
linux-arm-msm, linux-kernel, quic_lijuang, stable
On Tue, Nov 21, 2023 at 11:11:56AM -0500, Ard Biesheuvel wrote:
> On Sun, 19 Nov 2023 at 22:29, Maria Yu <quic_aiquny@quicinc.com> wrote:
> >
> > Registers r7 is removed in clobber list, so compiler may choose r7 for
> > local variables usage, while r7 will be actually updated by the inline asm
> > code. This caused the runtime behavior wrong.
> > While those kind of reserved registers cannot be set to clobber list
> > because of error like "inline asm clobber list contains reserved
> > registers".
> > Explicitly reserve r7 by adding attribute no-omit-frame-pointer for this
> > file, then in T32 asm code r7 is used as a frame pointer and is not
> > available for use as a general-purpose register.
> > Note that "no-omit-frame-pointer" will make the code size a little bigger
> > to store the stack frame pointer.
> >
> > Fixes: dd12e97f3c72 ("ARM: kprobes: treat R7 as the frame pointer register in Thumb2 builds")
> > Suggested-by: Ard Biesheuvel <ardb@kernel.org>
> > Signed-off-by: Maria Yu <quic_aiquny@quicinc.com>
> > Cc: stable@vger.kernel.org
> > ---
> > arch/arm/probes/kprobes/Makefile | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/probes/kprobes/Makefile b/arch/arm/probes/kprobes/Makefile
> > index 6159010dac4a..b1f21e78950b 100644
> > --- a/arch/arm/probes/kprobes/Makefile
> > +++ b/arch/arm/probes/kprobes/Makefile
> > @@ -8,6 +8,7 @@ test-kprobes-objs := test-core.o
> >
> > ifdef CONFIG_THUMB2_KERNEL
> > obj-$(CONFIG_KPROBES) += actions-thumb.o checkers-thumb.o
> > +CFLAGS_actions-thumb.o += -fno-omit-frame-pointer
> > test-kprobes-objs += test-thumb.o
> > else
> > obj-$(CONFIG_KPROBES) += actions-arm.o checkers-arm.o
> >
>
> If Nathan is happy with this, I think we can drop this into the patch tracker.
I have no qualms with this approach, there are no issues with the couple
of LLVM versions that I tested.
Cheers,
Nathan
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-21 16:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-20 3:29 [PATCH v3 1/1] ARM: kprobes: Explicitly reserve r7 for local variables Maria Yu
2023-11-21 16:11 ` Ard Biesheuvel
2023-11-21 16:38 ` Nathan Chancellor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox