Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* Re: [Upstream] [PATCH 1/3] arm64: dts: ti: k3-am625-phyboard-lyra-rdk: Lower I2C1 frequency
       [not found] <20231129183817.2327259-1-ggiordano@phytec.com>
@ 2023-11-30 12:07 ` Wadim Egorov
  2023-12-04 13:51   ` Nishanth Menon
  0 siblings, 1 reply; 2+ messages in thread
From: Wadim Egorov @ 2023-11-30 12:07 UTC (permalink / raw)
  To: Garrett Giordano, nm, vigneshr, kristo, robh+dt,
	krzysztof.kozlowski+dt, conor+dt
  Cc: devicetree, upstream, linux-kernel, linux-arm-kernel


Am 29.11.23 um 19:38 schrieb Garrett Giordano:
> The gpio-expander on i2c-1 has a maximum frequency of 100kHz. Update our
> main_i2c1 frequency to allow the nxp,pcf8574 gpio-expander to function
> properly.
>
> Signed-off-by: Garrett Giordano <ggiordano@phytec.com>

For all three patches,

Reviewed-by: Wadim Egorov <w.egorov@phytec.de>


> ---
>   arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dts | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dts b/arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dts
> index a438baf542c2..171354b13e33 100644
> --- a/arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dts
> @@ -187,7 +187,7 @@ cpsw3g_phy3: ethernet-phy@3 {
>   &main_i2c1 {
>   	pinctrl-names = "default";
>   	pinctrl-0 = <&main_i2c1_pins_default>;
> -	clock-frequency = <400000>;
> +	clock-frequency = <100000>;
>   	status = "okay";
>   
>   	gpio_exp: gpio-expander@21 {

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [Upstream] [PATCH 1/3] arm64: dts: ti: k3-am625-phyboard-lyra-rdk: Lower I2C1 frequency
  2023-11-30 12:07 ` [Upstream] [PATCH 1/3] arm64: dts: ti: k3-am625-phyboard-lyra-rdk: Lower I2C1 frequency Wadim Egorov
@ 2023-12-04 13:51   ` Nishanth Menon
  0 siblings, 0 replies; 2+ messages in thread
From: Nishanth Menon @ 2023-12-04 13:51 UTC (permalink / raw)
  To: Wadim Egorov
  Cc: Garrett Giordano, vigneshr, kristo, robh+dt,
	krzysztof.kozlowski+dt, conor+dt, devicetree, upstream,
	linux-kernel, linux-arm-kernel

On 13:07-20231130, Wadim Egorov wrote:
> 
> Am 29.11.23 um 19:38 schrieb Garrett Giordano:
> > The gpio-expander on i2c-1 has a maximum frequency of 100kHz. Update our
> > main_i2c1 frequency to allow the nxp,pcf8574 gpio-expander to function
> > properly.
> > 
> > Signed-off-by: Garrett Giordano <ggiordano@phytec.com>
> 
> For all three patches,
> 
> Reviewed-by: Wadim Egorov <w.egorov@phytec.de>
> 
> 
> > ---
> >   arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dts | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dts b/arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dts
> > index a438baf542c2..171354b13e33 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dts
> > +++ b/arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dts
> > @@ -187,7 +187,7 @@ cpsw3g_phy3: ethernet-phy@3 {
> >   &main_i2c1 {
> >   	pinctrl-names = "default";
> >   	pinctrl-0 = <&main_i2c1_pins_default>;
> > -	clock-frequency = <400000>;
> > +	clock-frequency = <100000>;
> >   	status = "okay";
> >   	gpio_exp: gpio-expander@21 {


Please resubmit the patches - the archives don't seem to have a copy
and b4 drops out. Also, when doing that, please pick up the reviews.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-12-04 13:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20231129183817.2327259-1-ggiordano@phytec.com>
2023-11-30 12:07 ` [Upstream] [PATCH 1/3] arm64: dts: ti: k3-am625-phyboard-lyra-rdk: Lower I2C1 frequency Wadim Egorov
2023-12-04 13:51   ` Nishanth Menon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox