public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: imx8dxl-ss-conn: Fix Ethernet interrupt-names order
@ 2023-11-13 19:35 Fabio Estevam
  2023-12-06  1:08 ` Shawn Guo
  0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2023-11-13 19:35 UTC (permalink / raw)
  To: shawnguo; +Cc: Frank.Li, linux-arm-kernel, Fabio Estevam

From: Fabio Estevam <festevam@denx.de>

Per snps,dwmac.yaml, the interrupt-names entries should be in the
following order: "macirq", "eth_wake_irq";

Change it to fix the following schema warnings.

imx8dxl-evk.dtb: ethernet@5b050000: interrupt-names:0: 'macirq' was expected
	from schema $id: http://devicetree.org/schemas/net/snps,dwmac.yaml#
imx8dxl-evk.dtb: ethernet@5b050000: interrupt-names:1: 'macirq' is not one of ['eth_wake_irq', 'eth_lpi']
	from schema $id: http://devicetree.org/schemas/net/snps,dwmac.yaml#

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
Frank,

imx8dl Reference Manual is not available at NXP website, so
I cannot check the interrupt map.

Please check and confirm.

 arch/arm64/boot/dts/freescale/imx8dxl-ss-conn.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8dxl-ss-conn.dtsi b/arch/arm64/boot/dts/freescale/imx8dxl-ss-conn.dtsi
index a414df645351..6e2d97c2fdf1 100644
--- a/arch/arm64/boot/dts/freescale/imx8dxl-ss-conn.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8dxl-ss-conn.dtsi
@@ -22,7 +22,7 @@ eqos: ethernet@5b050000 {
 		interrupt-parent = <&gic>;
 		interrupts = <GIC_SPI 163 IRQ_TYPE_LEVEL_HIGH>,
 			     <GIC_SPI 162 IRQ_TYPE_LEVEL_HIGH>;
-		interrupt-names = "eth_wake_irq", "macirq";
+		interrupt-names = "macirq", "eth_wake_irq";
 		clocks = <&eqos_lpcg IMX_LPCG_CLK_4>,
 			 <&eqos_lpcg IMX_LPCG_CLK_6>,
 			 <&eqos_lpcg IMX_LPCG_CLK_0>,
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] arm64: dts: imx8dxl-ss-conn: Fix Ethernet interrupt-names order
  2023-11-13 19:35 [PATCH] arm64: dts: imx8dxl-ss-conn: Fix Ethernet interrupt-names order Fabio Estevam
@ 2023-12-06  1:08 ` Shawn Guo
  0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2023-12-06  1:08 UTC (permalink / raw)
  To: Fabio Estevam; +Cc: Frank.Li, linux-arm-kernel, Fabio Estevam

On Mon, Nov 13, 2023 at 04:35:48PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Per snps,dwmac.yaml, the interrupt-names entries should be in the
> following order: "macirq", "eth_wake_irq";
> 
> Change it to fix the following schema warnings.
> 
> imx8dxl-evk.dtb: ethernet@5b050000: interrupt-names:0: 'macirq' was expected
> 	from schema $id: http://devicetree.org/schemas/net/snps,dwmac.yaml#
> imx8dxl-evk.dtb: ethernet@5b050000: interrupt-names:1: 'macirq' is not one of ['eth_wake_irq', 'eth_lpi']
> 	from schema $id: http://devicetree.org/schemas/net/snps,dwmac.yaml#
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Applied, thanks!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-12-06  1:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-13 19:35 [PATCH] arm64: dts: imx8dxl-ss-conn: Fix Ethernet interrupt-names order Fabio Estevam
2023-12-06  1:08 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox