From: Will Deacon <will@kernel.org>
To: Fuad Tabba <tabba@google.com>
Cc: Mark Brown <broonie@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Joey Gouly <joey.gouly@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 06/13] arm64/sysreg: Update ID_AA64ISAR2_EL1 defintion for DDI0601 2023-09
Date: Tue, 12 Dec 2023 09:10:48 +0000 [thread overview]
Message-ID: <20231212091047.GA28147@willie-the-truck> (raw)
In-Reply-To: <CA+EHjTzdKS+ardXUofO+U1vnsOC3QjiJUBuKCHWw6z6zKdVGSA@mail.gmail.com>
On Mon, Dec 11, 2023 at 09:07:25AM +0000, Fuad Tabba wrote:
> On Sat, Dec 9, 2023 at 1:03 AM Mark Brown <broonie@kernel.org> wrote:
> >
> > DDI0601 2023-09 defines some new fields in previously RES0 space in
> > ID_AA64ISAR2_EL1, together with one new enum value. Update the system
> > register definition to reflect this.
> >
> > Signed-off-by: Mark Brown <broonie@kernel.org>
>
> > ---
> > arch/arm64/tools/sysreg | 24 ++++++++++++++++++++++--
> > 1 file changed, 22 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg
> > index c48a3b8d00ad..3f382f8d0f4a 100644
> > --- a/arch/arm64/tools/sysreg
> > +++ b/arch/arm64/tools/sysreg
> > @@ -1365,7 +1365,14 @@ EndEnum
> > EndSysreg
> >
> > Sysreg ID_AA64ISAR2_EL1 3 0 0 6 2
> > -Res0 63:56
> > +UnsignedEnum 63:60 ATS1A
> > + 0b0000 NI
> > + 0b0001 IMP
> > +EndEnum
> > +UnsignedEnum 59:56 LUT
> > + 0b0000 NI
> > + 0b0001 IMP
> > +EndEnum
> > UnsignedEnum 55:52 CSSC
> > 0b0000 NI
> > 0b0001 IMP
> > @@ -1374,7 +1381,19 @@ UnsignedEnum 51:48 RPRFM
> > 0b0000 NI
> > 0b0001 IMP
> > EndEnum
> > -Res0 47:32
> > +Res0 47:44
> > +UnsignedEnum 43:40 PRFMSLC
> > + 0b0000 NI
> > + 0b0001 IMP
> > +EndEnum
> > +UnsignedEnum 39:36 SYSINSTR_128
> > + 0b0000 NI
> > + 0b0001 IMP
> > +EndEnum
> > +UnsignedEnum 35:32 SYSREG_128
> > + 0b0000 NI
> > + 0b0001 IMP
> > +EndEnum
> > UnsignedEnum 31:28 CLRBHB
> > 0b0000 NI
> > 0b0001 IMP
> > @@ -1398,6 +1417,7 @@ UnsignedEnum 15:12 APA3
> > 0b0011 PAuth2
> > 0b0100 FPAC
> > 0b0101 FPACCOMBINE
> > + 0b0110 PAUTH_LR
>
> Nit: PAuth and PAuth2 only have the PA as uppercase in this file,
> which matches the spec. Should PAuth_LR be the same?
I renamed it to PAuth_LR following your comment, but it looks like
ID_AA64ISAR1_EL1 is still missing this field entirely for the API and
APA fields.
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-12-12 9:11 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-09 1:02 [PATCH 00/13] arm64/sysreg: System register updates from the 2023-09 XML release broonie
2023-12-09 1:02 ` [PATCH 01/13] arm64/sysreg: Update HFGITR_EL2 definiton to DDI0601 2023-09 broonie
2023-12-09 1:02 ` [PATCH 02/13] arm64/sysreg: Add definition for HAFGRTR_EL2 broonie
2023-12-09 1:02 ` [PATCH 03/13] arm64/sysreg: add system register POR_EL{0,1} broonie
2023-12-09 1:02 ` [PATCH 04/13] arm64/sysreg: update CPACR_EL1 register broonie
2023-12-09 1:02 ` [PATCH 05/13] arm64/sysreg: Add definition for ID_AA64PFR2_EL1 Mark Brown
2023-12-11 8:59 ` Fuad Tabba
2023-12-09 1:02 ` [PATCH 06/13] arm64/sysreg: Update ID_AA64ISAR2_EL1 defintion for DDI0601 2023-09 Mark Brown
2023-12-11 9:07 ` Fuad Tabba
2023-12-12 9:10 ` Will Deacon [this message]
2023-12-12 10:24 ` Fuad Tabba
2023-12-12 12:56 ` Mark Brown
2023-12-09 1:02 ` [PATCH 07/13] arm64/sysreg: Add definition for ID_AA64ISAR3_EL1 Mark Brown
2023-12-11 9:14 ` Fuad Tabba
2023-12-09 1:02 ` [PATCH 08/13] arm64/sysreg: Add definition for ID_AA64FPFR0_EL1 Mark Brown
2023-12-11 9:18 ` Fuad Tabba
2023-12-09 1:02 ` [PATCH 09/13] arm64/sysreg: Update ID_AA64SMFR0_EL1 definition for DDI0601 2023-09 Mark Brown
2023-12-11 9:17 ` Fuad Tabba
2023-12-09 1:02 ` [PATCH 10/13] arm64/sysreg: Update SCTLR_EL1 " Mark Brown
2023-12-11 9:19 ` Fuad Tabba
2023-12-09 1:02 ` [PATCH 11/13] arm64/sysreg: Update HCRX_EL2 definition " Mark Brown
2023-12-11 9:26 ` Fuad Tabba
2023-12-09 1:02 ` [PATCH 12/13] arm64/sysreg: Add definition for FPMR Mark Brown
2023-12-11 9:28 ` Fuad Tabba
2023-12-09 1:02 ` [PATCH 13/13] arm64/sysreg: Add new system registers for GCS Mark Brown
2023-12-11 9:38 ` Fuad Tabba
2023-12-11 20:27 ` [PATCH 00/13] arm64/sysreg: System register updates from the 2023-09 XML release Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231212091047.GA28147@willie-the-truck \
--to=will@kernel.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=joey.gouly@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tabba@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox