Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 00/13] arm64/sysreg: System register updates from the 2023-09 XML release
@ 2023-12-09  1:02 broonie
  2023-12-09  1:02 ` [PATCH 01/13] arm64/sysreg: Update HFGITR_EL2 definiton to DDI0601 2023-09 broonie
                   ` (13 more replies)
  0 siblings, 14 replies; 27+ messages in thread
From: broonie @ 2023-12-09  1:02 UTC (permalink / raw)
  To: Catalin Marinas, Will Deacon
  Cc: Fuad Tabba, Joey Gouly, linux-arm-kernel, linux-kernel,
	Mark Brown

A number of serieses on the list have updates updates and additions to
the system registers, and as a result of the work being done on KVM
(especially nested virtualisation) there are overlaps and duplication of
work between people unaware of other pending serieses.  This series
collects together all the work that's been done on updating the system
register definitions that don't have pending review issues which I'm
aware of with the aim of at least making it easier to find things.

Since the system register definitions are part of the architecture
they're unlikely to change based on review of the serieses that they are
included in so it seems like it might make life easier to merge these
updates even without their users.  There is a small amount of overhead
from the increased size of the source and generated files but on the
other hand it would reduce the size of the serieses while they are in
review and make it less likely that we get duplicated work.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
Fuad Tabba (2):
      arm64/sysreg: Update HFGITR_EL2 definiton to DDI0601 2023-09
      arm64/sysreg: Add definition for HAFGRTR_EL2

Joey Gouly (2):
      arm64/sysreg: add system register POR_EL{0,1}
      arm64/sysreg: update CPACR_EL1 register

Mark Brown (9):
      arm64/sysreg: Add definition for ID_AA64PFR2_EL1
      arm64/sysreg: Update ID_AA64ISAR2_EL1 defintion for DDI0601 2023-09
      arm64/sysreg: Add definition for ID_AA64ISAR3_EL1
      arm64/sysreg: Add definition for ID_AA64FPFR0_EL1
      arm64/sysreg: Update ID_AA64SMFR0_EL1 definition for DDI0601 2023-09
      arm64/sysreg: Update SCTLR_EL1 for DDI0601 2023-09
      arm64/sysreg: Update HCRX_EL2 definition for DDI0601 2023-09
      arm64/sysreg: Add definition for FPMR
      arm64/sysreg: Add new system registers for GCS

 arch/arm64/include/asm/sysreg.h |  13 ++
 arch/arm64/tools/sysreg         | 270 ++++++++++++++++++++++++++++++++++++++--
 2 files changed, 273 insertions(+), 10 deletions(-)
---
base-commit: 2cc14f52aeb78ce3f29677c2de1f06c0e91471ab
change-id: 20231208-b4-arm64-sysreg-additions-c1f3b4acdff8

Best regards,
-- 
Mark Brown <broonie@kernel.org>


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 27+ messages in thread

* [PATCH 01/13] arm64/sysreg: Update HFGITR_EL2 definiton to DDI0601 2023-09
  2023-12-09  1:02 [PATCH 00/13] arm64/sysreg: System register updates from the 2023-09 XML release broonie
@ 2023-12-09  1:02 ` broonie
  2023-12-09  1:02 ` [PATCH 02/13] arm64/sysreg: Add definition for HAFGRTR_EL2 broonie
                   ` (12 subsequent siblings)
  13 siblings, 0 replies; 27+ messages in thread
From: broonie @ 2023-12-09  1:02 UTC (permalink / raw)
  To: Catalin Marinas, Will Deacon
  Cc: Fuad Tabba, Joey Gouly, linux-arm-kernel, linux-kernel,
	Mark Brown

From: Fuad Tabba <tabba@google.com>

The 2023-09 release of the architecture XML (DDI0601) adds a new field
ATS1E1A to HFGITR_EL2, update our definition of the register to match.

This was extracted from Faud Tabba's patch "KVM: arm64: Add latest
HFGITR_EL2 FGT entries to nested virt"

Signed-off-by: Fuad Tabba <tabba@google.com>
Message-Id: <20231206100503.564090-4-tabba@google.com>
[Extracted the sysreg definition from Faud's original patch and reword
 subject to match -- broonie]
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 arch/arm64/tools/sysreg | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg
index 96cbeeab4eec..8faeab1ee024 100644
--- a/arch/arm64/tools/sysreg
+++ b/arch/arm64/tools/sysreg
@@ -2102,7 +2102,9 @@ Fields	HFGxTR_EL2
 EndSysreg
 
 Sysreg HFGITR_EL2	3	4	1	1	6
-Res0	63:61
+Res0	63
+Field	62	ATS1E1A
+Res0	61
 Field	60	COSPRCTX
 Field	59	nGCSEPP
 Field	58	nGCSSTR_EL1

-- 
2.39.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 27+ messages in thread

* [PATCH 02/13] arm64/sysreg: Add definition for HAFGRTR_EL2
  2023-12-09  1:02 [PATCH 00/13] arm64/sysreg: System register updates from the 2023-09 XML release broonie
  2023-12-09  1:02 ` [PATCH 01/13] arm64/sysreg: Update HFGITR_EL2 definiton to DDI0601 2023-09 broonie
@ 2023-12-09  1:02 ` broonie
  2023-12-09  1:02 ` [PATCH 03/13] arm64/sysreg: add system register POR_EL{0,1} broonie
                   ` (11 subsequent siblings)
  13 siblings, 0 replies; 27+ messages in thread
From: broonie @ 2023-12-09  1:02 UTC (permalink / raw)
  To: Catalin Marinas, Will Deacon
  Cc: Fuad Tabba, Joey Gouly, linux-arm-kernel, linux-kernel,
	Mark Brown

From: Fuad Tabba <tabba@google.com>

Add a definition of HAFGRTR_EL2 (fine grained trap control for the AMU) as
per DDI0601 2023-09.

This was extracted from Fuad Tabba's patch "KVM: arm64: Handle
HAFGRTR_EL2 trapping in nested virt".

Signed-off-by: Fuad Tabba <tabba@google.com>
Link: https://lore.kernel.org/r/20231206100503.564090-6-tabba@google.com
[Extract sysreg update and rewrite commit message -- broonie]
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 arch/arm64/tools/sysreg | 43 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)

diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg
index 8faeab1ee024..145b33f75a96 100644
--- a/arch/arm64/tools/sysreg
+++ b/arch/arm64/tools/sysreg
@@ -2297,6 +2297,49 @@ Field	1	DBGBVRn_EL1
 Field	0	DBGBCRn_EL1
 EndSysreg
 
+Sysreg HAFGRTR_EL2	3	4	3	1	6
+Res0	63:50
+Field	49	AMEVTYPER115_EL0
+Field	48	AMEVCNTR115_EL0
+Field	47	AMEVTYPER114_EL0
+Field	46	AMEVCNTR114_EL0
+Field	45	AMEVTYPER113_EL0
+Field	44	AMEVCNTR113_EL0
+Field	43	AMEVTYPER112_EL0
+Field	42	AMEVCNTR112_EL0
+Field	41	AMEVTYPER111_EL0
+Field	40	AMEVCNTR111_EL0
+Field	39	AMEVTYPER110_EL0
+Field	38	AMEVCNTR110_EL0
+Field	37	AMEVTYPER19_EL0
+Field	36	AMEVCNTR19_EL0
+Field	35	AMEVTYPER18_EL0
+Field	34	AMEVCNTR18_EL0
+Field	33	AMEVTYPER17_EL0
+Field	32	AMEVCNTR17_EL0
+Field	31	AMEVTYPER16_EL0
+Field	30	AMEVCNTR16_EL0
+Field	29	AMEVTYPER15_EL0
+Field	28	AMEVCNTR15_EL0
+Field	27	AMEVTYPER14_EL0
+Field	26	AMEVCNTR14_EL0
+Field	25	AMEVTYPER13_EL0
+Field	24	AMEVCNTR13_EL0
+Field	23	AMEVTYPER12_EL0
+Field	22	AMEVCNTR12_EL0
+Field	21	AMEVTYPER11_EL0
+Field	20	AMEVCNTR11_EL0
+Field	19	AMEVTYPER10_EL0
+Field	18	AMEVCNTR10_EL0
+Field	17	AMCNTEN1
+Res0	16:5
+Field	4	AMEVCNTR03_EL0
+Field	3	AMEVCNTR02_EL0
+Field	2	AMEVCNTR01_EL0
+Field	1	AMEVCNTR00_EL0
+Field	0	AMCNTEN0
+EndSysreg
+
 Sysreg	ZCR_EL2	3	4	1	2	0
 Fields	ZCR_ELx
 EndSysreg

-- 
2.39.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 27+ messages in thread

* [PATCH 03/13] arm64/sysreg: add system register POR_EL{0,1}
  2023-12-09  1:02 [PATCH 00/13] arm64/sysreg: System register updates from the 2023-09 XML release broonie
  2023-12-09  1:02 ` [PATCH 01/13] arm64/sysreg: Update HFGITR_EL2 definiton to DDI0601 2023-09 broonie
  2023-12-09  1:02 ` [PATCH 02/13] arm64/sysreg: Add definition for HAFGRTR_EL2 broonie
@ 2023-12-09  1:02 ` broonie
  2023-12-09  1:02 ` [PATCH 04/13] arm64/sysreg: update CPACR_EL1 register broonie
                   ` (10 subsequent siblings)
  13 siblings, 0 replies; 27+ messages in thread
From: broonie @ 2023-12-09  1:02 UTC (permalink / raw)
  To: Catalin Marinas, Will Deacon
  Cc: Fuad Tabba, Joey Gouly, linux-arm-kernel, linux-kernel,
	Mark Brown

From: Joey Gouly <joey.gouly@arm.com>

Add POR_EL{0,1} according to DDI0601 2023-03.

Signed-off-by: Joey Gouly <joey.gouly@arm.com>
Reviewed-by: Mark Brown <broonie@kernel.org>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 arch/arm64/include/asm/sysreg.h | 13 +++++++++++++
 arch/arm64/tools/sysreg         | 12 ++++++++++++
 2 files changed, 25 insertions(+)

diff --git a/arch/arm64/include/asm/sysreg.h b/arch/arm64/include/asm/sysreg.h
index 5e65f51c10d2..9c2caf0efdc7 100644
--- a/arch/arm64/include/asm/sysreg.h
+++ b/arch/arm64/include/asm/sysreg.h
@@ -1039,6 +1039,19 @@
 
 #define PIRx_ELx_PERM(idx, perm)	((perm) << ((idx) * 4))
 
+/*
+ * Permission Overlay Extension (POE) permission encodings.
+ */
+#define POE_NONE	UL(0x0)
+#define POE_R		UL(0x1)
+#define POE_X		UL(0x2)
+#define POE_RX		UL(0x3)
+#define POE_W		UL(0x4)
+#define POE_RW		UL(0x5)
+#define POE_XW		UL(0x6)
+#define POE_RXW		UL(0x7)
+#define POE_MASK	UL(0xf)
+
 #define ARM64_FEATURE_FIELD_BITS	4
 
 /* Defined for compatibility only, do not add new users. */
diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg
index 145b33f75a96..1d371a24da6e 100644
--- a/arch/arm64/tools/sysreg
+++ b/arch/arm64/tools/sysreg
@@ -2555,6 +2555,18 @@ Sysreg	PIR_EL2		3	4	10	2	3
 Fields	PIRx_ELx
 EndSysreg
 
+Sysreg	POR_EL0		3	3	10	2	4
+Fields	PIRx_ELx
+EndSysreg
+
+Sysreg	POR_EL1		3	0	10	2	4
+Fields	PIRx_ELx
+EndSysreg
+
+Sysreg	POR_EL12	3	5	10	2	4
+Fields	PIRx_ELx
+EndSysreg
+
 Sysreg	LORSA_EL1	3	0	10	4	0
 Res0	63:52
 Field	51:16	SA

-- 
2.39.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 27+ messages in thread

* [PATCH 04/13] arm64/sysreg: update CPACR_EL1 register
  2023-12-09  1:02 [PATCH 00/13] arm64/sysreg: System register updates from the 2023-09 XML release broonie
                   ` (2 preceding siblings ...)
  2023-12-09  1:02 ` [PATCH 03/13] arm64/sysreg: add system register POR_EL{0,1} broonie
@ 2023-12-09  1:02 ` broonie
  2023-12-09  1:02 ` [PATCH 05/13] arm64/sysreg: Add definition for ID_AA64PFR2_EL1 Mark Brown
                   ` (9 subsequent siblings)
  13 siblings, 0 replies; 27+ messages in thread
From: broonie @ 2023-12-09  1:02 UTC (permalink / raw)
  To: Catalin Marinas, Will Deacon
  Cc: Fuad Tabba, Joey Gouly, linux-arm-kernel, linux-kernel,
	Mark Brown

From: Joey Gouly <joey.gouly@arm.com>

Add E0POE bit that traps accesses to POR_EL0 from EL0.
Updated according to DDI0601 2023-03.

Signed-off-by: Joey Gouly <joey.gouly@arm.com>
Reviewed-by: Mark Brown <broonie@kernel.org>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 arch/arm64/tools/sysreg | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg
index 1d371a24da6e..c2dbbaa22620 100644
--- a/arch/arm64/tools/sysreg
+++ b/arch/arm64/tools/sysreg
@@ -1747,7 +1747,8 @@ Field	0	M
 EndSysreg
 
 SysregFields	CPACR_ELx
-Res0	63:29
+Res0	63:30
+Field	29	E0POE
 Field	28	TTA
 Res0	27:26
 Field	25:24	SMEN

-- 
2.39.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 27+ messages in thread

* [PATCH 05/13] arm64/sysreg: Add definition for ID_AA64PFR2_EL1
  2023-12-09  1:02 [PATCH 00/13] arm64/sysreg: System register updates from the 2023-09 XML release broonie
                   ` (3 preceding siblings ...)
  2023-12-09  1:02 ` [PATCH 04/13] arm64/sysreg: update CPACR_EL1 register broonie
@ 2023-12-09  1:02 ` Mark Brown
  2023-12-11  8:59   ` Fuad Tabba
  2023-12-09  1:02 ` [PATCH 06/13] arm64/sysreg: Update ID_AA64ISAR2_EL1 defintion for DDI0601 2023-09 Mark Brown
                   ` (8 subsequent siblings)
  13 siblings, 1 reply; 27+ messages in thread
From: Mark Brown @ 2023-12-09  1:02 UTC (permalink / raw)
  To: Catalin Marinas, Will Deacon
  Cc: Fuad Tabba, Joey Gouly, linux-arm-kernel, linux-kernel,
	Mark Brown

DDI0601 2023-09 defines a new system register ID_AA64PFR2_EL1 which
enumerates FPMR and some new MTE features. Add a definition of this
register.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 arch/arm64/tools/sysreg | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg
index c2dbbaa22620..c48a3b8d00ad 100644
--- a/arch/arm64/tools/sysreg
+++ b/arch/arm64/tools/sysreg
@@ -1002,6 +1002,27 @@ UnsignedEnum	3:0	BT
 EndEnum
 EndSysreg
 
+Sysreg	ID_AA64PFR2_EL1	3	0	0	4	2
+Res0	63:36
+UnsignedEnum	35:32	FPMR
+	0b0000	NI
+	0b0001	IMP
+EndEnum
+Res0	31:12
+UnsignedEnum	11:8	MTEFAR
+	0b0000	NI
+	0b0001	IMP
+EndEnum
+UnsignedEnum	7:4	MTESTOREONLY
+	0b0000	NI
+	0b0001	IMP
+EndEnum
+UnsignedEnum	3:0	MTEPERM
+	0b0000	NI
+	0b0001	IMP
+EndEnum
+EndSysreg
+
 Sysreg	ID_AA64ZFR0_EL1	3	0	0	4	4
 Res0	63:60
 UnsignedEnum	59:56	F64MM

-- 
2.39.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 27+ messages in thread

* [PATCH 06/13] arm64/sysreg: Update ID_AA64ISAR2_EL1 defintion for DDI0601 2023-09
  2023-12-09  1:02 [PATCH 00/13] arm64/sysreg: System register updates from the 2023-09 XML release broonie
                   ` (4 preceding siblings ...)
  2023-12-09  1:02 ` [PATCH 05/13] arm64/sysreg: Add definition for ID_AA64PFR2_EL1 Mark Brown
@ 2023-12-09  1:02 ` Mark Brown
  2023-12-11  9:07   ` Fuad Tabba
  2023-12-09  1:02 ` [PATCH 07/13] arm64/sysreg: Add definition for ID_AA64ISAR3_EL1 Mark Brown
                   ` (7 subsequent siblings)
  13 siblings, 1 reply; 27+ messages in thread
From: Mark Brown @ 2023-12-09  1:02 UTC (permalink / raw)
  To: Catalin Marinas, Will Deacon
  Cc: Fuad Tabba, Joey Gouly, linux-arm-kernel, linux-kernel,
	Mark Brown

DDI0601 2023-09 defines some new fields in previously RES0 space in
ID_AA64ISAR2_EL1, together with one new enum value. Update the system
register definition to reflect this.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 arch/arm64/tools/sysreg | 24 ++++++++++++++++++++++--
 1 file changed, 22 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg
index c48a3b8d00ad..3f382f8d0f4a 100644
--- a/arch/arm64/tools/sysreg
+++ b/arch/arm64/tools/sysreg
@@ -1365,7 +1365,14 @@ EndEnum
 EndSysreg
 
 Sysreg	ID_AA64ISAR2_EL1	3	0	0	6	2
-Res0	63:56
+UnsignedEnum	63:60	ATS1A
+	0b0000	NI
+	0b0001	IMP
+EndEnum
+UnsignedEnum	59:56	LUT
+	0b0000	NI
+	0b0001	IMP
+EndEnum
 UnsignedEnum	55:52	CSSC
 	0b0000	NI
 	0b0001	IMP
@@ -1374,7 +1381,19 @@ UnsignedEnum	51:48	RPRFM
 	0b0000	NI
 	0b0001	IMP
 EndEnum
-Res0	47:32
+Res0	47:44
+UnsignedEnum	43:40	PRFMSLC
+	0b0000	NI
+	0b0001	IMP
+EndEnum
+UnsignedEnum	39:36	SYSINSTR_128
+	0b0000	NI
+	0b0001	IMP
+EndEnum
+UnsignedEnum	35:32	SYSREG_128
+	0b0000	NI
+	0b0001	IMP
+EndEnum
 UnsignedEnum	31:28	CLRBHB
 	0b0000	NI
 	0b0001	IMP
@@ -1398,6 +1417,7 @@ UnsignedEnum	15:12	APA3
 	0b0011	PAuth2
 	0b0100	FPAC
 	0b0101	FPACCOMBINE
+	0b0110	PAUTH_LR
 EndEnum
 UnsignedEnum	11:8	GPA3
 	0b0000	NI

-- 
2.39.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 27+ messages in thread

* [PATCH 07/13] arm64/sysreg: Add definition for ID_AA64ISAR3_EL1
  2023-12-09  1:02 [PATCH 00/13] arm64/sysreg: System register updates from the 2023-09 XML release broonie
                   ` (5 preceding siblings ...)
  2023-12-09  1:02 ` [PATCH 06/13] arm64/sysreg: Update ID_AA64ISAR2_EL1 defintion for DDI0601 2023-09 Mark Brown
@ 2023-12-09  1:02 ` Mark Brown
  2023-12-11  9:14   ` Fuad Tabba
  2023-12-09  1:02 ` [PATCH 08/13] arm64/sysreg: Add definition for ID_AA64FPFR0_EL1 Mark Brown
                   ` (6 subsequent siblings)
  13 siblings, 1 reply; 27+ messages in thread
From: Mark Brown @ 2023-12-09  1:02 UTC (permalink / raw)
  To: Catalin Marinas, Will Deacon
  Cc: Fuad Tabba, Joey Gouly, linux-arm-kernel, linux-kernel,
	Mark Brown

DDI0601 2023-09 adds a new system register ID_AA64ISAR3_EL1 enumerating
new floating point and TLB invalidation features. Add a defintion for it.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 arch/arm64/tools/sysreg | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg
index 3f382f8d0f4a..d1bb6ebcd959 100644
--- a/arch/arm64/tools/sysreg
+++ b/arch/arm64/tools/sysreg
@@ -1433,6 +1433,23 @@ UnsignedEnum	3:0	WFxT
 EndEnum
 EndSysreg
 
+Sysreg	ID_AA64ISAR3_EL1	3	0	0	6	3
+Res0	63:12
+UnsignedEnum	11:8	TLBIW
+	0b0000	NI
+	0b0001	IMP
+EndEnum
+UnsignedEnum	7:4	FAMINMAX
+	0b0000	NI
+	0b0001	IMP
+EndEnum
+UnsignedEnum	3:0	CPA
+	0b0000	NI
+	0b0001	IMP
+	0b0010	CPA2
+EndEnum
+EndSysreg
+
 Sysreg	ID_AA64MMFR0_EL1	3	0	0	7	0
 UnsignedEnum	63:60	ECV
 	0b0000	NI

-- 
2.39.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 27+ messages in thread

* [PATCH 08/13] arm64/sysreg: Add definition for ID_AA64FPFR0_EL1
  2023-12-09  1:02 [PATCH 00/13] arm64/sysreg: System register updates from the 2023-09 XML release broonie
                   ` (6 preceding siblings ...)
  2023-12-09  1:02 ` [PATCH 07/13] arm64/sysreg: Add definition for ID_AA64ISAR3_EL1 Mark Brown
@ 2023-12-09  1:02 ` Mark Brown
  2023-12-11  9:18   ` Fuad Tabba
  2023-12-09  1:02 ` [PATCH 09/13] arm64/sysreg: Update ID_AA64SMFR0_EL1 definition for DDI0601 2023-09 Mark Brown
                   ` (5 subsequent siblings)
  13 siblings, 1 reply; 27+ messages in thread
From: Mark Brown @ 2023-12-09  1:02 UTC (permalink / raw)
  To: Catalin Marinas, Will Deacon
  Cc: Fuad Tabba, Joey Gouly, linux-arm-kernel, linux-kernel,
	Mark Brown

DDI0601 2023-09 defines a new feature register ID_AA64FPFR0_EL1 which
enumerates a number of FP8 related features. Add a definition for it.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 arch/arm64/tools/sysreg | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg
index d1bb6ebcd959..68236cf1abda 100644
--- a/arch/arm64/tools/sysreg
+++ b/arch/arm64/tools/sysreg
@@ -1131,6 +1131,35 @@ EndEnum
 Res0	31:0
 EndSysreg
 
+Sysreg	ID_AA64FPFR0_EL1	3	0	0	4	7
+Res0	63:32
+UnsignedEnum	31	F8CVT
+	0b0	NI
+	0b1	IMP
+EndEnum
+UnsignedEnum	30	F8FMA
+	0b0	NI
+	0b1	IMP
+EndEnum
+UnsignedEnum	29	F8DP4
+	0b0	NI
+	0b1	IMP
+EndEnum
+UnsignedEnum	28	F8DP2
+	0b0	NI
+	0b1	IMP
+EndEnum
+Res0	27:2
+UnsignedEnum	1	F8E4M3
+	0b0	NI
+	0b1	IMP
+EndEnum
+UnsignedEnum	0	F8E5M2
+	0b0	NI
+	0b1	IMP
+EndEnum
+EndSysreg
+
 Sysreg	ID_AA64DFR0_EL1	3	0	0	5	0
 Enum	63:60	HPMN0
 	0b0000	UNPREDICTABLE

-- 
2.39.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 27+ messages in thread

* [PATCH 09/13] arm64/sysreg: Update ID_AA64SMFR0_EL1 definition for DDI0601 2023-09
  2023-12-09  1:02 [PATCH 00/13] arm64/sysreg: System register updates from the 2023-09 XML release broonie
                   ` (7 preceding siblings ...)
  2023-12-09  1:02 ` [PATCH 08/13] arm64/sysreg: Add definition for ID_AA64FPFR0_EL1 Mark Brown
@ 2023-12-09  1:02 ` Mark Brown
  2023-12-11  9:17   ` Fuad Tabba
  2023-12-09  1:02 ` [PATCH 10/13] arm64/sysreg: Update SCTLR_EL1 " Mark Brown
                   ` (4 subsequent siblings)
  13 siblings, 1 reply; 27+ messages in thread
From: Mark Brown @ 2023-12-09  1:02 UTC (permalink / raw)
  To: Catalin Marinas, Will Deacon
  Cc: Fuad Tabba, Joey Gouly, linux-arm-kernel, linux-kernel,
	Mark Brown

The 2023-09 release of DDI0601 defines a number of new feature enumeration
fields in ID_AA64SMFR0_EL1. Add these fields.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 arch/arm64/tools/sysreg | 30 +++++++++++++++++++++++++++---
 1 file changed, 27 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg
index 68236cf1abda..839f7cca53e0 100644
--- a/arch/arm64/tools/sysreg
+++ b/arch/arm64/tools/sysreg
@@ -1079,7 +1079,11 @@ UnsignedEnum	63	FA64
 	0b0	NI
 	0b1	IMP
 EndEnum
-Res0	62:60
+Res0	62:61
+UnsignedEnum	60	LUTv2
+	0b0	NI
+	0b1	IMP
+EndEnum
 UnsignedEnum	59:56	SMEver
 	0b0000	SME
 	0b0001	SME2
@@ -1107,7 +1111,14 @@ UnsignedEnum	42	F16F16
 	0b0	NI
 	0b1	IMP
 EndEnum
-Res0	41:40
+UnsignedEnum	41	F8F16
+	0b0	NI
+	0b1	IMP
+EndEnum
+UnsignedEnum	40	F8F32
+	0b0	NI
+	0b1	IMP
+EndEnum
 UnsignedEnum	39:36	I8I32
 	0b0000	NI
 	0b1111	IMP
@@ -1128,7 +1139,20 @@ UnsignedEnum	32	F32F32
 	0b0	NI
 	0b1	IMP
 EndEnum
-Res0	31:0
+Res0	31
+UnsignedEnum	30	SF8FMA
+	0b0	NI
+	0b1	IMP
+EndEnum
+UnsignedEnum	29	SF8DP4
+	0b0	NI
+	0b1	IMP
+EndEnum
+UnsignedEnum	28	SF8DP2
+	0b0	NI
+	0b1	IMP
+EndEnum
+Res0	27:0
 EndSysreg
 
 Sysreg	ID_AA64FPFR0_EL1	3	0	0	4	7

-- 
2.39.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 27+ messages in thread

* [PATCH 10/13] arm64/sysreg: Update SCTLR_EL1 for DDI0601 2023-09
  2023-12-09  1:02 [PATCH 00/13] arm64/sysreg: System register updates from the 2023-09 XML release broonie
                   ` (8 preceding siblings ...)
  2023-12-09  1:02 ` [PATCH 09/13] arm64/sysreg: Update ID_AA64SMFR0_EL1 definition for DDI0601 2023-09 Mark Brown
@ 2023-12-09  1:02 ` Mark Brown
  2023-12-11  9:19   ` Fuad Tabba
  2023-12-09  1:02 ` [PATCH 11/13] arm64/sysreg: Update HCRX_EL2 definition " Mark Brown
                   ` (3 subsequent siblings)
  13 siblings, 1 reply; 27+ messages in thread
From: Mark Brown @ 2023-12-09  1:02 UTC (permalink / raw)
  To: Catalin Marinas, Will Deacon
  Cc: Fuad Tabba, Joey Gouly, linux-arm-kernel, linux-kernel,
	Mark Brown

DDI0601 2023-09 defines some new fields in SCTLR_EL1 controlling new MTE
and floating point features. Update our sysreg definition to reflect these.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 arch/arm64/tools/sysreg | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg
index 839f7cca53e0..4137179e7570 100644
--- a/arch/arm64/tools/sysreg
+++ b/arch/arm64/tools/sysreg
@@ -1791,7 +1791,8 @@ Field	63	TIDCP
 Field	62	SPINTMASK
 Field	61	NMI
 Field	60	EnTP2
-Res0	59:58
+Field	59	TCSO
+Field	58	TCSO0
 Field	57	EPAN
 Field	56	EnALS
 Field	55	EnAS0
@@ -1820,7 +1821,7 @@ EndEnum
 Field	37	ITFSB
 Field	36	BT1
 Field	35	BT0
-Res0	34
+Field	34	EnFPM
 Field	33	MSCEn
 Field	32	CMOW
 Field	31	EnIA

-- 
2.39.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 27+ messages in thread

* [PATCH 11/13] arm64/sysreg: Update HCRX_EL2 definition for DDI0601 2023-09
  2023-12-09  1:02 [PATCH 00/13] arm64/sysreg: System register updates from the 2023-09 XML release broonie
                   ` (9 preceding siblings ...)
  2023-12-09  1:02 ` [PATCH 10/13] arm64/sysreg: Update SCTLR_EL1 " Mark Brown
@ 2023-12-09  1:02 ` Mark Brown
  2023-12-11  9:26   ` Fuad Tabba
  2023-12-09  1:02 ` [PATCH 12/13] arm64/sysreg: Add definition for FPMR Mark Brown
                   ` (2 subsequent siblings)
  13 siblings, 1 reply; 27+ messages in thread
From: Mark Brown @ 2023-12-09  1:02 UTC (permalink / raw)
  To: Catalin Marinas, Will Deacon
  Cc: Fuad Tabba, Joey Gouly, linux-arm-kernel, linux-kernel,
	Mark Brown

DDI0601 2023-09 defines new fields in HCRX_EL2 controlling access to new
system registers, update our definition of HCRX_EL2 to reflect this.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 arch/arm64/tools/sysreg | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg
index 4137179e7570..1acec8f5c37d 100644
--- a/arch/arm64/tools/sysreg
+++ b/arch/arm64/tools/sysreg
@@ -2458,7 +2458,9 @@ Fields	ZCR_ELx
 EndSysreg
 
 Sysreg	HCRX_EL2	3	4	1	2	2
-Res0	63:23
+Res0	63:25
+Field	24	PACMEn
+Field	23	EnFPM
 Field	22	GCSEn
 Field	21	EnIDCP128
 Field	20	EnSDERR

-- 
2.39.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 27+ messages in thread

* [PATCH 12/13] arm64/sysreg: Add definition for FPMR
  2023-12-09  1:02 [PATCH 00/13] arm64/sysreg: System register updates from the 2023-09 XML release broonie
                   ` (10 preceding siblings ...)
  2023-12-09  1:02 ` [PATCH 11/13] arm64/sysreg: Update HCRX_EL2 definition " Mark Brown
@ 2023-12-09  1:02 ` Mark Brown
  2023-12-11  9:28   ` Fuad Tabba
  2023-12-09  1:02 ` [PATCH 13/13] arm64/sysreg: Add new system registers for GCS Mark Brown
  2023-12-11 20:27 ` [PATCH 00/13] arm64/sysreg: System register updates from the 2023-09 XML release Will Deacon
  13 siblings, 1 reply; 27+ messages in thread
From: Mark Brown @ 2023-12-09  1:02 UTC (permalink / raw)
  To: Catalin Marinas, Will Deacon
  Cc: Fuad Tabba, Joey Gouly, linux-arm-kernel, linux-kernel,
	Mark Brown

DDI0601 2023-09 defines a new sysrem register FPMR (Floating Point Mode
Register) which configures the new FP8 features. Add a definition of this
register.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 arch/arm64/tools/sysreg | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg
index 1acec8f5c37d..1c6d1c904750 100644
--- a/arch/arm64/tools/sysreg
+++ b/arch/arm64/tools/sysreg
@@ -2139,6 +2139,29 @@ Field	1	ZA
 Field	0	SM
 EndSysreg
 
+Sysreg	FPMR	3	3	4	4	2
+Res0	63:38
+Field	37:32	LSCALE2
+Field	31:24	NSCALE
+Res0	23
+Field	22:16	LSCALE
+Field	15	OSC
+Field	14	OSM
+Res0	13:9
+UnsignedEnum	8:6	F8D
+	0b000	E5M2
+	0b001	E4M3
+EndEnum
+UnsignedEnum	5:3	F8S2
+	0b000	E5M2
+	0b001	E4M3
+EndEnum
+UnsignedEnum	2:0	F8S1
+	0b000	E5M2
+	0b001	E4M3
+EndEnum
+EndSysreg
+
 SysregFields	HFGxTR_EL2
 Field	63	nAMAIR2_EL1
 Field	62	nMAIR2_EL1

-- 
2.39.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 27+ messages in thread

* [PATCH 13/13] arm64/sysreg: Add new system registers for GCS
  2023-12-09  1:02 [PATCH 00/13] arm64/sysreg: System register updates from the 2023-09 XML release broonie
                   ` (11 preceding siblings ...)
  2023-12-09  1:02 ` [PATCH 12/13] arm64/sysreg: Add definition for FPMR Mark Brown
@ 2023-12-09  1:02 ` Mark Brown
  2023-12-11  9:38   ` Fuad Tabba
  2023-12-11 20:27 ` [PATCH 00/13] arm64/sysreg: System register updates from the 2023-09 XML release Will Deacon
  13 siblings, 1 reply; 27+ messages in thread
From: Mark Brown @ 2023-12-09  1:02 UTC (permalink / raw)
  To: Catalin Marinas, Will Deacon
  Cc: Fuad Tabba, Joey Gouly, linux-arm-kernel, linux-kernel,
	Mark Brown

FEAT_GCS introduces a number of new system registers. Add the registers
available up to EL2 to sysreg as per DDI0601 2022-12.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 arch/arm64/tools/sysreg | 55 +++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 55 insertions(+)

diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg
index 1c6d1c904750..b2007963523e 100644
--- a/arch/arm64/tools/sysreg
+++ b/arch/arm64/tools/sysreg
@@ -1903,6 +1903,41 @@ Sysreg	SMCR_EL1	3	0	1	2	6
 Fields	SMCR_ELx
 EndSysreg
 
+SysregFields	GCSCR_ELx
+Res0	63:10
+Field	9	STREn
+Field	8	PUSHMEn
+Res0	7
+Field	6	EXLOCKEN
+Field	5	RVCHKEN
+Res0	4:1
+Field	0	PCRSEL
+EndSysregFields
+
+Sysreg	GCSCR_EL1	3	0	2	5	0
+Fields	GCSCR_ELx
+EndSysreg
+
+SysregFields	GCSPR_ELx
+Field	63:3	PTR
+Res0	2:0
+EndSysregFields
+
+Sysreg	GCSPR_EL1	3	0	2	5	1
+Fields	GCSPR_ELx
+EndSysreg
+
+Sysreg	GCSCRE0_EL1	3	0	2	5	2
+Res0	63:11
+Field	10	nTR
+Field	9	STREn
+Field	8	PUSHMEn
+Res0	7:6
+Field	5	RVCHKEN
+Res0	4:1
+Field	0	PCRSEL
+EndSysreg
+
 Sysreg	ALLINT	3	0	4	3	0
 Res0	63:14
 Field	13	ALLINT
@@ -2133,6 +2168,10 @@ Field	4	DZP
 Field	3:0	BS
 EndSysreg
 
+Sysreg	GCSPR_EL0	3	3	2	5	1
+Fields	GCSPR_ELx
+EndSysreg
+
 Sysreg	SVCR	3	3	4	2	2
 Res0	63:2
 Field	1	ZA
@@ -2531,6 +2570,14 @@ Sysreg	SMCR_EL2	3	4	1	2	6
 Fields	SMCR_ELx
 EndSysreg
 
+Sysreg	GCSCR_EL2	3	4	2	5	0
+Fields	GCSCR_ELx
+EndSysreg
+
+Sysreg	GCSPR_EL2	3	4	2	5	1
+Fields	GCSPR_ELx
+EndSysreg
+
 Sysreg	DACR32_EL2	3	4	3	0	0
 Res0	63:32
 Field	31:30	D15
@@ -2590,6 +2637,14 @@ Sysreg	SMCR_EL12	3	5	1	2	6
 Fields	SMCR_ELx
 EndSysreg
 
+Sysreg	GCSCR_EL12	3	5	2	5	0
+Fields	GCSCR_ELx
+EndSysreg
+
+Sysreg	GCSPR_EL12	3	5	2	5	1
+Fields	GCSPR_ELx
+EndSysreg
+
 Sysreg	FAR_EL12	3	5	6	0	0
 Field	63:0	ADDR
 EndSysreg

-- 
2.39.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 27+ messages in thread

* Re: [PATCH 05/13] arm64/sysreg: Add definition for ID_AA64PFR2_EL1
  2023-12-09  1:02 ` [PATCH 05/13] arm64/sysreg: Add definition for ID_AA64PFR2_EL1 Mark Brown
@ 2023-12-11  8:59   ` Fuad Tabba
  0 siblings, 0 replies; 27+ messages in thread
From: Fuad Tabba @ 2023-12-11  8:59 UTC (permalink / raw)
  To: Mark Brown
  Cc: Catalin Marinas, Will Deacon, Joey Gouly, linux-arm-kernel,
	linux-kernel

Hi Mark,

Thanks for putting this patch series together.

On Sat, Dec 9, 2023 at 1:03 AM Mark Brown <broonie@kernel.org> wrote:
>
> DDI0601 2023-09 defines a new system register ID_AA64PFR2_EL1 which
> enumerates FPMR and some new MTE features. Add a definition of this
> register.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>

Reviewed-by: Fuad Tabba <tabba@google.com>

Cheers,
/fuad

> ---
>  arch/arm64/tools/sysreg | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>
> diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg
> index c2dbbaa22620..c48a3b8d00ad 100644
> --- a/arch/arm64/tools/sysreg
> +++ b/arch/arm64/tools/sysreg
> @@ -1002,6 +1002,27 @@ UnsignedEnum     3:0     BT
>  EndEnum
>  EndSysreg
>
> +Sysreg ID_AA64PFR2_EL1 3       0       0       4       2
> +Res0   63:36
> +UnsignedEnum   35:32   FPMR
> +       0b0000  NI
> +       0b0001  IMP
> +EndEnum
> +Res0   31:12
> +UnsignedEnum   11:8    MTEFAR
> +       0b0000  NI
> +       0b0001  IMP
> +EndEnum
> +UnsignedEnum   7:4     MTESTOREONLY
> +       0b0000  NI
> +       0b0001  IMP
> +EndEnum
> +UnsignedEnum   3:0     MTEPERM
> +       0b0000  NI
> +       0b0001  IMP
> +EndEnum
> +EndSysreg
> +
>  Sysreg ID_AA64ZFR0_EL1 3       0       0       4       4
>  Res0   63:60
>  UnsignedEnum   59:56   F64MM
>
> --
> 2.39.2
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PATCH 06/13] arm64/sysreg: Update ID_AA64ISAR2_EL1 defintion for DDI0601 2023-09
  2023-12-09  1:02 ` [PATCH 06/13] arm64/sysreg: Update ID_AA64ISAR2_EL1 defintion for DDI0601 2023-09 Mark Brown
@ 2023-12-11  9:07   ` Fuad Tabba
  2023-12-12  9:10     ` Will Deacon
  0 siblings, 1 reply; 27+ messages in thread
From: Fuad Tabba @ 2023-12-11  9:07 UTC (permalink / raw)
  To: Mark Brown
  Cc: Catalin Marinas, Will Deacon, Joey Gouly, linux-arm-kernel,
	linux-kernel

Hi Mark,

On Sat, Dec 9, 2023 at 1:03 AM Mark Brown <broonie@kernel.org> wrote:
>
> DDI0601 2023-09 defines some new fields in previously RES0 space in
> ID_AA64ISAR2_EL1, together with one new enum value. Update the system
> register definition to reflect this.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>

> ---
>  arch/arm64/tools/sysreg | 24 ++++++++++++++++++++++--
>  1 file changed, 22 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg
> index c48a3b8d00ad..3f382f8d0f4a 100644
> --- a/arch/arm64/tools/sysreg
> +++ b/arch/arm64/tools/sysreg
> @@ -1365,7 +1365,14 @@ EndEnum
>  EndSysreg
>
>  Sysreg ID_AA64ISAR2_EL1        3       0       0       6       2
> -Res0   63:56
> +UnsignedEnum   63:60   ATS1A
> +       0b0000  NI
> +       0b0001  IMP
> +EndEnum
> +UnsignedEnum   59:56   LUT
> +       0b0000  NI
> +       0b0001  IMP
> +EndEnum
>  UnsignedEnum   55:52   CSSC
>         0b0000  NI
>         0b0001  IMP
> @@ -1374,7 +1381,19 @@ UnsignedEnum     51:48   RPRFM
>         0b0000  NI
>         0b0001  IMP
>  EndEnum
> -Res0   47:32
> +Res0   47:44
> +UnsignedEnum   43:40   PRFMSLC
> +       0b0000  NI
> +       0b0001  IMP
> +EndEnum
> +UnsignedEnum   39:36   SYSINSTR_128
> +       0b0000  NI
> +       0b0001  IMP
> +EndEnum
> +UnsignedEnum   35:32   SYSREG_128
> +       0b0000  NI
> +       0b0001  IMP
> +EndEnum
>  UnsignedEnum   31:28   CLRBHB
>         0b0000  NI
>         0b0001  IMP
> @@ -1398,6 +1417,7 @@ UnsignedEnum      15:12   APA3
>         0b0011  PAuth2
>         0b0100  FPAC
>         0b0101  FPACCOMBINE
> +       0b0110  PAUTH_LR

Nit: PAuth and PAuth2 only have the PA as uppercase in this file,
which matches the spec. Should PAuth_LR be the same?

Otherwise,
Reviewed-by: Fuad Tabba <tabba@google.com>

Cheers,
/fuad


>  EndEnum
>  UnsignedEnum   11:8    GPA3
>         0b0000  NI
>
> --
> 2.39.2
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PATCH 07/13] arm64/sysreg: Add definition for ID_AA64ISAR3_EL1
  2023-12-09  1:02 ` [PATCH 07/13] arm64/sysreg: Add definition for ID_AA64ISAR3_EL1 Mark Brown
@ 2023-12-11  9:14   ` Fuad Tabba
  0 siblings, 0 replies; 27+ messages in thread
From: Fuad Tabba @ 2023-12-11  9:14 UTC (permalink / raw)
  To: Mark Brown
  Cc: Catalin Marinas, Will Deacon, Joey Gouly, linux-arm-kernel,
	linux-kernel

Hi Mark,


On Sat, Dec 9, 2023 at 1:03 AM Mark Brown <broonie@kernel.org> wrote:
>
> DDI0601 2023-09 adds a new system register ID_AA64ISAR3_EL1 enumerating
> new floating point and TLB invalidation features. Add a defintion for it.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>

Reviewed-by: Fuad Tabba <tabba@google.com>

Cheers,
/fuad

> ---
>  arch/arm64/tools/sysreg | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>
> diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg
> index 3f382f8d0f4a..d1bb6ebcd959 100644
> --- a/arch/arm64/tools/sysreg
> +++ b/arch/arm64/tools/sysreg
> @@ -1433,6 +1433,23 @@ UnsignedEnum     3:0     WFxT
>  EndEnum
>  EndSysreg
>
> +Sysreg ID_AA64ISAR3_EL1        3       0       0       6       3
> +Res0   63:12
> +UnsignedEnum   11:8    TLBIW
> +       0b0000  NI
> +       0b0001  IMP
> +EndEnum
> +UnsignedEnum   7:4     FAMINMAX
> +       0b0000  NI
> +       0b0001  IMP
> +EndEnum
> +UnsignedEnum   3:0     CPA
> +       0b0000  NI
> +       0b0001  IMP
> +       0b0010  CPA2
> +EndEnum
> +EndSysreg
> +


>  Sysreg ID_AA64MMFR0_EL1        3       0       0       7       0
>  UnsignedEnum   63:60   ECV
>         0b0000  NI
>
> --
> 2.39.2
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PATCH 09/13] arm64/sysreg: Update ID_AA64SMFR0_EL1 definition for DDI0601 2023-09
  2023-12-09  1:02 ` [PATCH 09/13] arm64/sysreg: Update ID_AA64SMFR0_EL1 definition for DDI0601 2023-09 Mark Brown
@ 2023-12-11  9:17   ` Fuad Tabba
  0 siblings, 0 replies; 27+ messages in thread
From: Fuad Tabba @ 2023-12-11  9:17 UTC (permalink / raw)
  To: Mark Brown
  Cc: Catalin Marinas, Will Deacon, Joey Gouly, linux-arm-kernel,
	linux-kernel

Hi Mark,

On Sat, Dec 9, 2023 at 1:03 AM Mark Brown <broonie@kernel.org> wrote:
>
> The 2023-09 release of DDI0601 defines a number of new feature enumeration
> fields in ID_AA64SMFR0_EL1. Add these fields.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>

Reviewed-by: Fuad Tabba <tabba@google.com>

Cheers,
/fuad

> ---
>  arch/arm64/tools/sysreg | 30 +++++++++++++++++++++++++++---
>  1 file changed, 27 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg
> index 68236cf1abda..839f7cca53e0 100644
> --- a/arch/arm64/tools/sysreg
> +++ b/arch/arm64/tools/sysreg
> @@ -1079,7 +1079,11 @@ UnsignedEnum     63      FA64
>         0b0     NI
>         0b1     IMP
>  EndEnum
> -Res0   62:60
> +Res0   62:61
> +UnsignedEnum   60      LUTv2
> +       0b0     NI
> +       0b1     IMP
> +EndEnum
>  UnsignedEnum   59:56   SMEver
>         0b0000  SME
>         0b0001  SME2
> @@ -1107,7 +1111,14 @@ UnsignedEnum     42      F16F16
>         0b0     NI
>         0b1     IMP
>  EndEnum
> -Res0   41:40
> +UnsignedEnum   41      F8F16
> +       0b0     NI
> +       0b1     IMP
> +EndEnum
> +UnsignedEnum   40      F8F32
> +       0b0     NI
> +       0b1     IMP
> +EndEnum
>  UnsignedEnum   39:36   I8I32
>         0b0000  NI
>         0b1111  IMP
> @@ -1128,7 +1139,20 @@ UnsignedEnum     32      F32F32
>         0b0     NI
>         0b1     IMP
>  EndEnum
> -Res0   31:0
> +Res0   31
> +UnsignedEnum   30      SF8FMA
> +       0b0     NI
> +       0b1     IMP
> +EndEnum
> +UnsignedEnum   29      SF8DP4
> +       0b0     NI
> +       0b1     IMP
> +EndEnum
> +UnsignedEnum   28      SF8DP2
> +       0b0     NI
> +       0b1     IMP
> +EndEnum
> +Res0   27:0
>  EndSysreg
>
>  Sysreg ID_AA64FPFR0_EL1        3       0       0       4       7
>
> --
> 2.39.2
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PATCH 08/13] arm64/sysreg: Add definition for ID_AA64FPFR0_EL1
  2023-12-09  1:02 ` [PATCH 08/13] arm64/sysreg: Add definition for ID_AA64FPFR0_EL1 Mark Brown
@ 2023-12-11  9:18   ` Fuad Tabba
  0 siblings, 0 replies; 27+ messages in thread
From: Fuad Tabba @ 2023-12-11  9:18 UTC (permalink / raw)
  To: Mark Brown
  Cc: Catalin Marinas, Will Deacon, Joey Gouly, linux-arm-kernel,
	linux-kernel

Hi Mark,


On Sat, Dec 9, 2023 at 1:03 AM Mark Brown <broonie@kernel.org> wrote:
>
> DDI0601 2023-09 defines a new feature register ID_AA64FPFR0_EL1 which
> enumerates a number of FP8 related features. Add a definition for it.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---

Reviewed-by: Fuad Tabba <tabba@google.com>

Cheers,
/fuad

>  arch/arm64/tools/sysreg | 29 +++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
>
> diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg
> index d1bb6ebcd959..68236cf1abda 100644
> --- a/arch/arm64/tools/sysreg
> +++ b/arch/arm64/tools/sysreg
> @@ -1131,6 +1131,35 @@ EndEnum
>  Res0   31:0
>  EndSysreg
>
> +Sysreg ID_AA64FPFR0_EL1        3       0       0       4       7
> +Res0   63:32
> +UnsignedEnum   31      F8CVT
> +       0b0     NI
> +       0b1     IMP
> +EndEnum
> +UnsignedEnum   30      F8FMA
> +       0b0     NI
> +       0b1     IMP
> +EndEnum
> +UnsignedEnum   29      F8DP4
> +       0b0     NI
> +       0b1     IMP
> +EndEnum
> +UnsignedEnum   28      F8DP2
> +       0b0     NI
> +       0b1     IMP
> +EndEnum
> +Res0   27:2
> +UnsignedEnum   1       F8E4M3
> +       0b0     NI
> +       0b1     IMP
> +EndEnum
> +UnsignedEnum   0       F8E5M2
> +       0b0     NI
> +       0b1     IMP
> +EndEnum
> +EndSysreg
> +
>  Sysreg ID_AA64DFR0_EL1 3       0       0       5       0
>  Enum   63:60   HPMN0
>         0b0000  UNPREDICTABLE
>
> --
> 2.39.2
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PATCH 10/13] arm64/sysreg: Update SCTLR_EL1 for DDI0601 2023-09
  2023-12-09  1:02 ` [PATCH 10/13] arm64/sysreg: Update SCTLR_EL1 " Mark Brown
@ 2023-12-11  9:19   ` Fuad Tabba
  0 siblings, 0 replies; 27+ messages in thread
From: Fuad Tabba @ 2023-12-11  9:19 UTC (permalink / raw)
  To: Mark Brown
  Cc: Catalin Marinas, Will Deacon, Joey Gouly, linux-arm-kernel,
	linux-kernel

Hi Mark,


On Sat, Dec 9, 2023 at 1:03 AM Mark Brown <broonie@kernel.org> wrote:
>
> DDI0601 2023-09 defines some new fields in SCTLR_EL1 controlling new MTE
> and floating point features. Update our sysreg definition to reflect these.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---

Reviewed-by: Fuad Tabba <tabba@google.com>

Cheers,
/fuad

>  arch/arm64/tools/sysreg | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg
> index 839f7cca53e0..4137179e7570 100644
> --- a/arch/arm64/tools/sysreg
> +++ b/arch/arm64/tools/sysreg
> @@ -1791,7 +1791,8 @@ Field     63      TIDCP
>  Field  62      SPINTMASK
>  Field  61      NMI
>  Field  60      EnTP2
> -Res0   59:58
> +Field  59      TCSO
> +Field  58      TCSO0
>  Field  57      EPAN
>  Field  56      EnALS
>  Field  55      EnAS0
> @@ -1820,7 +1821,7 @@ EndEnum
>  Field  37      ITFSB
>  Field  36      BT1
>  Field  35      BT0
> -Res0   34
> +Field  34      EnFPM
>  Field  33      MSCEn
>  Field  32      CMOW
>  Field  31      EnIA
>
> --
> 2.39.2
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PATCH 11/13] arm64/sysreg: Update HCRX_EL2 definition for DDI0601 2023-09
  2023-12-09  1:02 ` [PATCH 11/13] arm64/sysreg: Update HCRX_EL2 definition " Mark Brown
@ 2023-12-11  9:26   ` Fuad Tabba
  0 siblings, 0 replies; 27+ messages in thread
From: Fuad Tabba @ 2023-12-11  9:26 UTC (permalink / raw)
  To: Mark Brown
  Cc: Catalin Marinas, Will Deacon, Joey Gouly, linux-arm-kernel,
	linux-kernel

Hi Mark,

On Sat, Dec 9, 2023 at 1:03 AM Mark Brown <broonie@kernel.org> wrote:
>
> DDI0601 2023-09 defines new fields in HCRX_EL2 controlling access to new
> system registers, update our definition of HCRX_EL2 to reflect this.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---

This is not an issue with this patch per se, but all FGT registers
prefix bits that trap on 0 with an n, e.g., HFGxTR_EL2:
nAMAIR2_EL1...nACCDATA_EL1, but not HCRX_EL2. I think that most
HCRX_EL2 bits trap on 0, except for TALLINT. It shouldn't be done in
this patch, but I'm wondering if it's worth the hassle to rename the
bits, or if there's too much existing code and in-flight patches that
it's more trouble than it's worth.

That said,
Reviewed-by: Fuad Tabba <tabba@google.com>

Cheers,
/fuad

>  arch/arm64/tools/sysreg | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg
> index 4137179e7570..1acec8f5c37d 100644
> --- a/arch/arm64/tools/sysreg
> +++ b/arch/arm64/tools/sysreg
> @@ -2458,7 +2458,9 @@ Fields    ZCR_ELx
>  EndSysreg
>
>  Sysreg HCRX_EL2        3       4       1       2       2
> -Res0   63:23
> +Res0   63:25
> +Field  24      PACMEn
> +Field  23      EnFPM
>  Field  22      GCSEn
>  Field  21      EnIDCP128
>  Field  20      EnSDERR
>
> --
> 2.39.2
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PATCH 12/13] arm64/sysreg: Add definition for FPMR
  2023-12-09  1:02 ` [PATCH 12/13] arm64/sysreg: Add definition for FPMR Mark Brown
@ 2023-12-11  9:28   ` Fuad Tabba
  0 siblings, 0 replies; 27+ messages in thread
From: Fuad Tabba @ 2023-12-11  9:28 UTC (permalink / raw)
  To: Mark Brown
  Cc: Catalin Marinas, Will Deacon, Joey Gouly, linux-arm-kernel,
	linux-kernel

Hi Mark,

On Sat, Dec 9, 2023 at 1:03 AM Mark Brown <broonie@kernel.org> wrote:
>
> DDI0601 2023-09 defines a new sysrem register FPMR (Floating Point Mode
> Register) which configures the new FP8 features. Add a definition of this
> register.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---

Reviewed-by: Fuad Tabba <tabba@google.com>

Cheers,
/fuad

>  arch/arm64/tools/sysreg | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>
> diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg
> index 1acec8f5c37d..1c6d1c904750 100644
> --- a/arch/arm64/tools/sysreg
> +++ b/arch/arm64/tools/sysreg
> @@ -2139,6 +2139,29 @@ Field    1       ZA
>  Field  0       SM
>  EndSysreg
>
> +Sysreg FPMR    3       3       4       4       2
> +Res0   63:38
> +Field  37:32   LSCALE2
> +Field  31:24   NSCALE
> +Res0   23
> +Field  22:16   LSCALE
> +Field  15      OSC
> +Field  14      OSM
> +Res0   13:9
> +UnsignedEnum   8:6     F8D
> +       0b000   E5M2
> +       0b001   E4M3
> +EndEnum
> +UnsignedEnum   5:3     F8S2
> +       0b000   E5M2
> +       0b001   E4M3
> +EndEnum
> +UnsignedEnum   2:0     F8S1
> +       0b000   E5M2
> +       0b001   E4M3
> +EndEnum
> +EndSysreg
> +
>  SysregFields   HFGxTR_EL2
>  Field  63      nAMAIR2_EL1
>  Field  62      nMAIR2_EL1
>
> --
> 2.39.2
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PATCH 13/13] arm64/sysreg: Add new system registers for GCS
  2023-12-09  1:02 ` [PATCH 13/13] arm64/sysreg: Add new system registers for GCS Mark Brown
@ 2023-12-11  9:38   ` Fuad Tabba
  0 siblings, 0 replies; 27+ messages in thread
From: Fuad Tabba @ 2023-12-11  9:38 UTC (permalink / raw)
  To: Mark Brown
  Cc: Catalin Marinas, Will Deacon, Joey Gouly, linux-arm-kernel,
	linux-kernel

Hi Mark,

On Sat, Dec 9, 2023 at 1:04 AM Mark Brown <broonie@kernel.org> wrote:
>
> FEAT_GCS introduces a number of new system registers. Add the registers
> available up to EL2 to sysreg as per DDI0601 2022-12.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
>  arch/arm64/tools/sysreg | 55 +++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 55 insertions(+)
>
> diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg
> index 1c6d1c904750..b2007963523e 100644
> --- a/arch/arm64/tools/sysreg
> +++ b/arch/arm64/tools/sysreg
> @@ -1903,6 +1903,41 @@ Sysreg   SMCR_EL1        3       0       1       2       6
>  Fields SMCR_ELx
>  EndSysreg
>
> +SysregFields   GCSCR_ELx
> +Res0   63:10
> +Field  9       STREn
> +Field  8       PUSHMEn

This is related to my comment for patch 11/13 on HCRX_EL2, now we have
a case where the n is in the spec itself, rather than a prefix. Not
sure if it would be good to add an n as a prefix as well to these,
since they do trap at 0, or if you should just forget my comment on
patch 11 :)

Reviewed-by: Fuad Tabba <tabba@google.com>

Cheers,
/fuad



> +Res0   7
> +Field  6       EXLOCKEN
> +Field  5       RVCHKEN
> +Res0   4:1
> +Field  0       PCRSEL
> +EndSysregFields
> +
> +Sysreg GCSCR_EL1       3       0       2       5       0
> +Fields GCSCR_ELx
> +EndSysreg
> +
> +SysregFields   GCSPR_ELx
> +Field  63:3    PTR
> +Res0   2:0
> +EndSysregFields
> +
> +Sysreg GCSPR_EL1       3       0       2       5       1
> +Fields GCSPR_ELx
> +EndSysreg
> +
> +Sysreg GCSCRE0_EL1     3       0       2       5       2
> +Res0   63:11
> +Field  10      nTR
> +Field  9       STREn
> +Field  8       PUSHMEn
> +Res0   7:6
> +Field  5       RVCHKEN
> +Res0   4:1
> +Field  0       PCRSEL
> +EndSysreg
> +
>  Sysreg ALLINT  3       0       4       3       0
>  Res0   63:14
>  Field  13      ALLINT
> @@ -2133,6 +2168,10 @@ Field    4       DZP
>  Field  3:0     BS
>  EndSysreg
>
> +Sysreg GCSPR_EL0       3       3       2       5       1
> +Fields GCSPR_ELx
> +EndSysreg
> +
>  Sysreg SVCR    3       3       4       2       2
>  Res0   63:2
>  Field  1       ZA
> @@ -2531,6 +2570,14 @@ Sysreg   SMCR_EL2        3       4       1       2       6
>  Fields SMCR_ELx
>  EndSysreg
>
> +Sysreg GCSCR_EL2       3       4       2       5       0
> +Fields GCSCR_ELx
> +EndSysreg
> +
> +Sysreg GCSPR_EL2       3       4       2       5       1
> +Fields GCSPR_ELx
> +EndSysreg
> +
>  Sysreg DACR32_EL2      3       4       3       0       0
>  Res0   63:32
>  Field  31:30   D15
> @@ -2590,6 +2637,14 @@ Sysreg   SMCR_EL12       3       5       1       2       6
>  Fields SMCR_ELx
>  EndSysreg
>
> +Sysreg GCSCR_EL12      3       5       2       5       0
> +Fields GCSCR_ELx
> +EndSysreg
> +
> +Sysreg GCSPR_EL12      3       5       2       5       1
> +Fields GCSPR_ELx
> +EndSysreg
> +
>  Sysreg FAR_EL12        3       5       6       0       0
>  Field  63:0    ADDR
>  EndSysreg
>
> --
> 2.39.2
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PATCH 00/13] arm64/sysreg: System register updates from the 2023-09 XML release
  2023-12-09  1:02 [PATCH 00/13] arm64/sysreg: System register updates from the 2023-09 XML release broonie
                   ` (12 preceding siblings ...)
  2023-12-09  1:02 ` [PATCH 13/13] arm64/sysreg: Add new system registers for GCS Mark Brown
@ 2023-12-11 20:27 ` Will Deacon
  13 siblings, 0 replies; 27+ messages in thread
From: Will Deacon @ 2023-12-11 20:27 UTC (permalink / raw)
  To: broonie, Catalin Marinas
  Cc: kernel-team, Will Deacon, linux-kernel, linux-arm-kernel,
	Joey Gouly, Fuad Tabba

On Sat, 09 Dec 2023 01:02:46 +0000, broonie@kernel.org wrote:
> A number of serieses on the list have updates updates and additions to
> the system registers, and as a result of the work being done on KVM
> (especially nested virtualisation) there are overlaps and duplication of
> work between people unaware of other pending serieses.  This series
> collects together all the work that's been done on updating the system
> register definitions that don't have pending review issues which I'm
> aware of with the aim of at least making it easier to find things.
> 
> [...]

Applied to arm64 (for-next/sysregs), thanks!

[01/13] arm64/sysreg: Update HFGITR_EL2 definiton to DDI0601 2023-09
        https://git.kernel.org/arm64/c/256f442895ed
[02/13] arm64/sysreg: Add definition for HAFGRTR_EL2
        https://git.kernel.org/arm64/c/41bb68fbd016
[03/13] arm64/sysreg: add system register POR_EL{0,1}
        https://git.kernel.org/arm64/c/c0c5a8ea96b8
[04/13] arm64/sysreg: update CPACR_EL1 register
        https://git.kernel.org/arm64/c/35768b23d830
[05/13] arm64/sysreg: Add definition for ID_AA64PFR2_EL1
        https://git.kernel.org/arm64/c/9fb5dc53a117
[06/13] arm64/sysreg: Update ID_AA64ISAR2_EL1 defintion for DDI0601 2023-09
        https://git.kernel.org/arm64/c/6e3dcfd13975
[07/13] arm64/sysreg: Add definition for ID_AA64ISAR3_EL1
        https://git.kernel.org/arm64/c/b5aefb668701
[08/13] arm64/sysreg: Add definition for ID_AA64FPFR0_EL1
        https://git.kernel.org/arm64/c/9e4f409b07df
[09/13] arm64/sysreg: Update ID_AA64SMFR0_EL1 definition for DDI0601 2023-09
        https://git.kernel.org/arm64/c/8afe582d7700
[10/13] arm64/sysreg: Update SCTLR_EL1 for DDI0601 2023-09
        https://git.kernel.org/arm64/c/a6052284a9f9
[11/13] arm64/sysreg: Update HCRX_EL2 definition for DDI0601 2023-09
        https://git.kernel.org/arm64/c/126cb3a60d35
[12/13] arm64/sysreg: Add definition for FPMR
        https://git.kernel.org/arm64/c/e3a649ecf8b9
[13/13] arm64/sysreg: Add new system registers for GCS
        https://git.kernel.org/arm64/c/e94e06d8a796

Cheers,
-- 
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PATCH 06/13] arm64/sysreg: Update ID_AA64ISAR2_EL1 defintion for DDI0601 2023-09
  2023-12-11  9:07   ` Fuad Tabba
@ 2023-12-12  9:10     ` Will Deacon
  2023-12-12 10:24       ` Fuad Tabba
  0 siblings, 1 reply; 27+ messages in thread
From: Will Deacon @ 2023-12-12  9:10 UTC (permalink / raw)
  To: Fuad Tabba
  Cc: Mark Brown, Catalin Marinas, Joey Gouly, linux-arm-kernel,
	linux-kernel

On Mon, Dec 11, 2023 at 09:07:25AM +0000, Fuad Tabba wrote:
> On Sat, Dec 9, 2023 at 1:03 AM Mark Brown <broonie@kernel.org> wrote:
> >
> > DDI0601 2023-09 defines some new fields in previously RES0 space in
> > ID_AA64ISAR2_EL1, together with one new enum value. Update the system
> > register definition to reflect this.
> >
> > Signed-off-by: Mark Brown <broonie@kernel.org>
> 
> > ---
> >  arch/arm64/tools/sysreg | 24 ++++++++++++++++++++++--
> >  1 file changed, 22 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg
> > index c48a3b8d00ad..3f382f8d0f4a 100644
> > --- a/arch/arm64/tools/sysreg
> > +++ b/arch/arm64/tools/sysreg
> > @@ -1365,7 +1365,14 @@ EndEnum
> >  EndSysreg
> >
> >  Sysreg ID_AA64ISAR2_EL1        3       0       0       6       2
> > -Res0   63:56
> > +UnsignedEnum   63:60   ATS1A
> > +       0b0000  NI
> > +       0b0001  IMP
> > +EndEnum
> > +UnsignedEnum   59:56   LUT
> > +       0b0000  NI
> > +       0b0001  IMP
> > +EndEnum
> >  UnsignedEnum   55:52   CSSC
> >         0b0000  NI
> >         0b0001  IMP
> > @@ -1374,7 +1381,19 @@ UnsignedEnum     51:48   RPRFM
> >         0b0000  NI
> >         0b0001  IMP
> >  EndEnum
> > -Res0   47:32
> > +Res0   47:44
> > +UnsignedEnum   43:40   PRFMSLC
> > +       0b0000  NI
> > +       0b0001  IMP
> > +EndEnum
> > +UnsignedEnum   39:36   SYSINSTR_128
> > +       0b0000  NI
> > +       0b0001  IMP
> > +EndEnum
> > +UnsignedEnum   35:32   SYSREG_128
> > +       0b0000  NI
> > +       0b0001  IMP
> > +EndEnum
> >  UnsignedEnum   31:28   CLRBHB
> >         0b0000  NI
> >         0b0001  IMP
> > @@ -1398,6 +1417,7 @@ UnsignedEnum      15:12   APA3
> >         0b0011  PAuth2
> >         0b0100  FPAC
> >         0b0101  FPACCOMBINE
> > +       0b0110  PAUTH_LR
> 
> Nit: PAuth and PAuth2 only have the PA as uppercase in this file,
> which matches the spec. Should PAuth_LR be the same?

I renamed it to PAuth_LR following your comment, but it looks like
ID_AA64ISAR1_EL1 is still missing this field entirely for the API and
APA fields.

Will

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PATCH 06/13] arm64/sysreg: Update ID_AA64ISAR2_EL1 defintion for DDI0601 2023-09
  2023-12-12  9:10     ` Will Deacon
@ 2023-12-12 10:24       ` Fuad Tabba
  2023-12-12 12:56         ` Mark Brown
  0 siblings, 1 reply; 27+ messages in thread
From: Fuad Tabba @ 2023-12-12 10:24 UTC (permalink / raw)
  To: Will Deacon
  Cc: Mark Brown, Catalin Marinas, Joey Gouly, linux-arm-kernel,
	linux-kernel

Thank you Will.

...

> I renamed it to PAuth_LR following your comment, but it looks like
> ID_AA64ISAR1_EL1 is still missing this field entirely for the API and
> APA fields.

I noticed that, but thought it's more appropriate to have a separate
patch for that. I have one ready as part of my respin, unless we
accumulate a bunch of sysreg update patches first.

Cheers,
/fuad

> Will

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PATCH 06/13] arm64/sysreg: Update ID_AA64ISAR2_EL1 defintion for DDI0601 2023-09
  2023-12-12 10:24       ` Fuad Tabba
@ 2023-12-12 12:56         ` Mark Brown
  0 siblings, 0 replies; 27+ messages in thread
From: Mark Brown @ 2023-12-12 12:56 UTC (permalink / raw)
  To: Fuad Tabba
  Cc: Will Deacon, Catalin Marinas, Joey Gouly, linux-arm-kernel,
	linux-kernel


[-- Attachment #1.1: Type: text/plain, Size: 582 bytes --]

On Tue, Dec 12, 2023 at 10:24:46AM +0000, Fuad Tabba wrote:

> > I renamed it to PAuth_LR following your comment, but it looks like
> > ID_AA64ISAR1_EL1 is still missing this field entirely for the API and
> > APA fields.

> I noticed that, but thought it's more appropriate to have a separate
> patch for that. I have one ready as part of my respin, unless we
> accumulate a bunch of sysreg update patches first.

Yes, syncing each register individually should make life easier.  It's
definitely painful when there's a multi-register update and one of the
registers has a mistake.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 27+ messages in thread

end of thread, other threads:[~2023-12-12 12:56 UTC | newest]

Thread overview: 27+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-09  1:02 [PATCH 00/13] arm64/sysreg: System register updates from the 2023-09 XML release broonie
2023-12-09  1:02 ` [PATCH 01/13] arm64/sysreg: Update HFGITR_EL2 definiton to DDI0601 2023-09 broonie
2023-12-09  1:02 ` [PATCH 02/13] arm64/sysreg: Add definition for HAFGRTR_EL2 broonie
2023-12-09  1:02 ` [PATCH 03/13] arm64/sysreg: add system register POR_EL{0,1} broonie
2023-12-09  1:02 ` [PATCH 04/13] arm64/sysreg: update CPACR_EL1 register broonie
2023-12-09  1:02 ` [PATCH 05/13] arm64/sysreg: Add definition for ID_AA64PFR2_EL1 Mark Brown
2023-12-11  8:59   ` Fuad Tabba
2023-12-09  1:02 ` [PATCH 06/13] arm64/sysreg: Update ID_AA64ISAR2_EL1 defintion for DDI0601 2023-09 Mark Brown
2023-12-11  9:07   ` Fuad Tabba
2023-12-12  9:10     ` Will Deacon
2023-12-12 10:24       ` Fuad Tabba
2023-12-12 12:56         ` Mark Brown
2023-12-09  1:02 ` [PATCH 07/13] arm64/sysreg: Add definition for ID_AA64ISAR3_EL1 Mark Brown
2023-12-11  9:14   ` Fuad Tabba
2023-12-09  1:02 ` [PATCH 08/13] arm64/sysreg: Add definition for ID_AA64FPFR0_EL1 Mark Brown
2023-12-11  9:18   ` Fuad Tabba
2023-12-09  1:02 ` [PATCH 09/13] arm64/sysreg: Update ID_AA64SMFR0_EL1 definition for DDI0601 2023-09 Mark Brown
2023-12-11  9:17   ` Fuad Tabba
2023-12-09  1:02 ` [PATCH 10/13] arm64/sysreg: Update SCTLR_EL1 " Mark Brown
2023-12-11  9:19   ` Fuad Tabba
2023-12-09  1:02 ` [PATCH 11/13] arm64/sysreg: Update HCRX_EL2 definition " Mark Brown
2023-12-11  9:26   ` Fuad Tabba
2023-12-09  1:02 ` [PATCH 12/13] arm64/sysreg: Add definition for FPMR Mark Brown
2023-12-11  9:28   ` Fuad Tabba
2023-12-09  1:02 ` [PATCH 13/13] arm64/sysreg: Add new system registers for GCS Mark Brown
2023-12-11  9:38   ` Fuad Tabba
2023-12-11 20:27 ` [PATCH 00/13] arm64/sysreg: System register updates from the 2023-09 XML release Will Deacon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox