Re: [PATCH] firmware: psci: Fix return value from psci_system_suspend()

[Sudeep Holla <sudeep.holla@arm.com>]

Hi Mark/Lorenzo,

On Mon, Nov 13, 2023 at 03:34:46PM +0000, Sudeep Holla wrote:
> Currently we return the value from invoke_psci_fn() directly as return
> value from psci_system_suspend(). It is wrong to send the PSCI interface
> return value directly. psci_to_linux_errno() provide the mapping from
> PSCI return value to the one that can be returned to the callers within
> the kernel.
> 
> Use psci_to_linux_errno() to convert and return the correct value from
> psci_system_suspend().
> 
> Fixes: faf7ec4a92c0 ("drivers: firmware: psci: add system suspend support")
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
>  drivers/firmware/psci/psci.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> Hi,
> 
> For some reason, this has gone unnoticed for years. I bumped into this when
> I was trying to test suspend on FVP which claims to support but returns error
> when called. The error was getting not communicated properly(incorrect
> error code) before this patch.
> 

Gentle ping! I had forgotten about this, if you are happy with the change,
I can ask Arnd to pick it up as fix during v6.8 cycle.

-- 
Regards,
Sudeep

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel