public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
	Lorenzo Pieralisi <lpieralisi@kernel.org>
Subject: Re: [PATCH] firmware: psci: Fix return value from psci_system_suspend()
Date: Mon, 17 Jun 2024 11:40:41 +0100	[thread overview]
Message-ID: <ZnASqVeQP1dj1MnU@J2N7QTR9R3> (raw)
In-Reply-To: <171861861706.3840576.13385886526197301214.b4-ty@arm.com>

On Mon, Jun 17, 2024 at 11:12:55AM +0100, Sudeep Holla wrote:
> On Mon, 13 Nov 2023 15:34:46 +0000, Sudeep Holla wrote:
> > Currently we return the value from invoke_psci_fn() directly as return
> > value from psci_system_suspend(). It is wrong to send the PSCI interface
> > return value directly. psci_to_linux_errno() provide the mapping from
> > PSCI return value to the one that can be returned to the callers within
> > the kernel.
> >
> > Use psci_to_linux_errno() to convert and return the correct value from
> > psci_system_suspend().
> >
> > [...]
> 
> This has slipped through the cracks for long. I plan to take this
> via my FF-A tree as SoC team somehow missed couple of times though I
> cc-ed their email.

That works for me; thanks for picking this up!

Mark.

> 
> Applied to sudeep.holla/linux (for-next/ffa/updates), thanks!
> 
> [1/1] firmware: psci: Fix return value from psci_system_suspend()
>       https://git.kernel.org/sudeep.holla/c/f624c7cbd155ef
> --
> Regards,
> Sudeep
> 


      reply	other threads:[~2024-06-17 10:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-13 15:34 [PATCH] firmware: psci: Fix return value from psci_system_suspend() Sudeep Holla
2024-01-08 19:53 ` Sudeep Holla
2024-01-09  9:48 ` Mark Rutland
2024-06-17 10:12 ` Sudeep Holla
2024-06-17 10:40   ` Mark Rutland [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZnASqVeQP1dj1MnU@J2N7QTR9R3 \
    --to=mark.rutland@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=lpieralisi@kernel.org \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox