Re: [PATCH] arm/arm64: samsung: Enable W=1 on dtbs by default

From: Conor Dooley <conor@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Rob Herring <robh@kernel.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm/arm64: samsung: Enable W=1 on dtbs by default
Date: Thu, 25 Jan 2024 17:51:26 +0000	[thread overview]
Message-ID: <20240125-unsaved-promoter-c0bc72bb4691@spud> (raw)
In-Reply-To: <986db909-144b-465a-8c46-273042a4fe5e@linaro.org>

[-- Attachment #1.1: Type: text/plain, Size: 1623 bytes --]

On Thu, Jan 25, 2024 at 12:31:42PM +0100, Krzysztof Kozlowski wrote:
> On 21/11/2023 15:58, Rob Herring wrote:
> > On Fri, Nov 17, 2023 at 3:19 AM Krzysztof Kozlowski
> > <krzysztof.kozlowski@linaro.org> wrote:
> >>
> >> On 16/11/2023 22:17, Rob Herring wrote:
> >>> Samsung platforms are clean of W=1 dtc warnings, so enable the warnings
> >>> by default. This way submitters don't have to remember to run a W=1
> >>> build of the .dts files and the grumpiness of the maintainers can be
> >>> reduced.
> >>>
> >>> Signed-off-by: Rob Herring <robh@kernel.org>
> >>> ---
> >>> Well, there's a couple of warnings on 32-bit, but they look fixable to
> >>> me.
> >>>
> >>> There's a few other platforms we could do this to. Sadly, they are still
> >>> the minority. Otherwise, we could change the default and add a flag to
> >>> disable (I_STILL_HAVENT_FIXED_MY_PLATFORMS=1).
> >>
> >> 64-bit has still few warnings:
> >> https://krzk.eu/#/builders/29/builds/3710/steps/26/logs/warnings__6_
> > 
> > I may move that graph check to W=2. There's some cases where port@1 is
> > optional and it doesn't really make sense to fix these.
> > 
> > Also, Conor wants to do this for all of riscv, but this solution is
> > per directory. So I need to rework it to use a different variable that
> > can be per directory or global.
> 
> Just to clarify, because I still have this patch in my inbox: I assume
> you are going to send a v2 of this, so I drop it.

We got
https://lore.kernel.org/linux-devicetree/20231122-dtc-warnings-v2-0-bd4087325392@kernel.org/
out of this instead of a v2, did we not?

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel