From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: Alim Akhtar <alim.akhtar@samsung.com>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm/arm64: samsung: Enable W=1 on dtbs by default
Date: Thu, 25 Jan 2024 12:31:42 +0100 [thread overview]
Message-ID: <986db909-144b-465a-8c46-273042a4fe5e@linaro.org> (raw)
In-Reply-To: <CAL_JsqJ67tZOmhTHQ7KqEbFuDjK8sKHR1FFtAFAaGjZ4uYi9Uw@mail.gmail.com>
On 21/11/2023 15:58, Rob Herring wrote:
> On Fri, Nov 17, 2023 at 3:19 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 16/11/2023 22:17, Rob Herring wrote:
>>> Samsung platforms are clean of W=1 dtc warnings, so enable the warnings
>>> by default. This way submitters don't have to remember to run a W=1
>>> build of the .dts files and the grumpiness of the maintainers can be
>>> reduced.
>>>
>>> Signed-off-by: Rob Herring <robh@kernel.org>
>>> ---
>>> Well, there's a couple of warnings on 32-bit, but they look fixable to
>>> me.
>>>
>>> There's a few other platforms we could do this to. Sadly, they are still
>>> the minority. Otherwise, we could change the default and add a flag to
>>> disable (I_STILL_HAVENT_FIXED_MY_PLATFORMS=1).
>>
>> 64-bit has still few warnings:
>> https://krzk.eu/#/builders/29/builds/3710/steps/26/logs/warnings__6_
>
> I may move that graph check to W=2. There's some cases where port@1 is
> optional and it doesn't really make sense to fix these.
>
> Also, Conor wants to do this for all of riscv, but this solution is
> per directory. So I need to rework it to use a different variable that
> can be per directory or global.
Just to clarify, because I still have this patch in my inbox: I assume
you are going to send a v2 of this, so I drop it.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-01-25 13:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-16 21:17 [PATCH] arm/arm64: samsung: Enable W=1 on dtbs by default Rob Herring
2023-11-17 10:19 ` Krzysztof Kozlowski
2023-11-21 14:58 ` Rob Herring
2024-01-25 11:31 ` Krzysztof Kozlowski [this message]
2024-01-25 17:51 ` Conor Dooley
2024-01-26 10:31 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=986db909-144b-465a-8c46-273042a4fe5e@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox