* [PATCH 1/3] ARM: dts: samsung: exynos5420-galaxy-tab-common: sort node properties
2024-01-30 20:40 [PATCH 0/3] ARM: dts: samsung: enable wifi and cleanup exynos5420-galaxy-tab dts'es Henrik Grimler
@ 2024-01-30 20:40 ` Henrik Grimler
2024-01-31 7:19 ` Krzysztof Kozlowski
2024-01-30 20:40 ` [PATCH 2/3] ARM: dts: samsung: exynos5420-galaxy-tab-common: add wifi node Henrik Grimler
2024-01-30 20:40 ` [PATCH 3/3] ARM: dts: samsung: exynos5420-galaxy-tab-common: decrease available memory Henrik Grimler
2 siblings, 1 reply; 9+ messages in thread
From: Henrik Grimler @ 2024-01-30 20:40 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alim Akhtar,
Marek Szyprowski
Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel,
~postmarketos/upstreaming
Sort all node properties according to dts coding style guidelines, to
make dtsi easier to follow.
Signed-off-by: Henrik Grimler <henrik@grimler.se>
---
.../dts/samsung/exynos5420-galaxy-tab-common.dtsi | 23 +++++++++++-----------
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git a/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi b/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi
index f525b2f5e4e0..0c1aeafc025b 100644
--- a/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi
+++ b/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi
@@ -103,8 +103,8 @@ &cpu4 {
};
&gpu {
- status = "okay";
mali-supply = <&buck4_reg>;
+ status = "okay";
};
&hsi2c_7 {
@@ -113,11 +113,10 @@ &hsi2c_7 {
pmic@66 {
compatible = "samsung,s2mps11-pmic";
reg = <0x66>;
-
interrupt-parent = <&gpx3>;
interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
- pinctrl-names = "default";
pinctrl-0 = <&s2mps11_irq>;
+ pinctrl-names = "default";
s2mps11_osc: clocks {
compatible = "samsung,s2mps11-clk";
@@ -605,7 +604,6 @@ &mixer {
/* Internal storage */
&mmc_0 {
- status = "okay";
bus-width = <8>;
cap-mmc-highspeed;
card-detect-delay = <200>;
@@ -614,27 +612,28 @@ &mmc_0 {
non-removable;
pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus1 &sd0_bus4 &sd0_bus8>;
pinctrl-names = "default";
+ vqmmc-supply = <&ldo3_reg>;
samsung,dw-mshc-ciu-div = <3>;
samsung,dw-mshc-ddr-timing = <0 2>;
samsung,dw-mshc-sdr-timing = <0 4>;
- vqmmc-supply = <&ldo3_reg>;
+ status = "okay";
};
/* External sdcard */
&mmc_2 {
- status = "okay";
bus-width = <4>;
cap-sd-highspeed;
card-detect-delay = <200>;
cd-gpios = <&gpx2 4 GPIO_ACTIVE_LOW>;
pinctrl-0 = <&sd2_clk &sd2_cmd &mmc2_cd &sd2_bus1 &sd2_bus4>;
pinctrl-names = "default";
- samsung,dw-mshc-ciu-div = <3>;
- samsung,dw-mshc-ddr-timing = <0 2>;
- samsung,dw-mshc-sdr-timing = <0 4>;
sd-uhs-sdr50;
vmmc-supply = <&ldo19_reg>;
vqmmc-supply = <&ldo13_reg>;
+ samsung,dw-mshc-ciu-div = <3>;
+ samsung,dw-mshc-ddr-timing = <0 2>;
+ samsung,dw-mshc-sdr-timing = <0 4>;
+ status = "okay";
};
&pinctrl_0 {
@@ -652,9 +651,9 @@ s2mps11_irq: s2mps11-irq-pins {
};
&rtc {
- status = "okay";
clocks = <&clock CLK_RTC>, <&s2mps11_osc S2MPS11_CLK_AP>;
clock-names = "rtc", "rtc_src";
+ status = "okay";
};
&tmu_cpu0 {
@@ -686,11 +685,11 @@ &usbdrd_dwc3_1 {
};
&usbdrd3_0 {
- vdd33-supply = <&ldo9_reg>;
vdd10-supply = <&ldo11_reg>;
+ vdd33-supply = <&ldo9_reg>;
};
&usbdrd3_1 {
- vdd33-supply = <&ldo9_reg>;
vdd10-supply = <&ldo11_reg>;
+ vdd33-supply = <&ldo9_reg>;
};
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 1/3] ARM: dts: samsung: exynos5420-galaxy-tab-common: sort node properties
2024-01-30 20:40 ` [PATCH 1/3] ARM: dts: samsung: exynos5420-galaxy-tab-common: sort node properties Henrik Grimler
@ 2024-01-31 7:19 ` Krzysztof Kozlowski
2024-01-31 8:25 ` Henrik Grimler
0 siblings, 1 reply; 9+ messages in thread
From: Krzysztof Kozlowski @ 2024-01-31 7:19 UTC (permalink / raw)
To: Henrik Grimler, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Alim Akhtar, Marek Szyprowski
Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel,
~postmarketos/upstreaming
On 30/01/2024 21:40, Henrik Grimler wrote:
> Sort all node properties according to dts coding style guidelines, to
> make dtsi easier to follow.
>
> Signed-off-by: Henrik Grimler <henrik@grimler.se>
> ---
> .../dts/samsung/exynos5420-galaxy-tab-common.dtsi | 23 +++++++++++-----------
> 1 file changed, 11 insertions(+), 12 deletions(-)
>
> diff --git a/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi b/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi
> index f525b2f5e4e0..0c1aeafc025b 100644
> --- a/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi
> +++ b/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi
> @@ -103,8 +103,8 @@ &cpu4 {
> };
>
> &gpu {
> - status = "okay";
> mali-supply = <&buck4_reg>;
> + status = "okay";
Such changes should come from a tool, but since we do not have them, I
don't want to bother with properties re-shuffling.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 1/3] ARM: dts: samsung: exynos5420-galaxy-tab-common: sort node properties
2024-01-31 7:19 ` Krzysztof Kozlowski
@ 2024-01-31 8:25 ` Henrik Grimler
2024-01-31 8:32 ` Krzysztof Kozlowski
0 siblings, 1 reply; 9+ messages in thread
From: Henrik Grimler @ 2024-01-31 8:25 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alim Akhtar,
Marek Szyprowski, devicetree, linux-arm-kernel, linux-samsung-soc,
linux-kernel, ~postmarketos/upstreaming
Hi Krzysztof,
On Wed, Jan 31, 2024 at 08:19:39AM +0100, Krzysztof Kozlowski wrote:
> On 30/01/2024 21:40, Henrik Grimler wrote:
> > Sort all node properties according to dts coding style guidelines, to
> > make dtsi easier to follow.
> >
> > Signed-off-by: Henrik Grimler <henrik@grimler.se>
> > ---
> > .../dts/samsung/exynos5420-galaxy-tab-common.dtsi | 23 +++++++++++-----------
> > 1 file changed, 11 insertions(+), 12 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi b/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi
> > index f525b2f5e4e0..0c1aeafc025b 100644
> > --- a/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi
> > +++ b/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi
> > @@ -103,8 +103,8 @@ &cpu4 {
> > };
> >
> > &gpu {
> > - status = "okay";
> > mali-supply = <&buck4_reg>;
> > + status = "okay";
>
> Such changes should come from a tool, but since we do not have them, I
> don't want to bother with properties re-shuffling.
Noted, thanks. I will drop this patch and send a v2 in a few hours.
> Best regards,
> Krzysztof
Best regards
Henrik Grimler
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 1/3] ARM: dts: samsung: exynos5420-galaxy-tab-common: sort node properties
2024-01-31 8:25 ` Henrik Grimler
@ 2024-01-31 8:32 ` Krzysztof Kozlowski
0 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2024-01-31 8:32 UTC (permalink / raw)
To: Henrik Grimler
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alim Akhtar,
Marek Szyprowski, devicetree, linux-arm-kernel, linux-samsung-soc,
linux-kernel, ~postmarketos/upstreaming
On 31/01/2024 09:25, Henrik Grimler wrote:
> Hi Krzysztof,
>
> On Wed, Jan 31, 2024 at 08:19:39AM +0100, Krzysztof Kozlowski wrote:
>> On 30/01/2024 21:40, Henrik Grimler wrote:
>>> Sort all node properties according to dts coding style guidelines, to
>>> make dtsi easier to follow.
>>>
>>> Signed-off-by: Henrik Grimler <henrik@grimler.se>
>>> ---
>>> .../dts/samsung/exynos5420-galaxy-tab-common.dtsi | 23 +++++++++++-----------
>>> 1 file changed, 11 insertions(+), 12 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi b/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi
>>> index f525b2f5e4e0..0c1aeafc025b 100644
>>> --- a/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi
>>> +++ b/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi
>>> @@ -103,8 +103,8 @@ &cpu4 {
>>> };
>>>
>>> &gpu {
>>> - status = "okay";
>>> mali-supply = <&buck4_reg>;
>>> + status = "okay";
>>
>> Such changes should come from a tool, but since we do not have them, I
>> don't want to bother with properties re-shuffling.
>
> Noted, thanks. I will drop this patch and send a v2 in a few hours.
No need for v2, unless some other comments pop up. I will just apply #2
and #3 from this set.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 2/3] ARM: dts: samsung: exynos5420-galaxy-tab-common: add wifi node
2024-01-30 20:40 [PATCH 0/3] ARM: dts: samsung: enable wifi and cleanup exynos5420-galaxy-tab dts'es Henrik Grimler
2024-01-30 20:40 ` [PATCH 1/3] ARM: dts: samsung: exynos5420-galaxy-tab-common: sort node properties Henrik Grimler
@ 2024-01-30 20:40 ` Henrik Grimler
2024-02-06 10:16 ` Krzysztof Kozlowski
2024-01-30 20:40 ` [PATCH 3/3] ARM: dts: samsung: exynos5420-galaxy-tab-common: decrease available memory Henrik Grimler
2 siblings, 1 reply; 9+ messages in thread
From: Henrik Grimler @ 2024-01-30 20:40 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alim Akhtar,
Marek Szyprowski
Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel,
~postmarketos/upstreaming
By using brcm/brcmfmac4354-sdio.bin from linux-firmware together with
nvram.txt from vendor firmware wifi works well on the chagall-wifi and
klimt-lte.
Signed-off-by: Henrik Grimler <henrik@grimler.se>
---
.../dts/samsung/exynos5420-galaxy-tab-common.dtsi | 32 ++++++++++++++++++++++
1 file changed, 32 insertions(+)
diff --git a/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi b/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi
index 0c1aeafc025b..d569fac29b18 100644
--- a/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi
+++ b/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi
@@ -30,6 +30,7 @@ / {
aliases {
mmc0 = &mmc_0;
+ mmc1 = &mmc_1;
mmc2 = &mmc_2;
};
@@ -87,6 +88,13 @@ key-volume-down {
linux,code = <KEY_VOLUMEDOWN>;
};
};
+
+ mmc1_pwrseq: pwrseq {
+ compatible = "mmc-pwrseq-simple";
+ reset-gpios = <&gpy7 7 GPIO_ACTIVE_LOW>;
+ clocks = <&s2mps11_osc S2MPS11_CLK_BT>;
+ clock-names = "ext_clock";
+ };
};
&cci {
@@ -619,6 +627,25 @@ &mmc_0 {
status = "okay";
};
+/* WiFi */
+&mmc_1 {
+ bus-width = <4>;
+ cap-sd-highspeed;
+ cap-sdio-irq;
+ card-detect-delay = <200>;
+ keep-power-in-suspend;
+ mmc-pwrseq = <&mmc1_pwrseq>;
+ non-removable;
+ pinctrl-0 = <&sd1_clk>, <&sd1_cmd>, <&sd1_int>, <&sd1_bus1>,
+ <&sd1_bus4>, <&wifi_en>;
+ pinctrl-names = "default";
+ vqmmc-supply = <&ldo2_reg>;
+ samsung,dw-mshc-ciu-div = <1>;
+ samsung,dw-mshc-ddr-timing = <0 2>;
+ samsung,dw-mshc-sdr-timing = <0 1>;
+ status = "okay";
+};
+
/* External sdcard */
&mmc_2 {
bus-width = <4>;
@@ -648,6 +675,11 @@ s2mps11_irq: s2mps11-irq-pins {
samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV1>;
};
+
+ wifi_en: wifi-en-pins {
+ samsung,pins = "gpy7-7";
+ samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+ };
};
&rtc {
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 2/3] ARM: dts: samsung: exynos5420-galaxy-tab-common: add wifi node
2024-01-30 20:40 ` [PATCH 2/3] ARM: dts: samsung: exynos5420-galaxy-tab-common: add wifi node Henrik Grimler
@ 2024-02-06 10:16 ` Krzysztof Kozlowski
0 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2024-02-06 10:16 UTC (permalink / raw)
To: Henrik Grimler, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Alim Akhtar, Marek Szyprowski
Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel,
~postmarketos/upstreaming
On 30/01/2024 21:40, Henrik Grimler wrote:
> By using brcm/brcmfmac4354-sdio.bin from linux-firmware together with
> nvram.txt from vendor firmware wifi works well on the chagall-wifi and
> klimt-lte.
>
> Signed-off-by: Henrik Grimler <henrik@grimler.se>
> ---
> .../dts/samsung/exynos5420-galaxy-tab-common.dtsi | 32 ++++++++++++++++++++++
> 1 file changed, 32 insertions(+)
This does not apply, maybe because I skipped patch #1. Please resend.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 3/3] ARM: dts: samsung: exynos5420-galaxy-tab-common: decrease available memory
2024-01-30 20:40 [PATCH 0/3] ARM: dts: samsung: enable wifi and cleanup exynos5420-galaxy-tab dts'es Henrik Grimler
2024-01-30 20:40 ` [PATCH 1/3] ARM: dts: samsung: exynos5420-galaxy-tab-common: sort node properties Henrik Grimler
2024-01-30 20:40 ` [PATCH 2/3] ARM: dts: samsung: exynos5420-galaxy-tab-common: add wifi node Henrik Grimler
@ 2024-01-30 20:40 ` Henrik Grimler
2024-02-06 10:17 ` (subset) " Krzysztof Kozlowski
2 siblings, 1 reply; 9+ messages in thread
From: Henrik Grimler @ 2024-01-30 20:40 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alim Akhtar,
Marek Szyprowski
Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel,
~postmarketos/upstreaming
The last 6 MiB are used by trustzone firmware, and cannot be used by
Linux. Currently we are saved by that the proprietary bootloader
(sboot) passes available memory to kernel through ATAG_MEM. Change
memory range in any case so that we do not have to rely on ATAG_MEM.
Signed-off-by: Henrik Grimler <henrik@grimler.se>
---
Similar fix was applied for the exynos5422 odroids in commit
6591a02e17e6 ("ARM: dts: reduce total RAM by 22 MiB for
exynos5422-odroidxu3"):
https://lore.kernel.org/all/1421842972-25807-1-git-send-email-m.szyprowski@samsung.com/
---
arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi b/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi
index d569fac29b18..ac929e282c84 100644
--- a/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi
+++ b/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi
@@ -40,7 +40,7 @@ chosen {
memory@20000000 {
device_type = "memory";
- reg = <0x20000000 0xc0000000>;
+ reg = <0x20000000 0xbfa00000>;
};
firmware@2073000 {
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: (subset) [PATCH 3/3] ARM: dts: samsung: exynos5420-galaxy-tab-common: decrease available memory
2024-01-30 20:40 ` [PATCH 3/3] ARM: dts: samsung: exynos5420-galaxy-tab-common: decrease available memory Henrik Grimler
@ 2024-02-06 10:17 ` Krzysztof Kozlowski
0 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2024-02-06 10:17 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alim Akhtar,
Marek Szyprowski, Henrik Grimler
Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel,
~postmarketos/upstreaming
On Tue, 30 Jan 2024 21:40:41 +0100, Henrik Grimler wrote:
> The last 6 MiB are used by trustzone firmware, and cannot be used by
> Linux. Currently we are saved by that the proprietary bootloader
> (sboot) passes available memory to kernel through ATAG_MEM. Change
> memory range in any case so that we do not have to rely on ATAG_MEM.
>
>
Applied, thanks!
[3/3] ARM: dts: samsung: exynos5420-galaxy-tab-common: decrease available memory
https://git.kernel.org/krzk/linux/c/9a5dbb835fd396c78da34b26ee91db6d529d096d
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread