* [PATCH] arm: s3c64xx: make s3c64xx_subsys const
@ 2024-02-04 14:46 Ricardo B. Marliere
2024-02-04 14:52 ` Greg Kroah-Hartman
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Ricardo B. Marliere @ 2024-02-04 14:46 UTC (permalink / raw)
To: Russell King, Krzysztof Kozlowski, Alim Akhtar
Cc: linux-arm-kernel, linux-samsung-soc, linux-kernel,
Greg Kroah-Hartman, Ricardo B. Marliere
Now that the driver core can properly handle constant struct bus_type,
move the s3c64xx_subsys variable to be a constant structure as well,
placing it into read-only memory which can not be modified at runtime.
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
---
arch/arm/mach-s3c/s3c64xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-s3c/s3c64xx.c b/arch/arm/mach-s3c/s3c64xx.c
index 9f9717874d67..6c70ea7f2931 100644
--- a/arch/arm/mach-s3c/s3c64xx.c
+++ b/arch/arm/mach-s3c/s3c64xx.c
@@ -149,7 +149,7 @@ static struct map_desc s3c_iodesc[] __initdata = {
},
};
-static struct bus_type s3c64xx_subsys = {
+static const struct bus_type s3c64xx_subsys = {
.name = "s3c64xx-core",
.dev_name = "s3c64xx-core",
};
---
base-commit: 8f5b7dbc644d6217a2fd35cb82594b215818eb16
change-id: 20240204-bus_cleanup-arm-391704e66efc
Best regards,
--
Ricardo B. Marliere <ricardo@marliere.net>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] arm: s3c64xx: make s3c64xx_subsys const
2024-02-04 14:46 [PATCH] arm: s3c64xx: make s3c64xx_subsys const Ricardo B. Marliere
@ 2024-02-04 14:52 ` Greg Kroah-Hartman
2024-02-05 7:35 ` Krzysztof Kozlowski
2024-02-05 12:32 ` Krzysztof Kozlowski
2 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2024-02-04 14:52 UTC (permalink / raw)
To: Ricardo B. Marliere
Cc: Russell King, Krzysztof Kozlowski, Alim Akhtar, linux-arm-kernel,
linux-samsung-soc, linux-kernel
On Sun, Feb 04, 2024 at 11:46:21AM -0300, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the s3c64xx_subsys variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
> ---
> arch/arm/mach-s3c/s3c64xx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm: s3c64xx: make s3c64xx_subsys const
2024-02-04 14:46 [PATCH] arm: s3c64xx: make s3c64xx_subsys const Ricardo B. Marliere
2024-02-04 14:52 ` Greg Kroah-Hartman
@ 2024-02-05 7:35 ` Krzysztof Kozlowski
2024-02-05 12:32 ` Krzysztof Kozlowski
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2024-02-05 7:35 UTC (permalink / raw)
To: Ricardo B. Marliere, Russell King, Alim Akhtar
Cc: linux-arm-kernel, linux-samsung-soc, linux-kernel,
Greg Kroah-Hartman
On 04/02/2024 15:46, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
Is there any dependency?
> move the s3c64xx_subsys variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm: s3c64xx: make s3c64xx_subsys const
2024-02-04 14:46 [PATCH] arm: s3c64xx: make s3c64xx_subsys const Ricardo B. Marliere
2024-02-04 14:52 ` Greg Kroah-Hartman
2024-02-05 7:35 ` Krzysztof Kozlowski
@ 2024-02-05 12:32 ` Krzysztof Kozlowski
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2024-02-05 12:32 UTC (permalink / raw)
To: Russell King, Alim Akhtar, Ricardo B. Marliere
Cc: linux-arm-kernel, linux-samsung-soc, linux-kernel,
Greg Kroah-Hartman
On Sun, 04 Feb 2024 11:46:21 -0300, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the s3c64xx_subsys variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
>
Applied, thanks!
[1/1] arm: s3c64xx: make s3c64xx_subsys const
https://git.kernel.org/krzk/linux/c/db085a6c66337799ad5983c5c6d4b1d8386f4256
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-02-05 12:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-04 14:46 [PATCH] arm: s3c64xx: make s3c64xx_subsys const Ricardo B. Marliere
2024-02-04 14:52 ` Greg Kroah-Hartman
2024-02-05 7:35 ` Krzysztof Kozlowski
2024-02-05 12:32 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox