public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Michal Simek <michal.simek@amd.com>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Lorenzo Bianconi <lorenzo@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH 0/4] Drop casting to void in dev_set_drvdata
Date: Sat, 9 Mar 2024 18:33:42 +0000	[thread overview]
Message-ID: <20240309183342.578161e7@jic23-huawei> (raw)
In-Reply-To: <20240303-void_in_dev_set_drvdata-v1-0-ae39027d740b@gmail.com>

On Sun, 03 Mar 2024 23:34:38 +0100
Javier Carrasco <javier.carrasco.cruz@gmail.com> wrote:

> The C standard specifies that there is no need to cast from a pointer to
> void [1].
> 
> The vast majority of the users of dev_set_drvdata do not cast their
> pointers to void, and the few that do so should be fixed before it
> spreads by following bad examples (which I was about to do here [2]).
> 
> The very specific cases where the cast avoids warnings (e.g. droping
> const) have been kept as they are.
> 
> [1] C Standard Committee: https://c0x.shape-of-code.com/6.3.2.3.html
> [2] https://lore.kernel.org/linux-iio/20240226-hdc3020-pm-v2-0-cec6766086e8@gmail.com/T/#t
> 
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
> ---
> Javier Carrasco (4):
>       char: xilinx_hwicap: drop casting to void in dev_set_drvdata
>       io: light: st_uvis25: drop casting to void in dev_set_drvdata
>       iio: humidity: hts211: drop casting to void in dev_set_drvdata
>       iio: imu: st_lsm6dsx: drop casting to void in dev_set_drvdata
> 
>  drivers/char/xilinx_hwicap/xilinx_hwicap.c   | 2 +-
>  drivers/iio/humidity/hts221_core.c           | 2 +-
>  drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 2 +-
>  drivers/iio/light/st_uvis25_core.c           | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
> ---
> base-commit: 90d35da658da8cff0d4ecbb5113f5fac9d00eb72
> change-id: 20240303-void_in_dev_set_drvdata-2d8cae908e49
> 
> Best regards,

Thanks for tidying these up.

Applied to the togreg-normal branch of iio.git.
This will get rebase on rc1 once available and become togreg.

Jonathan

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

      parent reply	other threads:[~2024-03-09 18:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-03 22:34 [PATCH 0/4] Drop casting to void in dev_set_drvdata Javier Carrasco
2024-03-03 22:34 ` [PATCH 1/4] char: xilinx_hwicap: drop " Javier Carrasco
2024-03-03 22:34 ` [PATCH 2/4] io: light: st_uvis25: " Javier Carrasco
2024-03-03 22:34 ` [PATCH 3/4] iio: humidity: hts211: " Javier Carrasco
2024-03-03 22:34 ` [PATCH 4/4] iio: imu: st_lsm6dsx: " Javier Carrasco
2024-03-09 18:33 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240309183342.578161e7@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=javier.carrasco.cruz@gmail.com \
    --cc=lars@metafoo.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lorenzo@kernel.org \
    --cc=michal.simek@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox