From: Francesco Dolcini <francesco@dolcini.it>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: Abel Vesa <abelvesa@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>, Jacky Bai <ping.bai@nxp.com>,
Ye Li <ye.li@nxp.com>, Dong Aisheng <aisheng.dong@nxp.com>,
linux-clk@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Abel Vesa <abel.vesa@linaro.org>,
Peng Fan <peng.fan@nxp.com>,
Florin Pavelescu <florin.pavelescu@nxp.com>,
Viorel Suman <viorel.suman@nxp.com>
Subject: Re: [PATCH 07/18] clk: imx: pll14xx: potential integer overflow eliminated by casting to u64
Date: Sat, 4 May 2024 13:58:28 +0200 [thread overview]
Message-ID: <20240504115828.GA3666@francesco-nb> (raw)
In-Reply-To: <20240504-imx-clk-v1-7-f7915489d58d@nxp.com>
Hello Peng,
On Sat, May 04, 2024 at 08:49:00AM +0800, Peng Fan (OSS) wrote:
> From: Florin Pavelescu <florin.pavelescu@nxp.com>
>
> Cast to u64, so that multiplications and additions will be done
> in 64-bit arithmetic (and the results will also be 64-bit)
> and the possibility of integer overflow is eliminated.
>
> Fix Unintentional integer overflow reported by Coverity
Fixes tag if this is a fix?
It would be interesting in general if this can be trigger in real life
and with which side effects or if we are just silencing the tool
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-05-04 11:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-04 0:48 [PATCH 00/18] clk: imx: misc update/fix Peng Fan (OSS)
2024-05-04 0:48 ` [PATCH 01/18] clk: imx: composite-8m: Enable gate clk with mcore_booted Peng Fan (OSS)
2024-05-04 0:48 ` [PATCH 02/18] clk: imx: composite-93: keep root clock on when mcore enabled Peng Fan (OSS)
2024-05-04 0:48 ` [PATCH 03/18] clk: imx: composite-7ulp: Check the PCC present bit Peng Fan (OSS)
2024-05-04 0:48 ` [PATCH 04/18] clk: imx: fracn-gppll: fix fractional part of PLL getting lost Peng Fan (OSS)
2024-05-04 0:48 ` [PATCH 05/18] clk: imx: pll14xx: Add constraint for fvco frequency Peng Fan (OSS)
2024-05-04 0:48 ` [PATCH 06/18] clk: imx: pll14xx: use rate_table for audio plls Peng Fan (OSS)
2024-05-16 12:18 ` Adam Ford
2024-05-04 0:49 ` [PATCH 07/18] clk: imx: pll14xx: potential integer overflow eliminated by casting to u64 Peng Fan (OSS)
2024-05-04 11:58 ` Francesco Dolcini [this message]
2024-05-04 13:13 ` Peng Fan
2024-05-04 0:49 ` [PATCH 08/18] clk: imx: imx8mp-audiomix: remove sdma root clock Peng Fan (OSS)
2024-05-04 11:59 ` Francesco Dolcini
2024-05-04 13:15 ` Peng Fan
2024-05-04 0:49 ` [PATCH 09/18] clk: imx: imx8mp: fix clock tree update of TF-A managed clocks Peng Fan (OSS)
2024-05-04 0:49 ` [PATCH 10/18] clk: imx: Remove CLK_SET_PARENT_GATE for DRAM mux for i.MX7D Peng Fan (OSS)
2024-05-04 12:01 ` Francesco Dolcini
2024-05-04 13:15 ` Peng Fan
2024-05-04 0:49 ` [PATCH 11/18] clk: imx: add CLK_SET_RATE_PARENT for lcdif_pixel_src " Peng Fan (OSS)
2024-05-04 0:49 ` [PATCH 12/18] clk: imx: imx8mn: add sai7_ipg_clk clock settings Peng Fan (OSS)
2024-05-04 0:49 ` [PATCH 13/18] clk: imx: imx8mm: Change the 'nand_usdhc_bus' clock to non-critical one Peng Fan (OSS)
2024-05-04 0:49 ` [PATCH 14/18] clk: imx: imx8qxp: Add LVDS bypass clocks Peng Fan (OSS)
2024-05-04 0:49 ` [PATCH 15/18] clk: imx: imx8qxp: Add clock muxes for MIPI and PHY ref clocks Peng Fan (OSS)
2024-05-04 0:49 ` [PATCH 16/18] clk: imx: imx8qxp: Register dc0_bypass0_clk before disp clk Peng Fan (OSS)
2024-05-04 0:49 ` [PATCH 17/18] clk: imx: imx8qxp: Parent should be initialized earlier than the clock Peng Fan (OSS)
2024-05-04 0:49 ` [PATCH 18/18] clk: imx: fracn-gppll: update rate table Peng Fan (OSS)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240504115828.GA3666@francesco-nb \
--to=francesco@dolcini.it \
--cc=abel.vesa@linaro.org \
--cc=abelvesa@kernel.org \
--cc=aisheng.dong@nxp.com \
--cc=festevam@gmail.com \
--cc=florin.pavelescu@nxp.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
--cc=ping.bai@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=viorel.suman@nxp.com \
--cc=ye.li@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox