From: Bjorn Helgaas <helgaas@kernel.org>
To: Siddharth Vadapalli <s-vadapalli@ti.com>
Cc: lpieralisi@kernel.org, kw@linux.com, robh@kernel.org,
bhelgaas@google.com, manivannan.sadhasivam@linaro.org,
fancer.lancer@gmail.com, u.kleine-koenig@pengutronix.de,
cassel@kernel.org, dlemoal@kernel.org,
yoshihiro.shimoda.uh@renesas.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, srk@ti.com
Subject: Re: [PATCH v7 2/2] PCI: keystone: Fix pci_ops for AM654x SoC
Date: Wed, 15 May 2024 14:26:14 -0500 [thread overview]
Message-ID: <20240515192614.GA2133406@bhelgaas> (raw)
In-Reply-To: <20240514211452.GA2082543@bhelgaas>
On Tue, May 14, 2024 at 04:14:54PM -0500, Bjorn Helgaas wrote:
> On Tue, May 14, 2024 at 05:41:48PM +0530, Siddharth Vadapalli wrote:
> > On Mon, May 13, 2024 at 04:53:50PM -0500, Bjorn Helgaas wrote:
> ...
> > > I'm not quite clear on the mechanism, but it would be helpful to at
> > > least know what's wrong and on what platform. E.g., currently v4.90
> > > suffers Completion Timeouts and 45 second boot delays? And this patch
> > > fixes that?
> >
> > Yes, the Completion Timeouts cause the 45 second boot delays and this
> > patch fixes that.
>
> And this problem happens on AM654x/v4.90a, right? I really want the
> commit log to say what platform is affected!
>
> Maybe something like this?
>
> PCI: keystone: Enable BAR 0 only for v3.65a
>
> The BAR 0 initialization done by ks_pcie_v3_65_add_bus() should
> happen for v3.65a devices only. On other devices, BAR 0 should be
> left disabled, as it is by dw_pcie_setup_rc().
>
> After 6ab15b5e7057 ("PCI: dwc: keystone: Convert .scan_bus()
> callback to use add_bus"), ks_pcie_v3_65_add_bus() enabled BAR 0 for
> both v3.65a and v4.90a devices. On the AM654x SoC, which uses
> v4.90a, enabling BAR 0 causes Completion Timeouts when setting up
> MSI-X. These timeouts delay boot of the AM654x by about 45 seconds.
>
> Move the BAR 0 initialization to ks_pcie_msi_host_init(), which is
> only used for v3.65a devices, and remove ks_pcie_v3_65_add_bus().
I haven't heard anything so I amended it to the above. But please
correct me if it's wrong.
Bjorn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-05-15 19:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 8:50 [PATCH v7 0/2] PCI: keystone: Fix pci_ops for AM654x SoC Siddharth Vadapalli
2024-03-28 8:50 ` [PATCH v7 1/2] PCI: keystone: Relocate ks_pcie_set/clear_dbi_mode() Siddharth Vadapalli
2024-03-28 8:50 ` [PATCH v7 2/2] PCI: keystone: Fix pci_ops for AM654x SoC Siddharth Vadapalli
2024-05-13 21:53 ` Bjorn Helgaas
2024-05-14 12:11 ` Siddharth Vadapalli
2024-05-14 21:14 ` Bjorn Helgaas
2024-05-15 19:26 ` Bjorn Helgaas [this message]
2024-05-16 5:37 ` Siddharth Vadapalli
2024-05-16 14:17 ` Bjorn Helgaas
2024-05-17 11:28 ` [PATCH v7 0/2] " Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240515192614.GA2133406@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
--cc=s-vadapalli@ti.com \
--cc=srk@ti.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox