From: Will Deacon <will@kernel.org>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Marc Zyngier <maz@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Johannes Nixdorf <mixi@shadowice.org>,
Mark Brown <broonie@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [BUG] dm-crypt broken after 2632e2521769 ("arm64: fpsimd: Implement lazy restore for kernel mode FPSIMD")
Date: Fri, 17 May 2024 12:37:39 +0100 [thread overview]
Message-ID: <20240517113738.GA32506@willie-the-truck> (raw)
In-Reply-To: <CAMj1kXELpd2aeDdywdNWvUu+guR2AR=Fwbgo6mpJxFht0Qyeuw@mail.gmail.com>
On Thu, May 16, 2024 at 07:17:00PM +0200, Ard Biesheuvel wrote:
> On Thu, 16 May 2024 at 18:25, Marc Zyngier <maz@kernel.org> wrote:
> >
> > + Ard, Broonie
> >
>
> Ugh.
>
> This is going to be tricky to track down if it takes 10G of data to reproduce.
>
> For the time being, maybe we should just revert and take the time to
> really dig into this?
>
> It appears to revert cleanly, and the performance gain of the
> optimization was never quantified in the first place, so perhaps we
> should get some numbers too when we bring it back.
Given that 6.8 is affected too, I'll queue up the revert with a cc stable
now.
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-05-17 11:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-16 16:22 [BUG] dm-crypt broken after 2632e2521769 ("arm64: fpsimd: Implement lazy restore for kernel mode FPSIMD") Johannes Nixdorf
2024-05-16 16:25 ` Marc Zyngier
2024-05-16 17:16 ` Dave Martin
2024-05-16 17:17 ` Ard Biesheuvel
2024-05-17 11:37 ` Will Deacon [this message]
2024-05-17 11:40 ` Mark Brown
2024-05-17 11:57 ` Mark Rutland
2024-05-16 17:34 ` Johannes Nixdorf
2024-05-21 6:22 ` Johannes Nixdorf
2024-05-21 8:55 ` Ard Biesheuvel
2024-05-21 12:56 ` Mark Brown
2024-05-21 18:34 ` Will Deacon
2024-05-21 18:44 ` Mark Brown
2024-05-21 18:57 ` Ard Biesheuvel
2024-05-21 20:06 ` Janne Grunau
2024-05-21 20:21 ` Mark Brown
2024-05-21 21:23 ` Janne Grunau
2024-05-22 11:14 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240517113738.GA32506@willie-the-truck \
--to=will@kernel.org \
--cc=ardb@kernel.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=mixi@shadowice.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox