From: Will Deacon <will@kernel.org>
To: Johannes Nixdorf <mixi@shadowice.org>
Cc: Marc Zyngier <maz@kernel.org>, Ard Biesheuvel <ardb@kernel.org>,
Mark Brown <broonie@kernel.org>,
linux-arm-kernel@lists.infradead.org, Janne Grunau <j@jannau.net>
Subject: Re: [BUG] dm-crypt broken after 2632e2521769 ("arm64: fpsimd: Implement lazy restore for kernel mode FPSIMD")
Date: Tue, 21 May 2024 19:34:45 +0100 [thread overview]
Message-ID: <20240521183445.GA7154@willie-the-truck> (raw)
In-Reply-To: <Zkw9kK0sXIgfqd01@shadowice>
Hi Johannes,
On Tue, May 21, 2024 at 08:22:08AM +0200, Johannes Nixdorf wrote:
> Bad news: I hit the bug again with 2632e2521769 ("arm64: fpsimd: Implement
> lazy restore for kernel mode FPSIMD") reverted during prolonged interactive
> usage with the downstream Asahi Linux kernel.
Damn, but thanks for the update. I have to ask, but are you absolutely
sure this was with 2632e2521769 reverted? If you're able to double-check
that, it would be great, since we're having trouble reproducing the
issue.
> This prompted me to adjust the reproducer to be closer to the desktop use
> case, which then also found aefbab8e77eb ("arm64: fpsimd: Preserve/restore
> kernel mode NEON at context switch"). With the vanilla kernel before the
> commit or that commit reverted on the Asahi Linux kernel the new reproducer
> also sees no bug, and interactive usage seems fine.
I've already reverted 2632e2521769 ("arm64: fpsimd: Implement lazy
restore for kernel mode FPSIMD"), so it sounds like I should revert
aefbab8e77eb ("arm64: fpsimd: Preserve/restore kernel mode NEON at
context switch") as well while we work to reproduce the issue.
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-05-21 18:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-16 16:22 [BUG] dm-crypt broken after 2632e2521769 ("arm64: fpsimd: Implement lazy restore for kernel mode FPSIMD") Johannes Nixdorf
2024-05-16 16:25 ` Marc Zyngier
2024-05-16 17:16 ` Dave Martin
2024-05-16 17:17 ` Ard Biesheuvel
2024-05-17 11:37 ` Will Deacon
2024-05-17 11:40 ` Mark Brown
2024-05-17 11:57 ` Mark Rutland
2024-05-16 17:34 ` Johannes Nixdorf
2024-05-21 6:22 ` Johannes Nixdorf
2024-05-21 8:55 ` Ard Biesheuvel
2024-05-21 12:56 ` Mark Brown
2024-05-21 18:34 ` Will Deacon [this message]
2024-05-21 18:44 ` Mark Brown
2024-05-21 18:57 ` Ard Biesheuvel
2024-05-21 20:06 ` Janne Grunau
2024-05-21 20:21 ` Mark Brown
2024-05-21 21:23 ` Janne Grunau
2024-05-22 11:14 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240521183445.GA7154@willie-the-truck \
--to=will@kernel.org \
--cc=ardb@kernel.org \
--cc=broonie@kernel.org \
--cc=j@jannau.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maz@kernel.org \
--cc=mixi@shadowice.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox