* [PATCH 1/2] PCI: dra7xx: Fix cpu_addr_fixup parameter name
@ 2024-04-30 7:10 Niklas Cassel
2024-05-17 17:11 ` Krzysztof Wilczyński
0 siblings, 1 reply; 2+ messages in thread
From: Niklas Cassel @ 2024-04-30 7:10 UTC (permalink / raw)
To: Vignesh Raghavendra, Siddharth Vadapalli, Lorenzo Pieralisi,
Krzysztof Wilczyński, Rob Herring, Bjorn Helgaas
Cc: Niklas Cassel, linux-omap, linux-pci, linux-arm-kernel
The function pointer declaration for the cpu_addr_fixup() callback uses
"cpu_addr" as parameter name.
Likewise, the argument that is supplied to the function pointer when the
function is actually called is "cpu_addr".
Rename the cpu_addr_fixup parameter name to match reality.
Signed-off-by: Niklas Cassel <cassel@kernel.org>
---
drivers/pci/controller/dwc/pci-dra7xx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controller/dwc/pci-dra7xx.c
index d2d17d37d3e0..2b818346bb37 100644
--- a/drivers/pci/controller/dwc/pci-dra7xx.c
+++ b/drivers/pci/controller/dwc/pci-dra7xx.c
@@ -113,9 +113,9 @@ static inline void dra7xx_pcie_writel(struct dra7xx_pcie *pcie, u32 offset,
writel(value, pcie->base + offset);
}
-static u64 dra7xx_pcie_cpu_addr_fixup(struct dw_pcie *pci, u64 pci_addr)
+static u64 dra7xx_pcie_cpu_addr_fixup(struct dw_pcie *pci, u64 cpu_addr)
{
- return pci_addr & DRA7XX_CPU_TO_BUS_ADDR;
+ return cpu_addr & DRA7XX_CPU_TO_BUS_ADDR;
}
static int dra7xx_pcie_link_up(struct dw_pcie *pci)
--
2.44.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 1/2] PCI: dra7xx: Fix cpu_addr_fixup parameter name
2024-04-30 7:10 [PATCH 1/2] PCI: dra7xx: Fix cpu_addr_fixup parameter name Niklas Cassel
@ 2024-05-17 17:11 ` Krzysztof Wilczyński
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Wilczyński @ 2024-05-17 17:11 UTC (permalink / raw)
To: Niklas Cassel
Cc: Vignesh Raghavendra, Siddharth Vadapalli, Lorenzo Pieralisi,
Rob Herring, Bjorn Helgaas, linux-omap, linux-pci,
linux-arm-kernel
Hello,
> The function pointer declaration for the cpu_addr_fixup() callback uses
> "cpu_addr" as parameter name.
>
> Likewise, the argument that is supplied to the function pointer when the
> function is actually called is "cpu_addr".
>
> Rename the cpu_addr_fixup parameter name to match reality.
Applied to controller/dwc, thank you!
[01/02] PCI: dra7xx: Fix dra7xx_pcie_cpu_addr_fixup() parameter name
https://git.kernel.org/pci/pci/c/6f4c62fd8a32
[02/02] PCI: artpec6: Fix artpec6_pcie_cpu_addr_fixup() parameter name
https://git.kernel.org/pci/pci/c/49993453e079
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-05-17 17:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-30 7:10 [PATCH 1/2] PCI: dra7xx: Fix cpu_addr_fixup parameter name Niklas Cassel
2024-05-17 17:11 ` Krzysztof Wilczyński
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox