From: Nathan Chancellor <nathan@kernel.org>
To: Ricardo Ribalda <ribalda@chromium.org>
Cc: Patrice Chotard <patrice.chotard@foss.st.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] media: c8sectpfe: Add missing parameter names
Date: Fri, 7 Jun 2024 09:35:30 -0700 [thread overview]
Message-ID: <20240607163530.GC2483293@thelio-3990X> (raw)
In-Reply-To: <20240606-c8sectpfe-v1-1-c4b18f38295d@chromium.org>
On Thu, Jun 06, 2024 at 01:01:07PM +0000, Ricardo Ribalda wrote:
> clang 19 complains about the missing parameter name. Let's add it.
>
> drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-debugfs.h:19:62: warning: omitting the parameter name in a function definition is a C23 extension [-Wc23-extensions]
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202406050908.1kL1C69p-lkp@intel.com/
> Fixes: e22b4973ee20 ("media: c8sectpfe: Do not depend on DEBUG_FS")
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> ---
> drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-debugfs.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-debugfs.h b/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-debugfs.h
> index 8e1bfd860524..3fe177b59b16 100644
> --- a/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-debugfs.h
> +++ b/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-debugfs.h
> @@ -16,8 +16,8 @@
> void c8sectpfe_debugfs_init(struct c8sectpfei *);
> void c8sectpfe_debugfs_exit(struct c8sectpfei *);
> #else
> -static inline void c8sectpfe_debugfs_init(struct c8sectpfei *) {};
> -static inline void c8sectpfe_debugfs_exit(struct c8sectpfei *) {};
> +static inline void c8sectpfe_debugfs_init(struct c8sectpfei *fei) {};
> +static inline void c8sectpfe_debugfs_exit(struct c8sectpfei *fei) {};
> #endif
>
> #endif /* __C8SECTPFE_DEBUG_H */
>
> ---
> base-commit: 1aea3d1d4a21e3e7895663b848ffae79ee82e065
> change-id: 20240606-c8sectpfe-5f00b9867f36
>
> Best regards,
> --
> Ricardo Ribalda <ribalda@chromium.org>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2024-06-07 16:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 13:01 [PATCH] media: c8sectpfe: Add missing parameter names Ricardo Ribalda
2024-06-07 16:35 ` Nathan Chancellor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240607163530.GC2483293@thelio-3990X \
--to=nathan@kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=justinstitt@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=morbo@google.com \
--cc=ndesaulniers@google.com \
--cc=patrice.chotard@foss.st.com \
--cc=ribalda@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox