* [PATCH] media: c8sectpfe: Add missing parameter names
@ 2024-06-06 13:01 Ricardo Ribalda
2024-06-07 16:35 ` Nathan Chancellor
0 siblings, 1 reply; 2+ messages in thread
From: Ricardo Ribalda @ 2024-06-06 13:01 UTC (permalink / raw)
To: Patrice Chotard, Mauro Carvalho Chehab, Nathan Chancellor,
Nick Desaulniers, Bill Wendling, Justin Stitt, Hans Verkuil
Cc: linux-arm-kernel, linux-media, linux-kernel, llvm,
kernel test robot, Ricardo Ribalda
clang 19 complains about the missing parameter name. Let's add it.
drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-debugfs.h:19:62: warning: omitting the parameter name in a function definition is a C23 extension [-Wc23-extensions]
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202406050908.1kL1C69p-lkp@intel.com/
Fixes: e22b4973ee20 ("media: c8sectpfe: Do not depend on DEBUG_FS")
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
---
drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-debugfs.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-debugfs.h b/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-debugfs.h
index 8e1bfd860524..3fe177b59b16 100644
--- a/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-debugfs.h
+++ b/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-debugfs.h
@@ -16,8 +16,8 @@
void c8sectpfe_debugfs_init(struct c8sectpfei *);
void c8sectpfe_debugfs_exit(struct c8sectpfei *);
#else
-static inline void c8sectpfe_debugfs_init(struct c8sectpfei *) {};
-static inline void c8sectpfe_debugfs_exit(struct c8sectpfei *) {};
+static inline void c8sectpfe_debugfs_init(struct c8sectpfei *fei) {};
+static inline void c8sectpfe_debugfs_exit(struct c8sectpfei *fei) {};
#endif
#endif /* __C8SECTPFE_DEBUG_H */
---
base-commit: 1aea3d1d4a21e3e7895663b848ffae79ee82e065
change-id: 20240606-c8sectpfe-5f00b9867f36
Best regards,
--
Ricardo Ribalda <ribalda@chromium.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] media: c8sectpfe: Add missing parameter names
2024-06-06 13:01 [PATCH] media: c8sectpfe: Add missing parameter names Ricardo Ribalda
@ 2024-06-07 16:35 ` Nathan Chancellor
0 siblings, 0 replies; 2+ messages in thread
From: Nathan Chancellor @ 2024-06-07 16:35 UTC (permalink / raw)
To: Ricardo Ribalda
Cc: Patrice Chotard, Mauro Carvalho Chehab, Nick Desaulniers,
Bill Wendling, Justin Stitt, Hans Verkuil, linux-arm-kernel,
linux-media, linux-kernel, llvm, kernel test robot
On Thu, Jun 06, 2024 at 01:01:07PM +0000, Ricardo Ribalda wrote:
> clang 19 complains about the missing parameter name. Let's add it.
>
> drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-debugfs.h:19:62: warning: omitting the parameter name in a function definition is a C23 extension [-Wc23-extensions]
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202406050908.1kL1C69p-lkp@intel.com/
> Fixes: e22b4973ee20 ("media: c8sectpfe: Do not depend on DEBUG_FS")
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> ---
> drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-debugfs.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-debugfs.h b/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-debugfs.h
> index 8e1bfd860524..3fe177b59b16 100644
> --- a/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-debugfs.h
> +++ b/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-debugfs.h
> @@ -16,8 +16,8 @@
> void c8sectpfe_debugfs_init(struct c8sectpfei *);
> void c8sectpfe_debugfs_exit(struct c8sectpfei *);
> #else
> -static inline void c8sectpfe_debugfs_init(struct c8sectpfei *) {};
> -static inline void c8sectpfe_debugfs_exit(struct c8sectpfei *) {};
> +static inline void c8sectpfe_debugfs_init(struct c8sectpfei *fei) {};
> +static inline void c8sectpfe_debugfs_exit(struct c8sectpfei *fei) {};
> #endif
>
> #endif /* __C8SECTPFE_DEBUG_H */
>
> ---
> base-commit: 1aea3d1d4a21e3e7895663b848ffae79ee82e065
> change-id: 20240606-c8sectpfe-5f00b9867f36
>
> Best regards,
> --
> Ricardo Ribalda <ribalda@chromium.org>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-06-07 16:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-06 13:01 [PATCH] media: c8sectpfe: Add missing parameter names Ricardo Ribalda
2024-06-07 16:35 ` Nathan Chancellor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox