* [PATCH] PCI: dw-rockchip: Use pci_epc_init_notify() directly
@ 2024-06-22 13:20 Niklas Cassel
2024-06-22 15:14 ` Krzysztof Wilczyński
0 siblings, 1 reply; 2+ messages in thread
From: Niklas Cassel @ 2024-06-22 13:20 UTC (permalink / raw)
To: Lorenzo Pieralisi, Krzysztof Wilczyński, Rob Herring,
Bjorn Helgaas, Heiko Stuebner
Cc: Damien Le Moal, Niklas Cassel, linux-pci, linux-arm-kernel,
linux-rockchip
Commit 9eba2f70362f ("PCI: dwc: ep: Remove dw_pcie_ep_init_notify()
wrapper") removed the dw_pcie_ep_init_notify() wrapper, and changed
the DWC glue drivers to instead use pci_epc_init_notify() directly.
The endpoint support for the dw-rockchip had not been merged at that
point in time, so commit 9eba2f70362f ("PCI: dwc: ep: Remove
dw_pcie_ep_init_notify() wrapper") did not update dw-rockchip.
Do the same change for dw-rockchip, so that the driver will not try
to use a function that has now been removed.
Signed-off-by: Niklas Cassel <cassel@kernel.org>
---
drivers/pci/controller/dwc/pcie-dw-rockchip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/controller/dwc/pcie-dw-rockchip.c b/drivers/pci/controller/dwc/pcie-dw-rockchip.c
index 0a0fdfc66b91..1170e1107508 100644
--- a/drivers/pci/controller/dwc/pcie-dw-rockchip.c
+++ b/drivers/pci/controller/dwc/pcie-dw-rockchip.c
@@ -488,7 +488,7 @@ static int rockchip_pcie_configure_ep(struct platform_device *pdev,
return ret;
}
- dw_pcie_ep_init_notify(&rockchip->pci.ep);
+ pci_epc_init_notify(rockchip->pci.ep.epc);
/* unmask DLL up/down indicator and hot reset/link-down reset */
rockchip_pcie_writel_apb(rockchip, 0x60000, PCIE_CLIENT_INTR_MASK_MISC);
--
2.45.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] PCI: dw-rockchip: Use pci_epc_init_notify() directly
2024-06-22 13:20 [PATCH] PCI: dw-rockchip: Use pci_epc_init_notify() directly Niklas Cassel
@ 2024-06-22 15:14 ` Krzysztof Wilczyński
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Wilczyński @ 2024-06-22 15:14 UTC (permalink / raw)
To: Niklas Cassel
Cc: Lorenzo Pieralisi, Rob Herring, Bjorn Helgaas, Heiko Stuebner,
Damien Le Moal, linux-pci, linux-arm-kernel, linux-rockchip
Hello,
> Commit 9eba2f70362f ("PCI: dwc: ep: Remove dw_pcie_ep_init_notify()
> wrapper") removed the dw_pcie_ep_init_notify() wrapper, and changed
> the DWC glue drivers to instead use pci_epc_init_notify() directly.
>
> The endpoint support for the dw-rockchip had not been merged at that
> point in time, so commit 9eba2f70362f ("PCI: dwc: ep: Remove
> dw_pcie_ep_init_notify() wrapper") did not update dw-rockchip.
>
> Do the same change for dw-rockchip, so that the driver will not try
> to use a function that has now been removed.
Applied to controller/rockchip, thank you!
[1/1] PCI: dw-rockchip: Use pci_epc_init_notify() directly
https://git.kernel.org/pci/pci/c/246afbe0f6fc
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-06-22 15:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-22 13:20 [PATCH] PCI: dw-rockchip: Use pci_epc_init_notify() directly Niklas Cassel
2024-06-22 15:14 ` Krzysztof Wilczyński
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox