From: Borislav Petkov <bp@alien8.de>
To: Serge Semin <fancer.lancer@gmail.com>
Cc: Michal Simek <michal.simek@amd.com>,
Alexander Stein <alexander.stein@ew.tq-group.com>,
Tony Luck <tony.luck@intel.com>,
James Morse <james.morse@arm.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Robert Richter <rric@kernel.org>,
Punnaiah Choudary Kalluri <punnaiah.choudary.kalluri@xilinx.com>,
Dinh Nguyen <dinguyen@kernel.org>,
Shubhrajyoti Datta <shubhrajyoti.datta@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org, Borislav Petkov <bp@suse.de>
Subject: Re: [PATCH RESEND v6 02/18] EDAC/synopsys: Fix mci->scrub_cap field setting
Date: Tue, 9 Jul 2024 13:35:22 +0200 [thread overview]
Message-ID: <20240709113522.GEZo0getHKGPD588S1@fat_crate.local> (raw)
In-Reply-To: <20240627173251.25718-3-fancer.lancer@gmail.com>
On Thu, Jun 27, 2024 at 08:32:09PM +0300, Serge Semin wrote:
> The mem_ctl_info.scrub_cap field is supposed to be set with the ECC
> scrub-related flags. Instead the driver erroneously initializes it with
> the SCRUB_HW_SRC flag ID. It's definitely wrong, but it hasn't caused any
> problem so far since the structure field isn't used by the EDAC core. Fix
> it anyway by using the SCRUB_FLAG_HW_SRC macro to initialize the field.
This hasn't been used at least since it got added by
commit da9bb1d27b21cb24cbb6a2efb5d3c464d357a01e
Author: Alan Cox <alan@lxorguk.ukuu.org.uk>
Date: Wed Jan 18 17:44:13 2006 -0800
[PATCH] EDAC: core EDAC support code
AFAICT.
Please remove ->scrub_cap along with enum scrub_type instead.
We can always resurrect it if needed.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2024-07-09 11:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-27 17:32 [PATCH RESEND v6 00/18] EDAC/mc/synopsys: Various fixes and cleanups Serge Semin
2024-06-27 17:32 ` [PATCH RESEND v6 01/18] EDAC/synopsys: Fix generic device type detection procedure Serge Semin
2024-06-28 6:01 ` Borislav Petkov
2024-06-27 17:32 ` [PATCH RESEND v6 02/18] EDAC/synopsys: Fix mci->scrub_cap field setting Serge Semin
2024-07-09 11:35 ` Borislav Petkov [this message]
2024-07-11 15:11 ` Serge Semin
2024-06-27 17:32 ` [PATCH RESEND v6 03/18] EDAC/synopsys: Drop erroneous ADDRMAP4.addrmap_col_b10 parse Serge Semin
2024-06-27 17:32 ` [PATCH RESEND v6 04/18] EDAC/synopsys: Fix reading errors count before ECC status Serge Semin
2024-06-27 17:32 ` [PATCH RESEND v6 05/18] EDAC/synopsys: Fix misleading IRQ self-cleared quirk flag Serge Semin
2024-06-27 17:32 ` [PATCH RESEND v6 06/18] EDAC/synopsys: Drop internal CE and UE counters Serge Semin
2024-06-27 17:32 ` [PATCH RESEND v6 07/18] EDAC/synopsys: Drop local to_mci() macro definition Serge Semin
2024-06-27 17:32 ` [PATCH RESEND v6 08/18] EDAC/synopsys: Drop struct ecc_error_info.blknr field Serge Semin
2024-06-27 17:32 ` [PATCH RESEND v6 09/18] EDAC/synopsys: Shorten out struct ecc_error_info.bankgrpnr field name Serge Semin
2024-06-27 17:32 ` [PATCH RESEND v6 10/18] EDAC/synopsys: Drop redundant info from the error messages Serge Semin
2024-06-27 17:32 ` [PATCH RESEND v6 11/18] EDAC/mc: Init DIMM labels in MC registration method Serge Semin
2024-06-27 17:32 ` [PATCH RESEND v6 12/18] EDAC/mc: Add generic unique MC index allocation procedure Serge Semin
2024-06-27 17:32 ` [PATCH RESEND v6 13/18] EDAC/mc: Re-use " Serge Semin
2024-06-27 17:32 ` [PATCH RESEND v6 14/18] EDAC/synopsys: Detach Zynq A05 DDRC support to separate driver Serge Semin
2024-06-27 17:32 ` [PATCH RESEND v6 15/18] EDAC/synopsys: Drop unused platform-specific setup API Serge Semin
2024-06-27 17:32 ` [PATCH RESEND v6 16/18] EDAC/synopsys: Unify CSRs macro declarations Serge Semin
2024-06-27 17:32 ` [PATCH RESEND v6 17/18] EDAC/synopsys: Unify struct/macro/function prefixes Serge Semin
2024-06-27 17:32 ` [PATCH RESEND v6 18/18] EDAC/synopsys: Convert to using BIT/GENMASK/FIELD_x macros Serge Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240709113522.GEZo0getHKGPD588S1@fat_crate.local \
--to=bp@alien8.de \
--cc=alexander.stein@ew.tq-group.com \
--cc=arnd@arndb.de \
--cc=bp@suse.de \
--cc=dinguyen@kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=michal.simek@amd.com \
--cc=punnaiah.choudary.kalluri@xilinx.com \
--cc=rric@kernel.org \
--cc=shubhrajyoti.datta@gmail.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox