* [PATCH v2 0/5] usb drivers use devm_clk_get_enabled() helpers
@ 2024-08-26 7:02 Lei Liu
2024-08-26 7:14 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Lei Liu @ 2024-08-26 7:02 UTC (permalink / raw)
To: Neal Liu, Greg Kroah-Hartman, Joel Stanley, Andrew Jeffery,
Daniel Mack, Haojian Zhuang, Robert Jarzmik, Conor Dooley,
Daire McNamara, Bin Liu, Uwe Kleine-König, Lei Liu,
linux-aspeed, linux-usb, linux-arm-kernel, linux-kernel,
linux-riscv
Cc: opensource.kernel
The devm_clk_get_enabled() helpers:
- call devm_clk_get()
- call clk_prepare_enable() and register what is needed in order to
call clk_disable_unprepare() when needed, as a managed resource.
This simplifies the code and avoids calls to clk_disable_unprepare().
---
The files ux500.c, mpfs.c, and pxa27x_udc.c have incorrect usage of
certain interfaces due to the lack of synchronization during the
commit updates. These issues have been corrected in the v1 version.
version 2 changes
1.ux500: Incorrect usage of clk_prepare_enable() should be corrected to
devm_clk_get_enabled().
2.mpfs: Incorrect usage of devm_clk_get_enable() should be corrected to
devm_clk_get_enabled().
3.pxa27x_udc: Incorrect usage of clk_prepare_enable() should be
corrected to devm_clk_get_enabled().
Lei Liu (5):
usb: aspeed_udc: Use devm_clk_get_enabled() helpers
usb: pxa27x_udc: Use devm_clk_get_enabled() helpers
usb: r8a66597-udc: Use devm_clk_get_enabled() helpers
usb: mpfs: Use devm_clk_get_enabled() helpers
sb: ux500: Use devm_clk_get_enabled() helpers
drivers/usb/gadget/udc/aspeed_udc.c | 9 +--------
drivers/usb/gadget/udc/pxa27x_udc.c | 6 +-----
drivers/usb/gadget/udc/r8a66597-udc.c | 16 ++++------------
drivers/usb/musb/mpfs.c | 22 ++++++----------------
drivers/usb/musb/ux500.c | 18 ++++--------------
5 files changed, 16 insertions(+), 55 deletions(-)
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2 0/5] usb drivers use devm_clk_get_enabled() helpers
2024-08-26 7:02 [PATCH v2 0/5] usb drivers use devm_clk_get_enabled() helpers Lei Liu
@ 2024-08-26 7:14 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2024-08-26 7:14 UTC (permalink / raw)
To: Lei Liu
Cc: Neal Liu, Joel Stanley, Andrew Jeffery, Daniel Mack,
Haojian Zhuang, Robert Jarzmik, Conor Dooley, Daire McNamara,
Bin Liu, Uwe Kleine-König, linux-aspeed, linux-usb,
linux-arm-kernel, linux-kernel, linux-riscv, opensource.kernel
On Mon, Aug 26, 2024 at 03:02:38PM +0800, Lei Liu wrote:
> The devm_clk_get_enabled() helpers:
> - call devm_clk_get()
> - call clk_prepare_enable() and register what is needed in order to
> call clk_disable_unprepare() when needed, as a managed resource.
>
> This simplifies the code and avoids calls to clk_disable_unprepare().
Your email threading is broken for some reason :(
Please fix up and send a v3 series.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-26 7:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-26 7:02 [PATCH v2 0/5] usb drivers use devm_clk_get_enabled() helpers Lei Liu
2024-08-26 7:14 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox