From: Nishanth Menon <nm@ti.com>
To: Robert Nelson <robertcnelson@gmail.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Vignesh Raghavendra <vigneshr@ti.com>, Andrew Davis <afd@ti.com>,
Jai Luthra <j-luthra@ti.com>, Roger Quadros <rogerq@kernel.org>,
Siddharth Vadapalli <s-vadapalli@ti.com>,
Jared McArthur <j-mcarthur@ti.com>,
Jason Kridner <jkridner@beagleboard.org>,
Deepak Khatri <lorforlinux@beagleboard.org>,
Drew Fustini <drew@beagleboard.org>
Subject: Re: [PATCH v3 2/2] arm64: dts: ti: Add k3-am67a-beagley-ai
Date: Wed, 28 Aug 2024 11:59:54 -0500 [thread overview]
Message-ID: <20240828165954.4d2uf65khni7rlr5@uncurled> (raw)
In-Reply-To: <CAOCHtYg8DTuGncoxKPvTOyKvGrF-zNMwVvKcNWzRHxT5Hvt7nw@mail.gmail.com>
On 11:34-20240828, Robert Nelson wrote:
[...]
>
> /builds/RobertCNelson/arm64-multiplatform/KERNEL/arch/arm64/boot/dts/ti/k3-am67a-beagley-ai.dtb:
> leds: led-0:linux,default-trigger: 'oneOf' conditional failed, one
> must be fixed:
> 'off' is not one of ['backlight', 'default-on', 'heartbeat',
> 'disk-activity', 'disk-read', 'disk-write', 'timer', 'pattern',
> 'audio-micmute', 'audio-mute', 'bluetooth-power', 'flash',
> 'kbd-capslock', 'mtd', 'nand-disk', 'none', 'torch', 'usb-gadget',
> 'usb-host', 'usbport']
>
> I guess, 'none' is close... off/etc..
>
I'd just suggest to drop the property since you already use heartbeat.
Also function = is alternate option, if you choose to go down the road
of enabling a function
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/dt-bindings/leds/common.h#n77
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/leds/common.yaml#n83
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
next prev parent reply other threads:[~2024-08-28 17:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 17:04 [PATCH v3 1/2] dt-bindings: arm: ti: Add BeagleY-AI Robert Nelson
2024-08-22 17:04 ` [PATCH v3 2/2] arm64: dts: ti: Add k3-am67a-beagley-ai Robert Nelson
2024-08-23 7:46 ` Krzysztof Kozlowski
2024-08-23 15:31 ` Robert Nelson
2024-08-23 11:23 ` Roger Quadros
2024-08-23 15:33 ` Robert Nelson
2024-08-28 14:33 ` Robert Nelson
2024-08-28 19:44 ` Roger Quadros
2024-08-28 19:48 ` Robert Nelson
2024-08-24 18:44 ` Nishanth Menon
2024-08-28 14:38 ` Robert Nelson
2024-08-28 16:34 ` Robert Nelson
2024-08-28 16:59 ` Nishanth Menon [this message]
2024-08-28 19:43 ` Robert Nelson
2024-08-23 7:41 ` [PATCH v3 1/2] dt-bindings: arm: ti: Add BeagleY-AI Krzysztof Kozlowski
2024-08-23 15:24 ` Robert Nelson
2024-08-24 7:41 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240828165954.4d2uf65khni7rlr5@uncurled \
--to=nm@ti.com \
--cc=afd@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=drew@beagleboard.org \
--cc=j-luthra@ti.com \
--cc=j-mcarthur@ti.com \
--cc=jkridner@beagleboard.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorforlinux@beagleboard.org \
--cc=robertcnelson@gmail.com \
--cc=robh@kernel.org \
--cc=rogerq@kernel.org \
--cc=s-vadapalli@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox