Re: [PATCH v4] ASoC: dt-bindings: Convert mxs-saif.txt to fsl,imx28-saif.yaml (imx28 saif)

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1545 bytes --]

On Thu, Aug 29, 2024 at 12:26:25PM +0200, Lukasz Majewski wrote:
> The 'fsl,imx28-saif' compatible has already the mxs-saif.txt description.
> This patch converts (and removes it) this file to fsl,imx28-saif.yaml.
> 
> Changes for the mxs-saif.txt:
> - Adds 'clocks', '#clock-cells' and '#sound-dai-cells' properties
> - Provide device description
> 
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
> 
> ---
> Changes for v4:
> - Change file name to match compatible (fsl,imx28-saif.yaml)
> - Remove 'saif0' and 'saif1' labels as those are not needed in the
>   example node

Hmm, what you've done is not quite what I was suggesting. I was saying
that either you should remove one of the examples entirely, or merge the
two examples retaining the only saif0 label.

With that sorted,
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.


> +examples:
> +  - |
> +    saif@80042000 {
> +        compatible = "fsl,imx28-saif";
> +        reg = <0x80042000 2000>;
> +        #sound-dai-cells = <0>;
> +        interrupts = <59>;
> +        dmas = <&dma_apbx 4>;
> +        dma-names = "rx-tx";
> +        #clock-cells = <0>;
> +        clocks = <&clks 53>;
> +    };
> +    saif@80046000 {
> +        compatible = "fsl,imx28-saif";
> +        reg = <0x80046000 2000>;
> +        #sound-dai-cells = <0>;
> +        interrupts = <58>;
> +        dmas = <&dma_apbx 5>;
> +        dma-names = "rx-tx";
> +        clocks = <&clks 53>;
> +        fsl,saif-master = <&saif0>;
> +    };

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]