Re: [PATCH v2 1/2] dt-bindings: mmc: sdhci-atmel: Convert to json schema

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2769 bytes --]

On Fri, Aug 30, 2024 at 02:12:48PM +0000, Dharma.B@microchip.com wrote:
> Hi Conor,
> 
> On 30/08/24 7:18 pm, Conor Dooley wrote:
> > On Fri, Aug 30, 2024 at 01:49:42PM +0530, Dharma Balasubiramani wrote:
> >> Convert sdhci-atmel documentation to yaml format. The new file will inherit
> >> from sdhci-common.yaml.
> >>
> >> Note: Add microchip,sama7g5-sdhci to compatible list as we already use it
> >> in the DT.
> >>
> >> Signed-off-by: Dharma Balasubiramani<dharma.b@microchip.com>
> >> ---
> >>   .../bindings/mmc/atmel,sama5d2-sdhci.yaml          | 98 ++++++++++++++++++++++
> >>   .../devicetree/bindings/mmc/sdhci-atmel.txt        | 35 --------
> >>   2 files changed, 98 insertions(+), 35 deletions(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/mmc/atmel,sama5d2-sdhci.yaml b/Documentation/devicetree/bindings/mmc/atmel,sama5d2-sdhci.yaml
> >> new file mode 100644
> >> index 000000000000..91d18b2545e1
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/mmc/atmel,sama5d2-sdhci.yaml
> >> @@ -0,0 +1,98 @@
> >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> >> +%YAML 1.2
> >> +---
> >> +$id:http://devicetree.org/schemas/mmc/atmel,sama5d2-sdhci.yaml#
> >> +$schema:http://devicetree.org/meta-schemas/core.yaml#
> >> +
> >> +title: Atmel SDHCI controller
> >> +
> >> +maintainers:
> >> +  - Aubin Constans<aubin.constans@microchip.com>
> >> +  - Nicolas Ferre<nicolas.ferre@microchip.com>
> >> +
> >> +description:
> >> +  Bindings for the SDHCI controller found in Atmel/Microchip SoCs.
> >> +
> >> +properties:
> >> +  compatible:
> >> +    oneOf:
> >> +      - enum:
> >> +          - atmel,sama5d2-sdhci
> >> +          - atmel,sama5d3-sdhci
> >> +          - atmel,sama5d4-sdhci
> >> +          - microchip,sam9x60-sdhci
> >> +      - items:
> >> +          - enum:
> >> +              - microchip,sama7g5-sdhci
> >> +          - const: microchip,sam9x60-sdhci
> >> +
> >> +  reg:
> >> +    maxItems: 1
> >> +
> >> +  interrupts:
> >> +    maxItems: 1
> >> +
> >> +  clocks:
> >> +    minItems: 2
> >> +    maxItems: 3
> >> +    description: |
> >> +      The sama5d2 family includes three clocks: `hclock`, `multclk`, and `baseclk`.
> >> +      For other families, including sam9x60 and sam9x7, only `hclock` and `multclk` are used.
> > This should instead be an items list, rather than a text based
> > description.
> Sure, I will update it like this below
> 
> clocks:
>    items:
>      - description: hclock
>      - description: multclk
>      - description: baseclk
>    minItems: 2
>    maxItems: 3

This shouldn't pass dt_binding_check, because the max in this snippet is
redundant due to it matching the size of the items list.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]