public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: Prasanth Babu Mantena <p-mantena@ti.com>
Cc: <vigneshr@ti.com>, <krzk+dt@kernel.org>, <kristo@kernel.org>,
	<robh@kernel.org>, <conor+dt@kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<u-kumar1@ti.com>, <sinthu.raja@ti.com>, <m-chawdhry@ti.com>
Subject: Re: [PATCH] arm64: dts: ti: k3-am68-sk-som: Update Partition info for OSPI Flash
Date: Fri, 30 Aug 2024 06:24:52 -0500	[thread overview]
Message-ID: <20240830112452.geyv7tecpb6ydhmz@quotable> (raw)
In-Reply-To: <20240828060830.555733-1-p-mantena@ti.com>

On 11:38-20240828, Prasanth Babu Mantena wrote:
> Commit 73f1f26e2e4c ("arm64: dts: ti: k3-am68-sk-som: Add support
> for OSPI flash") introduced the flash node with discontinuous
> partitions. Updating the partition offset to be continuous from
> the previous partition to maintain linearity.
> 
> Signed-off-by: Prasanth Babu Mantena <p-mantena@ti.com>
> ---

Please note my response to a similar patch
https://lore.kernel.org/all/20240830092234.veog3e22te7qi3ao@dugout/

I do not want us breaking existing users unless absolutely warranted,
even then, I'd like us to be very cognizant of the minimum amount of
disruption possible.

Normally, I'd say no to this kind of patches. But, since this is in
the backup env, I am not *that* worried, but I want to make sure folks
understand breaking existing users without a just cause is a NO NO.

>  arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi b/arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi
> index 5c66e0ec6e82..2e5730216caa 100644
> --- a/arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi
> @@ -215,9 +215,9 @@ partition@680000 {
>  				reg = <0x680000 0x40000>;
>  			};
>  
> -			partition@740000 {
> +			partition@6c0000 {
>  				label = "ospi.env.backup";
> -				reg = <0x740000 0x40000>;
> +				reg = <0x6c0000 0x40000>;
>  			};
>  
>  			partition@800000 {
> -- 
> 2.34.1
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D


  reply	other threads:[~2024-08-30 11:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-28  6:08 [PATCH] arm64: dts: ti: k3-am68-sk-som: Update Partition info for OSPI Flash Prasanth Babu Mantena
2024-08-30 11:24 ` Nishanth Menon [this message]
2024-09-01 21:15 ` Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240830112452.geyv7tecpb6ydhmz@quotable \
    --to=nm@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m-chawdhry@ti.com \
    --cc=p-mantena@ti.com \
    --cc=robh@kernel.org \
    --cc=sinthu.raja@ti.com \
    --cc=u-kumar1@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox