* [PATCH v3 1/2] dt-bindings: phy: mxs-usb-phy: add nxp,sim property
@ 2024-09-03 7:58 Xu Yang
2024-09-03 7:58 ` [PATCH v3 2/2] ARM: dts: imx7ulp: add "nxp,sim" property for usbphy1 Xu Yang
0 siblings, 1 reply; 5+ messages in thread
From: Xu Yang @ 2024-09-03 7:58 UTC (permalink / raw)
To: vkoul, kishon, robh, krzk+dt, conor+dt, shawnguo, s.hauer, kernel,
festevam, gregkh
Cc: linux-phy, devicetree, imx, linux-arm-kernel, linux-usb
i.MX7ULP need properly set System Integration Module(SIM) module to make
usb wakeup work well. This will add a "nxp,sim" property.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
---
Changes in v2:
- add else branch suggested by Rob
Changes in v3:
- add Rb tag
---
.../devicetree/bindings/phy/fsl,mxs-usbphy.yaml | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
index f4b1ca2fb562..ce665a2779b7 100644
--- a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
+++ b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
@@ -87,6 +87,12 @@ properties:
maximum: 119
default: 100
+ nxp,sim:
+ description:
+ The system integration module (SIM) provides system control and chip
+ configuration registers.
+ $ref: /schemas/types.yaml#/definitions/phandle
+
required:
- compatible
- reg
@@ -110,6 +116,17 @@ allOf:
required:
- fsl,anatop
+ - if:
+ properties:
+ compatible:
+ const: fsl,imx7ulp-usbphy
+ then:
+ required:
+ - nxp,sim
+ else:
+ properties:
+ nxp,sim: false
+
additionalProperties: false
examples:
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH v3 2/2] ARM: dts: imx7ulp: add "nxp,sim" property for usbphy1
2024-09-03 7:58 [PATCH v3 1/2] dt-bindings: phy: mxs-usb-phy: add nxp,sim property Xu Yang
@ 2024-09-03 7:58 ` Xu Yang
2024-09-04 6:34 ` Xu Yang
0 siblings, 1 reply; 5+ messages in thread
From: Xu Yang @ 2024-09-03 7:58 UTC (permalink / raw)
To: vkoul, kishon, robh, krzk+dt, conor+dt, shawnguo, s.hauer, kernel,
festevam, gregkh
Cc: linux-phy, devicetree, imx, linux-arm-kernel, linux-usb
i.MX7ULP need properly set System Integration Module(SIM) module to make
usb wakeup work well. This will add a "nxp,sim" property for usbphy1.
Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
---
Changes in v2:
- no changes
Changes in v3:
- no changes
---
arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi b/arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi
index ac338320ac1d..b093f2a447ae 100644
--- a/arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi
@@ -214,6 +214,7 @@ usbphy1: usb-phy@40350000 {
interrupts = <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&pcc2 IMX7ULP_CLK_USB_PHY>;
#phy-cells = <0>;
+ nxp,sim = <&sim>;
};
usdhc0: mmc@40370000 {
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v3 2/2] ARM: dts: imx7ulp: add "nxp,sim" property for usbphy1
2024-09-03 7:58 ` [PATCH v3 2/2] ARM: dts: imx7ulp: add "nxp,sim" property for usbphy1 Xu Yang
@ 2024-09-04 6:34 ` Xu Yang
2024-09-04 7:00 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Xu Yang @ 2024-09-04 6:34 UTC (permalink / raw)
To: vkoul, kishon, robh, krzk+dt, conor+dt, shawnguo, s.hauer, kernel,
festevam, gregkh
Cc: linux-phy, devicetree, imx, linux-arm-kernel, linux-usb
Hi Shawn,
On Tue, Sep 03, 2024 at 03:58:10PM +0800, Xu Yang wrote:
> i.MX7ULP need properly set System Integration Module(SIM) module to make
> usb wakeup work well. This will add a "nxp,sim" property for usbphy1.
>
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
>
> ---
> Changes in v2:
> - no changes
> Changes in v3:
> - no changes
> ---
> arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi b/arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi
> index ac338320ac1d..b093f2a447ae 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi
> @@ -214,6 +214,7 @@ usbphy1: usb-phy@40350000 {
> interrupts = <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&pcc2 IMX7ULP_CLK_USB_PHY>;
> #phy-cells = <0>;
> + nxp,sim = <&sim>;
> };
The dtschema patch #1 has been picked by Greg. You can pick up patch #2
when you see this ping.
Thanks,
Xu Yang
>
> usdhc0: mmc@40370000 {
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v3 2/2] ARM: dts: imx7ulp: add "nxp,sim" property for usbphy1
2024-09-04 6:34 ` Xu Yang
@ 2024-09-04 7:00 ` Greg KH
2024-09-04 7:09 ` Xu Yang
0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2024-09-04 7:00 UTC (permalink / raw)
To: Xu Yang
Cc: vkoul, kishon, robh, krzk+dt, conor+dt, shawnguo, s.hauer, kernel,
festevam, linux-phy, devicetree, imx, linux-arm-kernel, linux-usb
On Wed, Sep 04, 2024 at 02:34:07PM +0800, Xu Yang wrote:
> Hi Shawn,
>
> On Tue, Sep 03, 2024 at 03:58:10PM +0800, Xu Yang wrote:
> > i.MX7ULP need properly set System Integration Module(SIM) module to make
> > usb wakeup work well. This will add a "nxp,sim" property for usbphy1.
> >
> > Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> >
> > ---
> > Changes in v2:
> > - no changes
> > Changes in v3:
> > - no changes
> > ---
> > arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi b/arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi
> > index ac338320ac1d..b093f2a447ae 100644
> > --- a/arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi
> > +++ b/arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi
> > @@ -214,6 +214,7 @@ usbphy1: usb-phy@40350000 {
> > interrupts = <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>;
> > clocks = <&pcc2 IMX7ULP_CLK_USB_PHY>;
> > #phy-cells = <0>;
> > + nxp,sim = <&sim>;
> > };
>
> The dtschema patch #1 has been picked by Greg. You can pick up patch #2
> when you see this ping.
Because our tools like to suck in entire patch series at once, you
should really just resend this so that Shawn doesn't accidentally take
patch 1/2 as well.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v3 2/2] ARM: dts: imx7ulp: add "nxp,sim" property for usbphy1
2024-09-04 7:00 ` Greg KH
@ 2024-09-04 7:09 ` Xu Yang
0 siblings, 0 replies; 5+ messages in thread
From: Xu Yang @ 2024-09-04 7:09 UTC (permalink / raw)
To: Greg KH
Cc: vkoul, kishon, robh, krzk+dt, conor+dt, shawnguo, s.hauer, kernel,
festevam, linux-phy, devicetree, imx, linux-arm-kernel, linux-usb
On Wed, Sep 04, 2024 at 09:00:45AM +0200, Greg KH wrote:
> On Wed, Sep 04, 2024 at 02:34:07PM +0800, Xu Yang wrote:
> > Hi Shawn,
> >
> > On Tue, Sep 03, 2024 at 03:58:10PM +0800, Xu Yang wrote:
> > > i.MX7ULP need properly set System Integration Module(SIM) module to make
> > > usb wakeup work well. This will add a "nxp,sim" property for usbphy1.
> > >
> > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> > >
> > > ---
> > > Changes in v2:
> > > - no changes
> > > Changes in v3:
> > > - no changes
> > > ---
> > > arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi b/arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi
> > > index ac338320ac1d..b093f2a447ae 100644
> > > --- a/arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi
> > > +++ b/arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi
> > > @@ -214,6 +214,7 @@ usbphy1: usb-phy@40350000 {
> > > interrupts = <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>;
> > > clocks = <&pcc2 IMX7ULP_CLK_USB_PHY>;
> > > #phy-cells = <0>;
> > > + nxp,sim = <&sim>;
> > > };
> >
> > The dtschema patch #1 has been picked by Greg. You can pick up patch #2
> > when you see this ping.
>
> Because our tools like to suck in entire patch series at once, you
> should really just resend this so that Shawn doesn't accidentally take
> patch 1/2 as well.
Well, thanks for reminding me again. I'm going to do that.
Best Regards,
Xu Yang
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-09-04 7:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-03 7:58 [PATCH v3 1/2] dt-bindings: phy: mxs-usb-phy: add nxp,sim property Xu Yang
2024-09-03 7:58 ` [PATCH v3 2/2] ARM: dts: imx7ulp: add "nxp,sim" property for usbphy1 Xu Yang
2024-09-04 6:34 ` Xu Yang
2024-09-04 7:00 ` Greg KH
2024-09-04 7:09 ` Xu Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox