From: Nick Chan <towinchenmi@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org
Cc: asahi@lists.linux.dev, Nick Chan <towinchenmi@gmail.com>
Subject: [PATCH 1/2] tty: serial: samsung: Fix A7-A11 serial earlycon SError
Date: Sat, 7 Sep 2024 19:06:44 +0800 [thread overview]
Message-ID: <20240907111431.2970-2-towinchenmi@gmail.com> (raw)
In-Reply-To: <20240907111431.2970-1-towinchenmi@gmail.com>
Apple's earlier SoCs, like A7-A11, requires 32-bit writes for the serial
port. Otherwise, a SError happens when writing to UTXH (+0x20). This only
manifested in earlycon as reg-io-width in the device tree is consulted
for normal serial writes.
Change the iotype of the port to UPIO_MEM32, to allow the serial port to
function on A7-A11 SoCs. This change does not appear to affect Apple M1 and
above.
Signed-off-by: Nick Chan <towinchenmi@gmail.com>
---
drivers/tty/serial/samsung_tty.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c
index c4f2ac9518aa..27b8a50bd3e7 100644
--- a/drivers/tty/serial/samsung_tty.c
+++ b/drivers/tty/serial/samsung_tty.c
@@ -2536,7 +2536,7 @@ static const struct s3c24xx_serial_drv_data s5l_serial_drv_data = {
.name = "Apple S5L UART",
.type = TYPE_APPLE_S5L,
.port_type = PORT_8250,
- .iotype = UPIO_MEM,
+ .iotype = UPIO_MEM32,
.fifosize = 16,
.rx_fifomask = S3C2410_UFSTAT_RXMASK,
.rx_fifoshift = S3C2410_UFSTAT_RXSHIFT,
@@ -2825,8 +2825,10 @@ static int __init apple_s5l_early_console_setup(struct earlycon_device *device,
/* Close enough to S3C2410 for earlycon... */
device->port.private_data = &s3c2410_early_console_data;
+ /* ... however, we need to change the port iotype */
+ device->port.iotype = UPIO_MEM32;
#ifdef CONFIG_ARM64
- /* ... but we need to override the existing fixmap entry as nGnRnE */
+ /* ... and also override the existing fixmap entry as nGnRnE */
__set_fixmap(FIX_EARLYCON_MEM_BASE, device->port.mapbase,
__pgprot(PROT_DEVICE_nGnRnE));
#endif
--
2.46.0
next prev parent reply other threads:[~2024-09-07 11:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-07 11:06 [PATCH 0/2] tty: serial: samsung: Serial fixes for Apple A7-A11 SoCs Nick Chan
2024-09-07 11:06 ` Nick Chan [this message]
2024-09-07 12:54 ` [PATCH 1/2] tty: serial: samsung: Fix A7-A11 serial earlycon SError Krzysztof Kozlowski
2024-09-07 13:22 ` Nick Chan
2024-09-07 11:06 ` [PATCH 2/2] tty: serial: samsung: Fix serial rx on Apple A7-A9 SoCs Nick Chan
2024-09-07 12:55 ` Krzysztof Kozlowski
2024-09-07 13:36 ` Nick Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240907111431.2970-2-towinchenmi@gmail.com \
--to=towinchenmi@gmail.com \
--cc=alim.akhtar@samsung.com \
--cc=asahi@lists.linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox