From: Nick Chan <towinchenmi@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org
Cc: asahi@lists.linux.dev
Subject: Re: [PATCH 2/2] tty: serial: samsung: Fix serial rx on Apple A7-A9 SoCs
Date: Sat, 7 Sep 2024 21:36:38 +0800 [thread overview]
Message-ID: <d5d06aaa-ab93-47c3-b7c5-ad8dd3ca66f2@gmail.com> (raw)
In-Reply-To: <3596ef82-b2a4-40a0-8a66-575e26c386d9@kernel.org>
On 7/9/2024 20:55, Krzysztof Kozlowski wrote:
> On 07/09/2024 13:06, Nick Chan wrote:
>>
>> diff --git a/include/linux/serial_s3c.h b/include/linux/serial_s3c.h
>> index 1672cf0810ef..849d502d348d 100644
>> --- a/include/linux/serial_s3c.h
>> +++ b/include/linux/serial_s3c.h
>> @@ -246,24 +246,28 @@
>> S5PV210_UFCON_TXTRIG4 | \
>> S5PV210_UFCON_RXTRIG4)
>>
>> -#define APPLE_S5L_UCON_RXTO_ENA 9
>> -#define APPLE_S5L_UCON_RXTHRESH_ENA 12
>> -#define APPLE_S5L_UCON_TXTHRESH_ENA 13
>> -#define APPLE_S5L_UCON_RXTO_ENA_MSK (1 << APPLE_S5L_UCON_RXTO_ENA)
>> -#define APPLE_S5L_UCON_RXTHRESH_ENA_MSK (1 << APPLE_S5L_UCON_RXTHRESH_ENA)
>> -#define APPLE_S5L_UCON_TXTHRESH_ENA_MSK (1 << APPLE_S5L_UCON_TXTHRESH_ENA)
>> +#define APPLE_S5L_UCON_RXTO_ENA 9
>> +#define APPLE_S5L_UCON_RXTO_LEGACY_ENA 11
>> +#define APPLE_S5L_UCON_RXTHRESH_ENA 12
>> +#define APPLE_S5L_UCON_TXTHRESH_ENA 13
>> +#define APPLE_S5L_UCON_RXTO_ENA_MSK (1 << APPLE_S5L_UCON_RXTO_ENA)
>> +#define APPLE_S5L_UCON_RXTO_LEGACY_ENA_MSK (1 << APPLE_S5L_UCON_RXTO_LEGACY_ENA)
>> +#define APPLE_S5L_UCON_RXTHRESH_ENA_MSK (1 << APPLE_S5L_UCON_RXTHRESH_ENA)
>> +#define APPLE_S5L_UCON_TXTHRESH_ENA_MSK (1 << APPLE_S5L_UCON_TXTHRESH_ENA)
>
> Use BIT() for new entries. You can also convert the earlier defines to
> BIT() in separate patches.
Acked. Version 2 will change APPLE_S5L_* entries to use BIT(), and then
add the new
entries with BIT().
>
>>
>
> Best regards,
> Krzysztof
>
Nick Chan
prev parent reply other threads:[~2024-09-07 13:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-07 11:06 [PATCH 0/2] tty: serial: samsung: Serial fixes for Apple A7-A11 SoCs Nick Chan
2024-09-07 11:06 ` [PATCH 1/2] tty: serial: samsung: Fix A7-A11 serial earlycon SError Nick Chan
2024-09-07 12:54 ` Krzysztof Kozlowski
2024-09-07 13:22 ` Nick Chan
2024-09-07 11:06 ` [PATCH 2/2] tty: serial: samsung: Fix serial rx on Apple A7-A9 SoCs Nick Chan
2024-09-07 12:55 ` Krzysztof Kozlowski
2024-09-07 13:36 ` Nick Chan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5d06aaa-ab93-47c3-b7c5-ad8dd3ca66f2@gmail.com \
--to=towinchenmi@gmail.com \
--cc=alim.akhtar@samsung.com \
--cc=asahi@lists.linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox