From: "Krzysztof Wilczyński" <kw@linux.com>
To: Riyan Dhiman <riyandhiman14@gmail.com>
Cc: jim2101024@gmail.com, nsaenz@kernel.org,
lorian.fainelli@broadcom.com,
bcm-kernel-feedback-list@broadcom.com, bhelgaas@google.com,
linux-pci@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH next V2] PCI: brmstb: Fix type mismatch for num_inbound_wins in brcm_pcie_get_inbound_wins
Date: Sun, 8 Sep 2024 01:46:13 +0900 [thread overview]
Message-ID: <20240907164613.GA183432@rocinante> (raw)
In-Reply-To: <20240907160926.39556-1-riyandhiman14@gmail.com>
Hello,
> Change num_inbound_wins from u8 to int to correctly handle
> potential negative error codes returned by brcm_pcie_get_inbound_wins().
> The u8 type was inappropriate for capturing the function's return value,
> which can include error codes.
I squashed with the current code on the controller/brcmstb branch, see:
- https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?h=controller/brcmstb&id=ae6476c6de187bea90c729e3e0188143300fa671
And credited you via the Co-developed-by tag such that you get credit for
fixing this issue. Thank you, by the way.
There is no Fixes: tag as this code is not yet merged into the mainline.
Krzysztof
next prev parent reply other threads:[~2024-09-07 16:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-07 16:09 [PATCH next V2] PCI: brmstb: Fix type mismatch for num_inbound_wins in brcm_pcie_get_inbound_wins Riyan Dhiman
2024-09-07 16:46 ` Krzysztof Wilczyński [this message]
2024-09-07 16:56 ` Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240907164613.GA183432@rocinante \
--to=kw@linux.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=jim2101024@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=lorian.fainelli@broadcom.com \
--cc=nsaenz@kernel.org \
--cc=riyandhiman14@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox