From: Will Deacon <will@kernel.org>
To: Marc Zyngier <maz@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Anastasia Belova <abelova@astralinux.ru>,
Oliver Upton <oliver.upton@linux.dev>,
James Morse <james.morse@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Zenghui Yu <yuzenghui@huawei.com>,
linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev,
linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org,
stable@vger.kernel.org
Subject: Re: [PATCH v2] arm64: KVM: define ESR_ELx_EC_* constants as UL
Date: Tue, 10 Sep 2024 10:47:46 +0100 [thread overview]
Message-ID: <20240910094746.GA20813@willie-the-truck> (raw)
In-Reply-To: <86v7z37u5a.wl-maz@kernel.org>
On Tue, Sep 10, 2024 at 10:08:49AM +0100, Marc Zyngier wrote:
> On Tue, 10 Sep 2024 09:50:16 +0100,
> Anastasia Belova <abelova@astralinux.ru> wrote:
> >
> > Add explicit casting to prevent expantion of 32th bit of
> > u32 into highest half of u64 in several places.
> >
> > For example, in inject_abt64:
> > ESR_ELx_EC_DABT_LOW << ESR_ELx_EC_SHIFT = 0x24 << 26.
> > This operation's result is int with 1 in 32th bit.
> > While casting this value into u64 (esr is u64) 1
> > fills 32 highest bits.
> >
> > Found by Linux Verification Center (linuxtesting.org) with SVACE.
> >
> > Fixes: aa8eff9bfbd5 ("arm64: KVM: fault injection into a guest")
> > Signed-off-by: Anastasia Belova <abelova@astralinux.ru>
>
> nit: the subject line is misleading, as this doesn't only affect KVM,
> but the whole of the arm64 port (the exception classes form a generic
> architectural construct).
Weird, this v2 landed in my spam for some reason.
> This also probably deserve a Cc stable.
>
> Will, Catalin: I'm happy to queue this in the KVM tree, but if you are
> taking it directly:
>
> Acked-by: Marc Zyngier <maz@kernel.org>
I can take it via arm64. I assume it's ok to land in v6.12 (with the cc:
stable), or is there an urgency to landing this in v6.11? It looks it
was found using verification tools, rather than because of an actual
issue affecting users.
Will
next prev parent reply other threads:[~2024-09-10 9:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-09 10:38 [PATCH 0/2] arm64: KVM: prevent overflow in inject_abt64 Anastasia Belova
2024-09-09 10:38 ` [PATCH 1/2] " Anastasia Belova
2024-09-09 10:58 ` Marc Zyngier
2024-09-10 8:50 ` [PATCH v2] arm64: KVM: define ESR_ELx_EC_* constants as UL Anastasia Belova
2024-09-10 9:08 ` Marc Zyngier
2024-09-10 9:47 ` Will Deacon [this message]
2024-09-10 14:59 ` Marc Zyngier
2024-09-10 19:03 ` Will Deacon
2024-09-09 10:38 ` [PATCH 2/2] arm64: KVM: prevent overflow in inject_abt64 Anastasia Belova
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240910094746.GA20813@willie-the-truck \
--to=will@kernel.org \
--cc=abelova@astralinux.ru \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=maz@kernel.org \
--cc=oliver.upton@linux.dev \
--cc=stable@vger.kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox