* [PATCH] dt-bindings: net: can: atmel: Convert to json schema
@ 2024-09-12 5:49 Charan Pedumuru
2024-09-12 6:36 ` Conor Dooley
2024-09-12 7:35 ` Marc Kleine-Budde
0 siblings, 2 replies; 4+ messages in thread
From: Charan Pedumuru @ 2024-09-12 5:49 UTC (permalink / raw)
To: Marc Kleine-Budde, Vincent Mailhol, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Nicolas Ferre, Alexandre Belloni, Claudiu Beznea
Cc: linux-can, netdev, devicetree, linux-arm-kernel, linux-kernel,
Charan Pedumuru
Convert atmel-can documentation to yaml format
Signed-off-by: Charan Pedumuru <charan.pedumuru@microchip.com>
---
.../bindings/net/can/atmel,at91sam9263-can.yaml | 67 ++++++++++++++++++++++
.../devicetree/bindings/net/can/atmel-can.txt | 15 -----
2 files changed, 67 insertions(+), 15 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/can/atmel,at91sam9263-can.yaml b/Documentation/devicetree/bindings/net/can/atmel,at91sam9263-can.yaml
new file mode 100644
index 000000000000..269af4c993a7
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/can/atmel,at91sam9263-can.yaml
@@ -0,0 +1,67 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/can/atmel,at91sam9263-can.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Atmel CAN Controller
+
+maintainers:
+ - Nicolas Ferre <nicolas.ferre@microchip.com>
+
+properties:
+ compatible:
+ oneOf:
+ - enum:
+ - atmel,at91sam9263-can
+ - atmel,at91sam9x5-can
+ - microchip,sam9x60-can
+ - items:
+ - enum:
+ - microchip,sam9x60-can
+ - const: atmel,at91sam9x5-can
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+ clock-names:
+ items:
+ - const: can_clk
+
+required:
+ - compatible
+ - reg
+ - interrupts
+
+allOf:
+ - $ref: can-controller.yaml#
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - microchip,sam9x60-can
+ then:
+ required:
+ - compatible
+ - reg
+ - interrupts
+ - clocks
+ - clock-names
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+ can0: can@f000c000 {
+ compatible = "atmel,at91sam9x5-can";
+ reg = <0xf000c000 0x300>;
+ interrupts = <30 IRQ_TYPE_LEVEL_HIGH 3>;
+ };
diff --git a/Documentation/devicetree/bindings/net/can/atmel-can.txt b/Documentation/devicetree/bindings/net/can/atmel-can.txt
deleted file mode 100644
index 218a3b3eb27e..000000000000
--- a/Documentation/devicetree/bindings/net/can/atmel-can.txt
+++ /dev/null
@@ -1,15 +0,0 @@
-* AT91 CAN *
-
-Required properties:
- - compatible: Should be "atmel,at91sam9263-can", "atmel,at91sam9x5-can" or
- "microchip,sam9x60-can"
- - reg: Should contain CAN controller registers location and length
- - interrupts: Should contain IRQ line for the CAN controller
-
-Example:
-
- can0: can@f000c000 {
- compatible = "atmel,at91sam9x5-can";
- reg = <0xf000c000 0x300>;
- interrupts = <40 4 5>
- };
---
base-commit: 32ffa5373540a8d1c06619f52d019c6cdc948bb4
change-id: 20240912-can-8eb7f8e7566d
Best regards,
--
Charan Pedumuru <charan.pedumuru@microchip.com>
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: net: can: atmel: Convert to json schema
2024-09-12 5:49 [PATCH] dt-bindings: net: can: atmel: Convert to json schema Charan Pedumuru
@ 2024-09-12 6:36 ` Conor Dooley
2024-09-12 7:35 ` Marc Kleine-Budde
1 sibling, 0 replies; 4+ messages in thread
From: Conor Dooley @ 2024-09-12 6:36 UTC (permalink / raw)
To: Charan Pedumuru
Cc: Rob Herring, Conor Dooley, linux-kernel, Alexandre Belloni,
devicetree, netdev, linux-can, Claudiu Beznea, Eric Dumazet,
Marc Kleine-Budde, linux-arm-kernel, Jakub Kicinski,
Krzysztof Kozlowski, Paolo Abeni, David S. Miller,
Vincent Mailhol
[-- Attachment #1: Type: text/plain, Size: 3319 bytes --]
On Thu, Sep 12, 2024 at 11:19:16AM +0530, Charan Pedumuru wrote:
> Convert atmel-can documentation to yaml format
>
> Signed-off-by: Charan Pedumuru <charan.pedumuru@microchip.com>
Please see the comments I left on the internal v2 of this patch.
Thanks,
Conor.
> ---
> .../bindings/net/can/atmel,at91sam9263-can.yaml | 67 ++++++++++++++++++++++
> .../devicetree/bindings/net/can/atmel-can.txt | 15 -----
> 2 files changed, 67 insertions(+), 15 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/can/atmel,at91sam9263-can.yaml b/Documentation/devicetree/bindings/net/can/atmel,at91sam9263-can.yaml
> new file mode 100644
> index 000000000000..269af4c993a7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/can/atmel,at91sam9263-can.yaml
> @@ -0,0 +1,67 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/can/atmel,at91sam9263-can.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Atmel CAN Controller
> +
> +maintainers:
> + - Nicolas Ferre <nicolas.ferre@microchip.com>
> +
> +properties:
> + compatible:
> + oneOf:
> + - enum:
> + - atmel,at91sam9263-can
> + - atmel,at91sam9x5-can
> + - microchip,sam9x60-can
> + - items:
> + - enum:
> + - microchip,sam9x60-can
> + - const: atmel,at91sam9x5-can
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + clock-names:
> + items:
> + - const: can_clk
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> +
> +allOf:
> + - $ref: can-controller.yaml#
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - microchip,sam9x60-can
> + then:
> + required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - clock-names
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + can0: can@f000c000 {
> + compatible = "atmel,at91sam9x5-can";
> + reg = <0xf000c000 0x300>;
> + interrupts = <30 IRQ_TYPE_LEVEL_HIGH 3>;
> + };
> diff --git a/Documentation/devicetree/bindings/net/can/atmel-can.txt b/Documentation/devicetree/bindings/net/can/atmel-can.txt
> deleted file mode 100644
> index 218a3b3eb27e..000000000000
> --- a/Documentation/devicetree/bindings/net/can/atmel-can.txt
> +++ /dev/null
> @@ -1,15 +0,0 @@
> -* AT91 CAN *
> -
> -Required properties:
> - - compatible: Should be "atmel,at91sam9263-can", "atmel,at91sam9x5-can" or
> - "microchip,sam9x60-can"
> - - reg: Should contain CAN controller registers location and length
> - - interrupts: Should contain IRQ line for the CAN controller
> -
> -Example:
> -
> - can0: can@f000c000 {
> - compatible = "atmel,at91sam9x5-can";
> - reg = <0xf000c000 0x300>;
> - interrupts = <40 4 5>
> - };
>
> ---
> base-commit: 32ffa5373540a8d1c06619f52d019c6cdc948bb4
> change-id: 20240912-can-8eb7f8e7566d
>
> Best regards,
> --
> Charan Pedumuru <charan.pedumuru@microchip.com>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: net: can: atmel: Convert to json schema
2024-09-12 5:49 [PATCH] dt-bindings: net: can: atmel: Convert to json schema Charan Pedumuru
2024-09-12 6:36 ` Conor Dooley
@ 2024-09-12 7:35 ` Marc Kleine-Budde
[not found] ` <d9987295-74eb-4795-8517-379249cd7626@microchip.com>
1 sibling, 1 reply; 4+ messages in thread
From: Marc Kleine-Budde @ 2024-09-12 7:35 UTC (permalink / raw)
To: Charan Pedumuru
Cc: Rob Herring, Conor Dooley, linux-kernel, Alexandre Belloni,
devicetree, netdev, linux-can, Claudiu Beznea, Eric Dumazet,
linux-arm-kernel, Jakub Kicinski, Krzysztof Kozlowski,
Paolo Abeni, David S. Miller, Vincent Mailhol
[-- Attachment #1: Type: text/plain, Size: 3670 bytes --]
On 12.09.2024 11:19:16, Charan Pedumuru wrote:
> Convert atmel-can documentation to yaml format
>
> Signed-off-by: Charan Pedumuru <charan.pedumuru@microchip.com>
> ---
> .../bindings/net/can/atmel,at91sam9263-can.yaml | 67 ++++++++++++++++++++++
> .../devicetree/bindings/net/can/atmel-can.txt | 15 -----
> 2 files changed, 67 insertions(+), 15 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/can/atmel,at91sam9263-can.yaml b/Documentation/devicetree/bindings/net/can/atmel,at91sam9263-can.yaml
> new file mode 100644
> index 000000000000..269af4c993a7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/can/atmel,at91sam9263-can.yaml
> @@ -0,0 +1,67 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/can/atmel,at91sam9263-can.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Atmel CAN Controller
> +
> +maintainers:
> + - Nicolas Ferre <nicolas.ferre@microchip.com>
> +
> +properties:
> + compatible:
> + oneOf:
> + - enum:
> + - atmel,at91sam9263-can
> + - atmel,at91sam9x5-can
> + - microchip,sam9x60-can
The driver doesn't have a compatible for "microchip,sam9x60-can".
> + - items:
> + - enum:
> + - microchip,sam9x60-can
> + - const: atmel,at91sam9x5-can
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + clock-names:
> + items:
> + - const: can_clk
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> +
> +allOf:
> + - $ref: can-controller.yaml#
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - microchip,sam9x60-can
> + then:
> + required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - clock-names
AFAICS clock-names is required for all compatibles.
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + can0: can@f000c000 {
I think unused labels should be removed.
> + compatible = "atmel,at91sam9x5-can";
> + reg = <0xf000c000 0x300>;
> + interrupts = <30 IRQ_TYPE_LEVEL_HIGH 3>;
> + };
> diff --git a/Documentation/devicetree/bindings/net/can/atmel-can.txt b/Documentation/devicetree/bindings/net/can/atmel-can.txt
> deleted file mode 100644
> index 218a3b3eb27e..000000000000
> --- a/Documentation/devicetree/bindings/net/can/atmel-can.txt
> +++ /dev/null
> @@ -1,15 +0,0 @@
> -* AT91 CAN *
> -
> -Required properties:
> - - compatible: Should be "atmel,at91sam9263-can", "atmel,at91sam9x5-can" or
> - "microchip,sam9x60-can"
> - - reg: Should contain CAN controller registers location and length
> - - interrupts: Should contain IRQ line for the CAN controller
> -
> -Example:
> -
> - can0: can@f000c000 {
> - compatible = "atmel,at91sam9x5-can";
> - reg = <0xf000c000 0x300>;
> - interrupts = <40 4 5>
> - };
>
> ---
> base-commit: 32ffa5373540a8d1c06619f52d019c6cdc948bb4
> change-id: 20240912-can-8eb7f8e7566d
>
> Best regards,
> --
> Charan Pedumuru <charan.pedumuru@microchip.com>
>
>
>
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: net: can: atmel: Convert to json schema
[not found] ` <d9987295-74eb-4795-8517-379249cd7626@microchip.com>
@ 2024-09-23 10:57 ` Marc Kleine-Budde
0 siblings, 0 replies; 4+ messages in thread
From: Marc Kleine-Budde @ 2024-09-23 10:57 UTC (permalink / raw)
To: Charan.Pedumuru
Cc: robh, conor+dt, linux-kernel, alexandre.belloni, devicetree,
netdev, linux-can, claudiu.beznea, edumazet, linux-arm-kernel,
kuba, krzk+dt, pabeni, davem, mailhol.vincent
[-- Attachment #1: Type: text/plain, Size: 939 bytes --]
On 20.09.2024 04:51:57, Charan.Pedumuru@microchip.com wrote:
> >> +allOf:
> >> + - $ref: can-controller.yaml#
> >> + - if:
> >> + properties:
> >> + compatible:
> >> + contains:
> >> + enum:
> >> + - microchip,sam9x60-can
> >> + then:
> >> + required:
> >> + - compatible
> >> + - reg
> >> + - interrupts
> >> + - clocks
> >> + - clock-names
> > AFAICS clock-names is required for all compatibles.
> In our case only sam9x60 is using clock-names property.
No, the driver uses "clk_get(&pdev->dev, "can_clk")", so this property
is mandatory.
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-09-23 10:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-12 5:49 [PATCH] dt-bindings: net: can: atmel: Convert to json schema Charan Pedumuru
2024-09-12 6:36 ` Conor Dooley
2024-09-12 7:35 ` Marc Kleine-Budde
[not found] ` <d9987295-74eb-4795-8517-379249cd7626@microchip.com>
2024-09-23 10:57 ` Marc Kleine-Budde
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox