* [PATCH] dt-bindings: phy: mediatek: tphy: add a property for power-domains @ 2024-09-26 10:18 Macpaul Lin 2024-09-26 10:20 ` AngeloGioacchino Del Regno 2024-09-26 16:25 ` Conor Dooley 0 siblings, 2 replies; 6+ messages in thread From: Macpaul Lin @ 2024-09-26 10:18 UTC (permalink / raw) To: Chunfeng Yun, Vinod Koul, Kishon Vijay Abraham I, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno, linux-arm-kernel, linux-mediatek, linux-phy, devicetree, linux-kernel, Alexandre Mergnat Cc: Bear Wang, Pablo Sun, Macpaul Lin, Macpaul Lin, Sen Chu, Chris-qj chen, MediaTek Chromebook Upstream, Chen-Yu Tsai Some platforms requires a dependency for power-domains. So we add property 'power-domains' and set 'maxItems: 1' in the DT Schema. Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com> --- Documentation/devicetree/bindings/phy/mediatek,tphy.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml index 423b7c4e62f2..c77fe43c224a 100644 --- a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml +++ b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml @@ -125,6 +125,9 @@ properties: $ref: /schemas/types.yaml#/definitions/uint32 default: 28 + power-domains: + maxItems: 1 + # Required child node: patternProperties: "^(usb|pcie|sata)-phy@[0-9a-f]+$": -- 2.45.2 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: phy: mediatek: tphy: add a property for power-domains 2024-09-26 10:18 [PATCH] dt-bindings: phy: mediatek: tphy: add a property for power-domains Macpaul Lin @ 2024-09-26 10:20 ` AngeloGioacchino Del Regno 2024-09-26 16:25 ` Conor Dooley 1 sibling, 0 replies; 6+ messages in thread From: AngeloGioacchino Del Regno @ 2024-09-26 10:20 UTC (permalink / raw) To: Macpaul Lin, Chunfeng Yun, Vinod Koul, Kishon Vijay Abraham I, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger, linux-arm-kernel, linux-mediatek, linux-phy, devicetree, linux-kernel, Alexandre Mergnat Cc: Bear Wang, Pablo Sun, Macpaul Lin, Sen Chu, Chris-qj chen, MediaTek Chromebook Upstream, Chen-Yu Tsai Il 26/09/24 12:18, Macpaul Lin ha scritto: > Some platforms requires a dependency for power-domains. > So we add property 'power-domains' and set 'maxItems: 1' in the > DT Schema. > > Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: phy: mediatek: tphy: add a property for power-domains 2024-09-26 10:18 [PATCH] dt-bindings: phy: mediatek: tphy: add a property for power-domains Macpaul Lin 2024-09-26 10:20 ` AngeloGioacchino Del Regno @ 2024-09-26 16:25 ` Conor Dooley 2024-10-08 4:03 ` Macpaul Lin 1 sibling, 1 reply; 6+ messages in thread From: Conor Dooley @ 2024-09-26 16:25 UTC (permalink / raw) To: Macpaul Lin Cc: Chunfeng Yun, Vinod Koul, Kishon Vijay Abraham I, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno, linux-arm-kernel, linux-mediatek, linux-phy, devicetree, linux-kernel, Alexandre Mergnat, Bear Wang, Pablo Sun, Macpaul Lin, Sen Chu, Chris-qj chen, MediaTek Chromebook Upstream, Chen-Yu Tsai [-- Attachment #1: Type: text/plain, Size: 1034 bytes --] On Thu, Sep 26, 2024 at 06:18:04PM +0800, Macpaul Lin wrote: > Some platforms requires a dependency for power-domains. Some, so not all? Why isn't this restricted on a per compatible basis? > So we add property 'power-domains' and set 'maxItems: 1' in the > DT Schema. > > Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com> > --- > Documentation/devicetree/bindings/phy/mediatek,tphy.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml > index 423b7c4e62f2..c77fe43c224a 100644 > --- a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml > +++ b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml > @@ -125,6 +125,9 @@ properties: > $ref: /schemas/types.yaml#/definitions/uint32 > default: 28 > > + power-domains: > + maxItems: 1 > + > # Required child node: > patternProperties: > "^(usb|pcie|sata)-phy@[0-9a-f]+$": > -- > 2.45.2 > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: phy: mediatek: tphy: add a property for power-domains 2024-09-26 16:25 ` Conor Dooley @ 2024-10-08 4:03 ` Macpaul Lin 2024-10-08 16:31 ` Conor Dooley 0 siblings, 1 reply; 6+ messages in thread From: Macpaul Lin @ 2024-10-08 4:03 UTC (permalink / raw) To: Conor Dooley, Jason-ch Chen, AngeloGioacchino Del Regno, Chunfeng Yun Cc: Chunfeng Yun, Vinod Koul, Kishon Vijay Abraham I, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno, linux-arm-kernel, linux-mediatek, linux-phy, devicetree, linux-kernel, Alexandre Mergnat, Bear Wang, Pablo Sun, Macpaul Lin, Sen Chu, Chris-qj chen, MediaTek Chromebook Upstream, Chen-Yu Tsai On 9/27/24 00:25, Conor Dooley wrote: > On Thu, Sep 26, 2024 at 06:18:04PM +0800, Macpaul Lin wrote: >> Some platforms requires a dependency for power-domains. > > Some, so not all? Why isn't this restricted on a per compatible basis? After discussion with Chunfeng and double check tphy design in detail. Chunfeng commented that tphy dose not need to add mtcmos. It is not necessary to add it, if the power of the phy is turned off, it will affect other functions. From the current USB hardware design perspective, even if mtcmos is added to the phy, it is always on. >> So we add property 'power-domains' and set 'maxItems: 1' in the >> DT Schema. >> >> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com> >> --- >> Documentation/devicetree/bindings/phy/mediatek,tphy.yaml | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml >> index 423b7c4e62f2..c77fe43c224a 100644 >> --- a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml >> +++ b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml >> @@ -125,6 +125,9 @@ properties: >> $ref: /schemas/types.yaml#/definitions/uint32 >> default: 28 >> >> + power-domains: >> + maxItems: 1 >> + >> # Required child node: >> patternProperties: >> "^(usb|pcie|sata)-phy@[0-9a-f]+$": >> -- >> 2.45.2 >> Please drop this patch and I'll send a new fix to mt8195.dtsi. Thanks Macpaul Lin ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: phy: mediatek: tphy: add a property for power-domains 2024-10-08 4:03 ` Macpaul Lin @ 2024-10-08 16:31 ` Conor Dooley 2024-10-11 6:56 ` Macpaul Lin 0 siblings, 1 reply; 6+ messages in thread From: Conor Dooley @ 2024-10-08 16:31 UTC (permalink / raw) To: Macpaul Lin Cc: Jason-ch Chen, AngeloGioacchino Del Regno, Chunfeng Yun, Vinod Koul, Kishon Vijay Abraham I, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger, linux-arm-kernel, linux-mediatek, linux-phy, devicetree, linux-kernel, Alexandre Mergnat, Bear Wang, Pablo Sun, Macpaul Lin, Sen Chu, Chris-qj chen, MediaTek Chromebook Upstream, Chen-Yu Tsai [-- Attachment #1: Type: text/plain, Size: 2113 bytes --] On Tue, Oct 08, 2024 at 12:03:37PM +0800, Macpaul Lin wrote: > > > On 9/27/24 00:25, Conor Dooley wrote: > > On Thu, Sep 26, 2024 at 06:18:04PM +0800, Macpaul Lin wrote: > > > Some platforms requires a dependency for power-domains. > > > > Some, so not all? Why isn't this restricted on a per compatible basis? > > After discussion with Chunfeng and double check tphy design in detail. > Chunfeng commented that tphy dose not need to add mtcmos. > It is not necessary to add it, if the power of the phy is turned off, > it will affect other functions. > > From the current USB hardware design perspective, even if mtcmos > is added to the phy, it is always on. Firstly, I have no idea what "mtcmos" means, sorry. I am a dt-bindings guy, not someone familiar with mediatek hardware. Secondly, it sounds like this /does/ have a power domain, so it should be in the binding. That it is turned on by something else and must remain on doesn't mean it shouldn't be documented here. What if those things try to turn it off while the tphy is using it? > > > > So we add property 'power-domains' and set 'maxItems: 1' in the > > > DT Schema. > > > > > > Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com> > > > --- > > > Documentation/devicetree/bindings/phy/mediatek,tphy.yaml | 3 +++ > > > 1 file changed, 3 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml > > > index 423b7c4e62f2..c77fe43c224a 100644 > > > --- a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml > > > +++ b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml > > > @@ -125,6 +125,9 @@ properties: > > > $ref: /schemas/types.yaml#/definitions/uint32 > > > default: 28 > > > + power-domains: > > > + maxItems: 1 > > > + > > > # Required child node: > > > patternProperties: > > > "^(usb|pcie|sata)-phy@[0-9a-f]+$": > > > -- > > > 2.45.2 > > > > > Please drop this patch and I'll send a new fix to mt8195.dtsi. > > Thanks > Macpaul Lin [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: phy: mediatek: tphy: add a property for power-domains 2024-10-08 16:31 ` Conor Dooley @ 2024-10-11 6:56 ` Macpaul Lin 0 siblings, 0 replies; 6+ messages in thread From: Macpaul Lin @ 2024-10-11 6:56 UTC (permalink / raw) To: Conor Dooley Cc: Jason-ch Chen, AngeloGioacchino Del Regno, Chunfeng Yun, Vinod Koul, Kishon Vijay Abraham I, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger, linux-arm-kernel, linux-mediatek, linux-phy, devicetree, linux-kernel, Alexandre Mergnat, Bear Wang, Pablo Sun, Macpaul Lin, Sen Chu, Chris-qj chen, MediaTek Chromebook Upstream, Chen-Yu Tsai On 10/9/24 00:31, Conor Dooley wrote: > On Tue, Oct 08, 2024 at 12:03:37PM +0800, Macpaul Lin wrote: >> >> >> On 9/27/24 00:25, Conor Dooley wrote: >>> On Thu, Sep 26, 2024 at 06:18:04PM +0800, Macpaul Lin wrote: >>>> Some platforms requires a dependency for power-domains. >>> >>> Some, so not all? Why isn't this restricted on a per compatible basis? >> >> After discussion with Chunfeng and double check tphy design in detail. >> Chunfeng commented that tphy dose not need to add mtcmos. >> It is not necessary to add it, if the power of the phy is turned off, >> it will affect other functions. >> >> From the current USB hardware design perspective, even if mtcmos >> is added to the phy, it is always on. > > Firstly, I have no idea what "mtcmos" means, sorry. I am a dt-bindings > guy, not someone familiar with mediatek hardware. > Secondly, it sounds like this /does/ have a power domain, so it should > be in the binding. That it is turned on by something else and must > remain on doesn't mean it shouldn't be documented here. What if those > things try to turn it off while the tphy is using it? After discussion in MediaTek internal. Chunfeng agreed to add 'power-domains' property to DT schema. The v2 patch will also adding the reminder in the description for developers. >> >>>> So we add property 'power-domains' and set 'maxItems: 1' in the >>>> DT Schema. >>>> >>>> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com> >>>> --- >>>> Documentation/devicetree/bindings/phy/mediatek,tphy.yaml | 3 +++ >>>> 1 file changed, 3 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml >>>> index 423b7c4e62f2..c77fe43c224a 100644 >>>> --- a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml >>>> +++ b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml >>>> @@ -125,6 +125,9 @@ properties: >>>> $ref: /schemas/types.yaml#/definitions/uint32 >>>> default: 28 >>>> + power-domains: >>>> + maxItems: 1 >>>> + >>>> # Required child node: >>>> patternProperties: >>>> "^(usb|pcie|sata)-phy@[0-9a-f]+$": >>>> -- >>>> 2.45.2 >>>> >> [snip] V2 of this patch has been send. Thanks Macpaul Lin. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-10-11 7:06 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-09-26 10:18 [PATCH] dt-bindings: phy: mediatek: tphy: add a property for power-domains Macpaul Lin 2024-09-26 10:20 ` AngeloGioacchino Del Regno 2024-09-26 16:25 ` Conor Dooley 2024-10-08 4:03 ` Macpaul Lin 2024-10-08 16:31 ` Conor Dooley 2024-10-11 6:56 ` Macpaul Lin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox