* [PATCH][next] thermal/drivers/mediatek/lvts_thermal: make read-only arrays static const
@ 2024-10-22 18:46 Colin Ian King
2024-10-22 20:08 ` Nicolas Pitre
2024-10-28 16:40 ` Daniel Lezcano
0 siblings, 2 replies; 3+ messages in thread
From: Colin Ian King @ 2024-10-22 18:46 UTC (permalink / raw)
To: Rafael J . Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba,
Matthias Brugger, AngeloGioacchino Del Regno, Nicolas Pitre,
linux-pm, linux-kernel, linux-arm-kernel
Cc: kernel-janitors, linux-mediatek
Don't populate the read-only arrays on the stack at run time, instead
make them static const.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/thermal/mediatek/lvts_thermal.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/mediatek/lvts_thermal.c
index 1997e91bb3be..ce223bab6b55 100644
--- a/drivers/thermal/mediatek/lvts_thermal.c
+++ b/drivers/thermal/mediatek/lvts_thermal.c
@@ -329,7 +329,7 @@ static int lvts_get_temp(struct thermal_zone_device *tz, int *temp)
static void lvts_update_irq_mask(struct lvts_ctrl *lvts_ctrl)
{
- u32 masks[] = {
+ static const u32 masks[] = {
LVTS_MONINT_OFFSET_SENSOR0,
LVTS_MONINT_OFFSET_SENSOR1,
LVTS_MONINT_OFFSET_SENSOR2,
@@ -424,7 +424,7 @@ static irqreturn_t lvts_ctrl_irq_handler(struct lvts_ctrl *lvts_ctrl)
{
irqreturn_t iret = IRQ_NONE;
u32 value;
- u32 masks[] = {
+ static const u32 masks[] = {
LVTS_INT_SENSOR0,
LVTS_INT_SENSOR1,
LVTS_INT_SENSOR2,
--
2.39.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH][next] thermal/drivers/mediatek/lvts_thermal: make read-only arrays static const
2024-10-22 18:46 [PATCH][next] thermal/drivers/mediatek/lvts_thermal: make read-only arrays static const Colin Ian King
@ 2024-10-22 20:08 ` Nicolas Pitre
2024-10-28 16:40 ` Daniel Lezcano
1 sibling, 0 replies; 3+ messages in thread
From: Nicolas Pitre @ 2024-10-22 20:08 UTC (permalink / raw)
To: Colin Ian King
Cc: Rafael J . Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba,
Matthias Brugger, AngeloGioacchino Del Regno, linux-pm,
linux-kernel, linux-arm-kernel, kernel-janitors, linux-mediatek
On Tue, 22 Oct 2024, Colin Ian King wrote:
> Don't populate the read-only arrays on the stack at run time, instead
> make them static const.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: Nicolas Pitre <npitre@baylibre.com>
> ---
> drivers/thermal/mediatek/lvts_thermal.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/mediatek/lvts_thermal.c
> index 1997e91bb3be..ce223bab6b55 100644
> --- a/drivers/thermal/mediatek/lvts_thermal.c
> +++ b/drivers/thermal/mediatek/lvts_thermal.c
> @@ -329,7 +329,7 @@ static int lvts_get_temp(struct thermal_zone_device *tz, int *temp)
>
> static void lvts_update_irq_mask(struct lvts_ctrl *lvts_ctrl)
> {
> - u32 masks[] = {
> + static const u32 masks[] = {
> LVTS_MONINT_OFFSET_SENSOR0,
> LVTS_MONINT_OFFSET_SENSOR1,
> LVTS_MONINT_OFFSET_SENSOR2,
> @@ -424,7 +424,7 @@ static irqreturn_t lvts_ctrl_irq_handler(struct lvts_ctrl *lvts_ctrl)
> {
> irqreturn_t iret = IRQ_NONE;
> u32 value;
> - u32 masks[] = {
> + static const u32 masks[] = {
> LVTS_INT_SENSOR0,
> LVTS_INT_SENSOR1,
> LVTS_INT_SENSOR2,
> --
> 2.39.5
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH][next] thermal/drivers/mediatek/lvts_thermal: make read-only arrays static const
2024-10-22 18:46 [PATCH][next] thermal/drivers/mediatek/lvts_thermal: make read-only arrays static const Colin Ian King
2024-10-22 20:08 ` Nicolas Pitre
@ 2024-10-28 16:40 ` Daniel Lezcano
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Lezcano @ 2024-10-28 16:40 UTC (permalink / raw)
To: Colin Ian King, Rafael J . Wysocki, Zhang Rui, Lukasz Luba,
Matthias Brugger, AngeloGioacchino Del Regno, Nicolas Pitre,
linux-pm, linux-kernel, linux-arm-kernel
Cc: kernel-janitors, linux-mediatek
On 22/10/2024 20:46, Colin Ian King wrote:
> Don't populate the read-only arrays on the stack at run time, instead
> make them static const.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
Applied, thanks
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-28 16:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-22 18:46 [PATCH][next] thermal/drivers/mediatek/lvts_thermal: make read-only arrays static const Colin Ian King
2024-10-22 20:08 ` Nicolas Pitre
2024-10-28 16:40 ` Daniel Lezcano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox