* [PATCH] drm: xlnx: zynqmp_dpsub: fix hotplug detection
@ 2024-10-21 13:41 Steffen Dirkwinkel
2024-10-23 10:47 ` Tomi Valkeinen
0 siblings, 1 reply; 5+ messages in thread
From: Steffen Dirkwinkel @ 2024-10-21 13:41 UTC (permalink / raw)
To: dri-devel, Laurent Pinchart
Cc: Dmitry Baryshkov, Steffen Dirkwinkel, Tomi Valkeinen,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Michal Simek, linux-arm-kernel, linux-kernel
From: Steffen Dirkwinkel <s.dirkwinkel@beckhoff.com>
drm_kms_helper_poll_init needs to be called after zynqmp_dpsub_kms_init.
zynqmp_dpsub_kms_init creates the connector and without it we don't
enable hotplug detection.
Signed-off-by: Steffen Dirkwinkel <s.dirkwinkel@beckhoff.com>
---
drivers/gpu/drm/xlnx/zynqmp_kms.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/xlnx/zynqmp_kms.c b/drivers/gpu/drm/xlnx/zynqmp_kms.c
index bd1368df7870..311397cee5ca 100644
--- a/drivers/gpu/drm/xlnx/zynqmp_kms.c
+++ b/drivers/gpu/drm/xlnx/zynqmp_kms.c
@@ -509,12 +509,12 @@ int zynqmp_dpsub_drm_init(struct zynqmp_dpsub *dpsub)
if (ret)
return ret;
- drm_kms_helper_poll_init(drm);
-
ret = zynqmp_dpsub_kms_init(dpsub);
if (ret < 0)
goto err_poll_fini;
+ drm_kms_helper_poll_init(drm);
+
/* Reset all components and register the DRM device. */
drm_mode_config_reset(drm);
--
2.47.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drm: xlnx: zynqmp_dpsub: fix hotplug detection
2024-10-21 13:41 [PATCH] drm: xlnx: zynqmp_dpsub: fix hotplug detection Steffen Dirkwinkel
@ 2024-10-23 10:47 ` Tomi Valkeinen
2024-10-28 13:31 ` [PATCH v2] " Steffen Dirkwinkel
2024-10-28 13:42 ` Steffen Dirkwinkel
0 siblings, 2 replies; 5+ messages in thread
From: Tomi Valkeinen @ 2024-10-23 10:47 UTC (permalink / raw)
To: Steffen Dirkwinkel, dri-devel, Laurent Pinchart
Cc: Dmitry Baryshkov, Steffen Dirkwinkel, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Michal Simek, linux-arm-kernel, linux-kernel
On 21/10/2024 16:41, Steffen Dirkwinkel wrote:
> From: Steffen Dirkwinkel <s.dirkwinkel@beckhoff.com>
>
> drm_kms_helper_poll_init needs to be called after zynqmp_dpsub_kms_init.
> zynqmp_dpsub_kms_init creates the connector and without it we don't
> enable hotplug detection.
>
> Signed-off-by: Steffen Dirkwinkel <s.dirkwinkel@beckhoff.com>
> ---
> drivers/gpu/drm/xlnx/zynqmp_kms.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_kms.c b/drivers/gpu/drm/xlnx/zynqmp_kms.c
> index bd1368df7870..311397cee5ca 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_kms.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_kms.c
> @@ -509,12 +509,12 @@ int zynqmp_dpsub_drm_init(struct zynqmp_dpsub *dpsub)
> if (ret)
> return ret;
>
> - drm_kms_helper_poll_init(drm);
> -
> ret = zynqmp_dpsub_kms_init(dpsub);
> if (ret < 0)
> goto err_poll_fini;
>
> + drm_kms_helper_poll_init(drm);
> +
> /* Reset all components and register the DRM device. */
> drm_mode_config_reset(drm);
>
Thanks, this indeed fixes the HPD issue.
But shouldn't this have a Fixes tag, and cc stable?
Tomi
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] drm: xlnx: zynqmp_dpsub: fix hotplug detection
2024-10-23 10:47 ` Tomi Valkeinen
@ 2024-10-28 13:31 ` Steffen Dirkwinkel
2024-10-28 13:42 ` Steffen Dirkwinkel
1 sibling, 0 replies; 5+ messages in thread
From: Steffen Dirkwinkel @ 2024-10-28 13:31 UTC (permalink / raw)
To: dri-devel, Laurent Pinchart, Tomi Valkeinen
Cc: Dmitry Baryshkov, stable, Steffen Dirkwinkel, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Michal Simek, linux-arm-kernel, linux-kernel
From: Steffen Dirkwinkel <s.dirkwinkel@beckhoff.com>
drm_kms_helper_poll_init needs to be called after zynqmp_dpsub_kms_init.
zynqmp_dpsub_kms_init creates the connector and without it we don't
enable hotplug detection.
Fixes: eb2d64bfcc17 ("drm: xlnx: zynqmp_dpsub: Report HPD through the bridge")
Signed-off-by: Steffen Dirkwinkel <s.dirkwinkel@beckhoff.com>
---
drivers/gpu/drm/xlnx/zynqmp_kms.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/xlnx/zynqmp_kms.c b/drivers/gpu/drm/xlnx/zynqmp_kms.c
index bd1368df7870..311397cee5ca 100644
--- a/drivers/gpu/drm/xlnx/zynqmp_kms.c
+++ b/drivers/gpu/drm/xlnx/zynqmp_kms.c
@@ -509,12 +509,12 @@ int zynqmp_dpsub_drm_init(struct zynqmp_dpsub *dpsub)
if (ret)
return ret;
- drm_kms_helper_poll_init(drm);
-
ret = zynqmp_dpsub_kms_init(dpsub);
if (ret < 0)
goto err_poll_fini;
+ drm_kms_helper_poll_init(drm);
+
/* Reset all components and register the DRM device. */
drm_mode_config_reset(drm);
--
2.47.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH v2] drm: xlnx: zynqmp_dpsub: fix hotplug detection
2024-10-23 10:47 ` Tomi Valkeinen
2024-10-28 13:31 ` [PATCH v2] " Steffen Dirkwinkel
@ 2024-10-28 13:42 ` Steffen Dirkwinkel
2024-10-30 12:26 ` Tomi Valkeinen
1 sibling, 1 reply; 5+ messages in thread
From: Steffen Dirkwinkel @ 2024-10-28 13:42 UTC (permalink / raw)
To: dri-devel, Laurent Pinchart, Tomi Valkeinen
Cc: Dmitry Baryshkov, stable, Steffen Dirkwinkel, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Michal Simek, linux-arm-kernel, linux-kernel
From: Steffen Dirkwinkel <s.dirkwinkel@beckhoff.com>
drm_kms_helper_poll_init needs to be called after zynqmp_dpsub_kms_init.
zynqmp_dpsub_kms_init creates the connector and without it we don't
enable hotplug detection.
Fixes: eb2d64bfcc17 ("drm: xlnx: zynqmp_dpsub: Report HPD through the bridge")
Cc: stable@vger.kernel.org
Signed-off-by: Steffen Dirkwinkel <s.dirkwinkel@beckhoff.com>
---
drivers/gpu/drm/xlnx/zynqmp_kms.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/xlnx/zynqmp_kms.c b/drivers/gpu/drm/xlnx/zynqmp_kms.c
index bd1368df7870..311397cee5ca 100644
--- a/drivers/gpu/drm/xlnx/zynqmp_kms.c
+++ b/drivers/gpu/drm/xlnx/zynqmp_kms.c
@@ -509,12 +509,12 @@ int zynqmp_dpsub_drm_init(struct zynqmp_dpsub *dpsub)
if (ret)
return ret;
- drm_kms_helper_poll_init(drm);
-
ret = zynqmp_dpsub_kms_init(dpsub);
if (ret < 0)
goto err_poll_fini;
+ drm_kms_helper_poll_init(drm);
+
/* Reset all components and register the DRM device. */
drm_mode_config_reset(drm);
--
2.47.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2] drm: xlnx: zynqmp_dpsub: fix hotplug detection
2024-10-28 13:42 ` Steffen Dirkwinkel
@ 2024-10-30 12:26 ` Tomi Valkeinen
0 siblings, 0 replies; 5+ messages in thread
From: Tomi Valkeinen @ 2024-10-30 12:26 UTC (permalink / raw)
To: Steffen Dirkwinkel, dri-devel, Laurent Pinchart
Cc: Dmitry Baryshkov, stable, Steffen Dirkwinkel, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Michal Simek, linux-arm-kernel, linux-kernel
Hi,
On 28/10/2024 15:42, Steffen Dirkwinkel wrote:
> From: Steffen Dirkwinkel <s.dirkwinkel@beckhoff.com>
>
> drm_kms_helper_poll_init needs to be called after zynqmp_dpsub_kms_init.
> zynqmp_dpsub_kms_init creates the connector and without it we don't
> enable hotplug detection.
>
> Fixes: eb2d64bfcc17 ("drm: xlnx: zynqmp_dpsub: Report HPD through the bridge")
> Cc: stable@vger.kernel.org
> Signed-off-by: Steffen Dirkwinkel <s.dirkwinkel@beckhoff.com>
> ---
> drivers/gpu/drm/xlnx/zynqmp_kms.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_kms.c b/drivers/gpu/drm/xlnx/zynqmp_kms.c
> index bd1368df7870..311397cee5ca 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_kms.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_kms.c
> @@ -509,12 +509,12 @@ int zynqmp_dpsub_drm_init(struct zynqmp_dpsub *dpsub)
> if (ret)
> return ret;
>
> - drm_kms_helper_poll_init(drm);
> -
> ret = zynqmp_dpsub_kms_init(dpsub);
> if (ret < 0)
> goto err_poll_fini;
>
> + drm_kms_helper_poll_init(drm);
> +
> /* Reset all components and register the DRM device. */
> drm_mode_config_reset(drm);
>
Thanks, will apply to drm-misc-next.
Btw, don't send a fixed version with the same version number as the last
one. Tools get confused...
Tomi
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-10-30 12:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-21 13:41 [PATCH] drm: xlnx: zynqmp_dpsub: fix hotplug detection Steffen Dirkwinkel
2024-10-23 10:47 ` Tomi Valkeinen
2024-10-28 13:31 ` [PATCH v2] " Steffen Dirkwinkel
2024-10-28 13:42 ` Steffen Dirkwinkel
2024-10-30 12:26 ` Tomi Valkeinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox