* [PATCH 1/2] scsi: ufs: exynos: remove empty drv_init method
@ 2024-10-30 10:27 Tudor Ambarus
2024-10-30 10:27 ` [PATCH 2/2] scsi: ufs: exynos: remove superfluous function parameter Tudor Ambarus
2024-11-12 7:53 ` [PATCH 1/2] scsi: ufs: exynos: remove empty drv_init method Manivannan Sadhasivam
0 siblings, 2 replies; 4+ messages in thread
From: Tudor Ambarus @ 2024-10-30 10:27 UTC (permalink / raw)
To: alim.akhtar, James.Bottomley, martin.petersen
Cc: krzk, linux-scsi, linux-arm-kernel, linux-samsung-soc,
linux-kernel, andre.draszik, kernel-team, willmcvicker,
Tudor Ambarus
Remove empty method. When the method is not set, the call is not made,
saving a few cycles.
Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
---
drivers/ufs/host/ufs-exynos.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/ufs/host/ufs-exynos.c b/drivers/ufs/host/ufs-exynos.c
index 9ec318ef52bf..db89ebe48bcd 100644
--- a/drivers/ufs/host/ufs-exynos.c
+++ b/drivers/ufs/host/ufs-exynos.c
@@ -198,11 +198,6 @@ static inline void exynos_ufs_ungate_clks(struct exynos_ufs *ufs)
exynos_ufs_ctrl_clkstop(ufs, false);
}
-static int exynos7_ufs_drv_init(struct device *dev, struct exynos_ufs *ufs)
-{
- return 0;
-}
-
static int exynosauto_ufs_drv_init(struct device *dev, struct exynos_ufs *ufs)
{
struct exynos_ufs_uic_attr *attr = ufs->drv_data->uic_attr;
@@ -2036,7 +2031,6 @@ static const struct exynos_ufs_drv_data exynos_ufs_drvs = {
EXYNOS_UFS_OPT_BROKEN_RX_SEL_IDX |
EXYNOS_UFS_OPT_SKIP_CONNECTION_ESTAB |
EXYNOS_UFS_OPT_USE_SW_HIBERN8_TIMER,
- .drv_init = exynos7_ufs_drv_init,
.pre_link = exynos7_ufs_pre_link,
.post_link = exynos7_ufs_post_link,
.pre_pwr_change = exynos7_ufs_pre_pwr_change,
--
2.47.0.199.ga7371fff76-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] scsi: ufs: exynos: remove superfluous function parameter
2024-10-30 10:27 [PATCH 1/2] scsi: ufs: exynos: remove empty drv_init method Tudor Ambarus
@ 2024-10-30 10:27 ` Tudor Ambarus
2024-11-12 7:53 ` Manivannan Sadhasivam
2024-11-12 7:53 ` [PATCH 1/2] scsi: ufs: exynos: remove empty drv_init method Manivannan Sadhasivam
1 sibling, 1 reply; 4+ messages in thread
From: Tudor Ambarus @ 2024-10-30 10:27 UTC (permalink / raw)
To: alim.akhtar, James.Bottomley, martin.petersen
Cc: krzk, linux-scsi, linux-arm-kernel, linux-samsung-soc,
linux-kernel, andre.draszik, kernel-team, willmcvicker,
Tudor Ambarus
The pointer to device can be obtained from ufs->hba->dev,
remove superfluous function parameter.
Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
---
drivers/ufs/host/ufs-exynos.c | 4 ++--
drivers/ufs/host/ufs-exynos.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/ufs/host/ufs-exynos.c b/drivers/ufs/host/ufs-exynos.c
index db89ebe48bcd..7e381ab1011d 100644
--- a/drivers/ufs/host/ufs-exynos.c
+++ b/drivers/ufs/host/ufs-exynos.c
@@ -198,7 +198,7 @@ static inline void exynos_ufs_ungate_clks(struct exynos_ufs *ufs)
exynos_ufs_ctrl_clkstop(ufs, false);
}
-static int exynosauto_ufs_drv_init(struct device *dev, struct exynos_ufs *ufs)
+static int exynosauto_ufs_drv_init(struct exynos_ufs *ufs)
{
struct exynos_ufs_uic_attr *attr = ufs->drv_data->uic_attr;
@@ -1424,7 +1424,7 @@ static int exynos_ufs_init(struct ufs_hba *hba)
exynos_ufs_fmp_init(hba, ufs);
if (ufs->drv_data->drv_init) {
- ret = ufs->drv_data->drv_init(dev, ufs);
+ ret = ufs->drv_data->drv_init(ufs);
if (ret) {
dev_err(dev, "failed to init drv-data\n");
goto out;
diff --git a/drivers/ufs/host/ufs-exynos.h b/drivers/ufs/host/ufs-exynos.h
index 1646c4a9bb08..9670dc138d1e 100644
--- a/drivers/ufs/host/ufs-exynos.h
+++ b/drivers/ufs/host/ufs-exynos.h
@@ -182,7 +182,7 @@ struct exynos_ufs_drv_data {
unsigned int quirks;
unsigned int opts;
/* SoC's specific operations */
- int (*drv_init)(struct device *dev, struct exynos_ufs *ufs);
+ int (*drv_init)(struct exynos_ufs *ufs);
int (*pre_link)(struct exynos_ufs *ufs);
int (*post_link)(struct exynos_ufs *ufs);
int (*pre_pwr_change)(struct exynos_ufs *ufs,
--
2.47.0.199.ga7371fff76-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 2/2] scsi: ufs: exynos: remove superfluous function parameter
2024-10-30 10:27 ` [PATCH 2/2] scsi: ufs: exynos: remove superfluous function parameter Tudor Ambarus
@ 2024-11-12 7:53 ` Manivannan Sadhasivam
0 siblings, 0 replies; 4+ messages in thread
From: Manivannan Sadhasivam @ 2024-11-12 7:53 UTC (permalink / raw)
To: Tudor Ambarus
Cc: alim.akhtar, James.Bottomley, martin.petersen, krzk, linux-scsi,
linux-arm-kernel, linux-samsung-soc, linux-kernel, andre.draszik,
kernel-team, willmcvicker
On Wed, Oct 30, 2024 at 10:27:15AM +0000, Tudor Ambarus wrote:
> The pointer to device can be obtained from ufs->hba->dev,
> remove superfluous function parameter.
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
- Mani
> ---
> drivers/ufs/host/ufs-exynos.c | 4 ++--
> drivers/ufs/host/ufs-exynos.h | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/ufs/host/ufs-exynos.c b/drivers/ufs/host/ufs-exynos.c
> index db89ebe48bcd..7e381ab1011d 100644
> --- a/drivers/ufs/host/ufs-exynos.c
> +++ b/drivers/ufs/host/ufs-exynos.c
> @@ -198,7 +198,7 @@ static inline void exynos_ufs_ungate_clks(struct exynos_ufs *ufs)
> exynos_ufs_ctrl_clkstop(ufs, false);
> }
>
> -static int exynosauto_ufs_drv_init(struct device *dev, struct exynos_ufs *ufs)
> +static int exynosauto_ufs_drv_init(struct exynos_ufs *ufs)
> {
> struct exynos_ufs_uic_attr *attr = ufs->drv_data->uic_attr;
>
> @@ -1424,7 +1424,7 @@ static int exynos_ufs_init(struct ufs_hba *hba)
> exynos_ufs_fmp_init(hba, ufs);
>
> if (ufs->drv_data->drv_init) {
> - ret = ufs->drv_data->drv_init(dev, ufs);
> + ret = ufs->drv_data->drv_init(ufs);
> if (ret) {
> dev_err(dev, "failed to init drv-data\n");
> goto out;
> diff --git a/drivers/ufs/host/ufs-exynos.h b/drivers/ufs/host/ufs-exynos.h
> index 1646c4a9bb08..9670dc138d1e 100644
> --- a/drivers/ufs/host/ufs-exynos.h
> +++ b/drivers/ufs/host/ufs-exynos.h
> @@ -182,7 +182,7 @@ struct exynos_ufs_drv_data {
> unsigned int quirks;
> unsigned int opts;
> /* SoC's specific operations */
> - int (*drv_init)(struct device *dev, struct exynos_ufs *ufs);
> + int (*drv_init)(struct exynos_ufs *ufs);
> int (*pre_link)(struct exynos_ufs *ufs);
> int (*post_link)(struct exynos_ufs *ufs);
> int (*pre_pwr_change)(struct exynos_ufs *ufs,
> --
> 2.47.0.199.ga7371fff76-goog
>
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] scsi: ufs: exynos: remove empty drv_init method
2024-10-30 10:27 [PATCH 1/2] scsi: ufs: exynos: remove empty drv_init method Tudor Ambarus
2024-10-30 10:27 ` [PATCH 2/2] scsi: ufs: exynos: remove superfluous function parameter Tudor Ambarus
@ 2024-11-12 7:53 ` Manivannan Sadhasivam
1 sibling, 0 replies; 4+ messages in thread
From: Manivannan Sadhasivam @ 2024-11-12 7:53 UTC (permalink / raw)
To: Tudor Ambarus
Cc: alim.akhtar, James.Bottomley, martin.petersen, krzk, linux-scsi,
linux-arm-kernel, linux-samsung-soc, linux-kernel, andre.draszik,
kernel-team, willmcvicker
On Wed, Oct 30, 2024 at 10:27:14AM +0000, Tudor Ambarus wrote:
> Remove empty method. When the method is not set, the call is not made,
> saving a few cycles.
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
- Mani
> ---
> drivers/ufs/host/ufs-exynos.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/ufs/host/ufs-exynos.c b/drivers/ufs/host/ufs-exynos.c
> index 9ec318ef52bf..db89ebe48bcd 100644
> --- a/drivers/ufs/host/ufs-exynos.c
> +++ b/drivers/ufs/host/ufs-exynos.c
> @@ -198,11 +198,6 @@ static inline void exynos_ufs_ungate_clks(struct exynos_ufs *ufs)
> exynos_ufs_ctrl_clkstop(ufs, false);
> }
>
> -static int exynos7_ufs_drv_init(struct device *dev, struct exynos_ufs *ufs)
> -{
> - return 0;
> -}
> -
> static int exynosauto_ufs_drv_init(struct device *dev, struct exynos_ufs *ufs)
> {
> struct exynos_ufs_uic_attr *attr = ufs->drv_data->uic_attr;
> @@ -2036,7 +2031,6 @@ static const struct exynos_ufs_drv_data exynos_ufs_drvs = {
> EXYNOS_UFS_OPT_BROKEN_RX_SEL_IDX |
> EXYNOS_UFS_OPT_SKIP_CONNECTION_ESTAB |
> EXYNOS_UFS_OPT_USE_SW_HIBERN8_TIMER,
> - .drv_init = exynos7_ufs_drv_init,
> .pre_link = exynos7_ufs_pre_link,
> .post_link = exynos7_ufs_post_link,
> .pre_pwr_change = exynos7_ufs_pre_pwr_change,
> --
> 2.47.0.199.ga7371fff76-goog
>
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-11-12 7:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-30 10:27 [PATCH 1/2] scsi: ufs: exynos: remove empty drv_init method Tudor Ambarus
2024-10-30 10:27 ` [PATCH 2/2] scsi: ufs: exynos: remove superfluous function parameter Tudor Ambarus
2024-11-12 7:53 ` Manivannan Sadhasivam
2024-11-12 7:53 ` [PATCH 1/2] scsi: ufs: exynos: remove empty drv_init method Manivannan Sadhasivam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox