* Re: [PATCH] clk: clk-imx8mp-audiomix: fix function signature
2024-12-19 10:54 [PATCH] clk: clk-imx8mp-audiomix: fix function signature Nikolaus Voss
@ 2024-12-19 12:33 ` Daniel Baluta
2024-12-20 1:59 ` Shengjiu Wang
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Daniel Baluta @ 2024-12-19 12:33 UTC (permalink / raw)
To: Nikolaus Voss
Cc: Abel Vesa, Peng Fan, Michael Turquette, Stephen Boyd, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Marco Felsch, Frank Li, Shengjiu Wang, linux-clk, imx,
linux-arm-kernel, linux-kernel
On Thu, Dec 19, 2024 at 12:55 PM Nikolaus Voss <nv@vosn.de> wrote:
>
> clk_imx8mp_audiomix_reset_controller_register() in the
> "if !CONFIG_RESET_CONTROLLER" branch had the first
> argument missing. It is an empty function for this branch
> so it wasn't immediately apparent.
>
> Fixes: 6f0e817175c5 ("clk: imx: clk-audiomix: Add reset controller")
> Cc: <stable@vger.kernel.org> # 6.12.x
> Signed-off-by: Nikolaus Voss <nv@vosn.de>
Good catch.
Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] clk: clk-imx8mp-audiomix: fix function signature
2024-12-19 10:54 [PATCH] clk: clk-imx8mp-audiomix: fix function signature Nikolaus Voss
2024-12-19 12:33 ` Daniel Baluta
@ 2024-12-20 1:59 ` Shengjiu Wang
2024-12-20 6:12 ` Peng Fan
2024-12-20 23:43 ` Stephen Boyd
3 siblings, 0 replies; 5+ messages in thread
From: Shengjiu Wang @ 2024-12-20 1:59 UTC (permalink / raw)
To: Nikolaus Voss
Cc: Abel Vesa, Peng Fan, Michael Turquette, Stephen Boyd, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Marco Felsch, Frank Li, Shengjiu Wang, linux-clk, imx,
linux-arm-kernel, linux-kernel
On Thu, Dec 19, 2024 at 6:55 PM Nikolaus Voss <nv@vosn.de> wrote:
>
> clk_imx8mp_audiomix_reset_controller_register() in the
> "if !CONFIG_RESET_CONTROLLER" branch had the first
> argument missing. It is an empty function for this branch
> so it wasn't immediately apparent.
>
> Fixes: 6f0e817175c5 ("clk: imx: clk-audiomix: Add reset controller")
> Cc: <stable@vger.kernel.org> # 6.12.x
> Signed-off-by: Nikolaus Voss <nv@vosn.de>
Acked-by: Shengjiu Wang <shengjiu.wang@gmail.com>
Best regards
Shengjiu Wang
> ---
> drivers/clk/imx/clk-imx8mp-audiomix.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/clk/imx/clk-imx8mp-audiomix.c b/drivers/clk/imx/clk-imx8mp-audiomix.c
> index b2cb157703c57..c409fc7e06186 100644
> --- a/drivers/clk/imx/clk-imx8mp-audiomix.c
> +++ b/drivers/clk/imx/clk-imx8mp-audiomix.c
> @@ -278,7 +278,8 @@ static int clk_imx8mp_audiomix_reset_controller_register(struct device *dev,
>
> #else /* !CONFIG_RESET_CONTROLLER */
>
> -static int clk_imx8mp_audiomix_reset_controller_register(struct clk_imx8mp_audiomix_priv *priv)
> +static int clk_imx8mp_audiomix_reset_controller_register(struct device *dev,
> + struct clk_imx8mp_audiomix_priv *priv)
> {
> return 0;
> }
> --
> 2.43.0
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] clk: clk-imx8mp-audiomix: fix function signature
2024-12-19 10:54 [PATCH] clk: clk-imx8mp-audiomix: fix function signature Nikolaus Voss
2024-12-19 12:33 ` Daniel Baluta
2024-12-20 1:59 ` Shengjiu Wang
@ 2024-12-20 6:12 ` Peng Fan
2024-12-20 23:43 ` Stephen Boyd
3 siblings, 0 replies; 5+ messages in thread
From: Peng Fan @ 2024-12-20 6:12 UTC (permalink / raw)
To: Nikolaus Voss
Cc: Abel Vesa, Peng Fan, Michael Turquette, Stephen Boyd, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Marco Felsch, Frank Li, Shengjiu Wang, linux-clk, imx,
linux-arm-kernel, linux-kernel
On Thu, Dec 19, 2024 at 11:54:11AM +0100, Nikolaus Voss wrote:
>clk_imx8mp_audiomix_reset_controller_register() in the
>"if !CONFIG_RESET_CONTROLLER" branch had the first
>argument missing. It is an empty function for this branch
>so it wasn't immediately apparent.
>
>Fixes: 6f0e817175c5 ("clk: imx: clk-audiomix: Add reset controller")
>Cc: <stable@vger.kernel.org> # 6.12.x
>Signed-off-by: Nikolaus Voss <nv@vosn.de>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] clk: clk-imx8mp-audiomix: fix function signature
2024-12-19 10:54 [PATCH] clk: clk-imx8mp-audiomix: fix function signature Nikolaus Voss
` (2 preceding siblings ...)
2024-12-20 6:12 ` Peng Fan
@ 2024-12-20 23:43 ` Stephen Boyd
3 siblings, 0 replies; 5+ messages in thread
From: Stephen Boyd @ 2024-12-20 23:43 UTC (permalink / raw)
To: Abel Vesa, Fabio Estevam, Frank Li, Marco Felsch,
Michael Turquette, Nikolaus Voss, Peng Fan,
Pengutronix Kernel Team, Sascha Hauer, Shawn Guo, Shengjiu Wang
Cc: linux-clk, imx, linux-arm-kernel, linux-kernel
Quoting Nikolaus Voss (2024-12-19 02:54:11)
> clk_imx8mp_audiomix_reset_controller_register() in the
> "if !CONFIG_RESET_CONTROLLER" branch had the first
> argument missing. It is an empty function for this branch
> so it wasn't immediately apparent.
>
> Fixes: 6f0e817175c5 ("clk: imx: clk-audiomix: Add reset controller")
> Cc: <stable@vger.kernel.org> # 6.12.x
> Signed-off-by: Nikolaus Voss <nv@vosn.de>
> ---
Applied to clk-fixes
^ permalink raw reply [flat|nested] 5+ messages in thread