[RESEND PATCH 1/2] dt-bindings: phy: mediatek,xsphy: add property to set disconnect threshold

[RESEND PATCH 1/2] dt-bindings: phy: mediatek,xsphy: add property to set disconnect threshold

[Chunfeng Yun]

Add a property to tune usb2 phy's disconnect threshold.
And add a compatible for mt8196.

Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
based on kernel 6.13-rc1

this property is porting from t-phy driver, due to the u2 phy are similar.
---
 Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml b/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml
index a9e3139fd421..2e012d5e1da1 100644
--- a/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml
+++ b/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml
@@ -49,6 +49,7 @@ properties:
       - enum:
           - mediatek,mt3611-xsphy
           - mediatek,mt3612-xsphy
+          - mediatek,mt8196-xsphy
       - const: mediatek,xsphy
 
   reg:
@@ -129,6 +130,13 @@ patternProperties:
         minimum: 1
         maximum: 7
 
+      mediatek,discth:
+        description:
+          The selection of disconnect threshold (U2 phy)
+        $ref: /schemas/types.yaml#/definitions/uint32
+        minimum: 1
+        maximum: 15
+
       mediatek,efuse-intr:
         description:
           The selection of Internal Resistor (U2/U3 phy)
-- 
2.46.0

[RESEND PATCH 2/2] phy: mediatek: xsphy: add support to set disconnect threshold

[Chunfeng Yun]

Add a property to tune usb2 phy's disconnect threshold.

Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
based on kernel 6.13-rc1
---
 drivers/phy/mediatek/phy-mtk-xsphy.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/drivers/phy/mediatek/phy-mtk-xsphy.c b/drivers/phy/mediatek/phy-mtk-xsphy.c
index 7c248f5cfca5..718ed8f17c2d 100644
--- a/drivers/phy/mediatek/phy-mtk-xsphy.c
+++ b/drivers/phy/mediatek/phy-mtk-xsphy.c
@@ -59,6 +59,7 @@
 #define XSP_USBPHYACR6		((SSUSB_SIFSLV_U2PHY_COM) + 0x018)
 #define P2A6_RG_BC11_SW_EN	BIT(23)
 #define P2A6_RG_OTG_VBUSCMP_EN	BIT(20)
+#define PA6_RG_U2_DISCTH	GENMASK(7, 4)
 
 #define XSP_U2PHYDTM1		((SSUSB_SIFSLV_U2PHY_COM) + 0x06C)
 #define P2D_FORCE_IDDIG		BIT(9)
@@ -95,6 +96,7 @@ struct xsphy_instance {
 	int eye_src;
 	int eye_vrt;
 	int eye_term;
+	int discth;
 };
 
 struct mtk_xsphy {
@@ -244,9 +246,12 @@ static void phy_parse_property(struct mtk_xsphy *xsphy,
 					 &inst->eye_vrt);
 		device_property_read_u32(dev, "mediatek,eye-term",
 					 &inst->eye_term);
-		dev_dbg(dev, "intr:%d, src:%d, vrt:%d, term:%d\n",
+		device_property_read_u32(dev, "mediatek,discth",
+					 &inst->discth);
+		dev_dbg(dev, "intr:%d, src:%d, vrt:%d, term:%d, discth:%d\n",
 			inst->efuse_intr, inst->eye_src,
-			inst->eye_vrt, inst->eye_term);
+			inst->eye_vrt, inst->eye_term,
+			inst->discth);
 		break;
 	case PHY_TYPE_USB3:
 		device_property_read_u32(dev, "mediatek,efuse-intr",
@@ -285,6 +290,9 @@ static void u2_phy_props_set(struct mtk_xsphy *xsphy,
 	if (inst->eye_term)
 		mtk_phy_update_field(pbase + XSP_USBPHYACR1, P2A1_RG_TERM_SEL,
 				     inst->eye_term);
+	if (inst->discth)
+		mtk_phy_update_field(pbase + XSP_USBPHYACR6, PA6_RG_U2_DISCTH,
+				     inst->discth);
 }
 
 static void u3_phy_props_set(struct mtk_xsphy *xsphy,
-- 
2.46.0

Re: [RESEND PATCH 1/2] dt-bindings: phy: mediatek,xsphy: add property to set disconnect threshold

[AngeloGioacchino Del Regno]

Il 11/01/25 15:15, Chunfeng Yun ha scritto:
> Add a property to tune usb2 phy's disconnect threshold.
> And add a compatible for mt8196.
> 
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

> ---
> based on kernel 6.13-rc1
> 
> this property is porting from t-phy driver, due to the u2 phy are similar.
> ---
>   Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 

Re: [RESEND PATCH 2/2] phy: mediatek: xsphy: add support to set disconnect threshold

[AngeloGioacchino Del Regno]

Il 11/01/25 15:15, Chunfeng Yun ha scritto:
> Add a property to tune usb2 phy's disconnect threshold.
> 
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

Re: [RESEND PATCH 1/2] dt-bindings: phy: mediatek,xsphy: add property to set disconnect threshold

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1506 bytes --]

On Sat, Jan 11, 2025 at 10:15:41PM +0800, Chunfeng Yun wrote:
> Add a property to tune usb2 phy's disconnect threshold.
> And add a compatible for mt8196.
> 
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
> based on kernel 6.13-rc1
> 
> this property is porting from t-phy driver, due to the u2 phy are similar.
> ---
>  Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml b/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml
> index a9e3139fd421..2e012d5e1da1 100644
> --- a/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml
> +++ b/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml
> @@ -49,6 +49,7 @@ properties:
>        - enum:
>            - mediatek,mt3611-xsphy
>            - mediatek,mt3612-xsphy
> +          - mediatek,mt8196-xsphy
>        - const: mediatek,xsphy
>  
>    reg:
> @@ -129,6 +130,13 @@ patternProperties:
>          minimum: 1
>          maximum: 7
>  
> +      mediatek,discth:
> +        description:
> +          The selection of disconnect threshold (U2 phy)
> +        $ref: /schemas/types.yaml#/definitions/uint32
> +        minimum: 1
> +        maximum: 15

What unit is this? Unitless? How are the values determined?

> +
>        mediatek,efuse-intr:
>          description:
>            The selection of Internal Resistor (U2/U3 phy)
> -- 
> 2.46.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [RESEND PATCH 1/2] dt-bindings: phy: mediatek,xsphy: add property to set disconnect threshold

[Chunfeng Yun (云春峰)]

On Mon, 2025-01-13 at 18:30 +0000, Conor Dooley wrote:
> On Sat, Jan 11, 2025 at 10:15:41PM +0800, Chunfeng Yun wrote:
> > Add a property to tune usb2 phy's disconnect threshold.
> > And add a compatible for mt8196.
> > 
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > ---
> > based on kernel 6.13-rc1
> > 
> > this property is porting from t-phy driver, due to the u2 phy are
> > similar.
> > ---
> >  Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml | 8
> > ++++++++
> >  1 file changed, 8 insertions(+)
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml
> > b/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml
> > index a9e3139fd421..2e012d5e1da1 100644
> > --- a/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml
> > +++ b/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml
> > @@ -49,6 +49,7 @@ properties:
> >        - enum:
> >            - mediatek,mt3611-xsphy
> >            - mediatek,mt3612-xsphy
> > +          - mediatek,mt8196-xsphy
> >        - const: mediatek,xsphy
> >  
> >    reg:
> > @@ -129,6 +130,13 @@ patternProperties:
> >          minimum: 1
> >          maximum: 7
> >  
> > +      mediatek,discth:
> > +        description:
> > +          The selection of disconnect threshold (U2 phy)
> > +        $ref: /schemas/types.yaml#/definitions/uint32
> > +        minimum: 1
> > +        maximum: 15
> 
> What unit is this? Unitless? How are the values determined?
No unit, it's a level, may be treat it as an index to select different
threshold.

Thanks
> 
> > +
> >        mediatek,efuse-intr:
> >          description:
> >            The selection of Internal Resistor (U2/U3 phy)
> > -- 
> > 2.46.0
> > 

Re: [RESEND PATCH 1/2] dt-bindings: phy: mediatek,xsphy: add property to set disconnect threshold

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1895 bytes --]

On Sun, Feb 09, 2025 at 03:34:12AM +0000, Chunfeng Yun (云春峰) wrote:
> On Mon, 2025-01-13 at 18:30 +0000, Conor Dooley wrote:
> > On Sat, Jan 11, 2025 at 10:15:41PM +0800, Chunfeng Yun wrote:
> > > Add a property to tune usb2 phy's disconnect threshold.
> > > And add a compatible for mt8196.
> > > 
> > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > > ---
> > > based on kernel 6.13-rc1
> > > 
> > > this property is porting from t-phy driver, due to the u2 phy are
> > > similar.
> > > ---
> > >  Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml | 8
> > > ++++++++
> > >  1 file changed, 8 insertions(+)
> > > 
> > > diff --git
> > > a/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml
> > > b/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml
> > > index a9e3139fd421..2e012d5e1da1 100644
> > > --- a/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml
> > > +++ b/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml
> > > @@ -49,6 +49,7 @@ properties:
> > >        - enum:
> > >            - mediatek,mt3611-xsphy
> > >            - mediatek,mt3612-xsphy
> > > +          - mediatek,mt8196-xsphy
> > >        - const: mediatek,xsphy
> > >  
> > >    reg:
> > > @@ -129,6 +130,13 @@ patternProperties:
> > >          minimum: 1
> > >          maximum: 7
> > >  
> > > +      mediatek,discth:

Just make it "disconnect-threshold" please.

> > > +        description:
> > > +          The selection of disconnect threshold (U2 phy)
> > > +        $ref: /schemas/types.yaml#/definitions/uint32
> > > +        minimum: 1
> > > +        maximum: 15
> > 
> > What unit is this? Unitless? How are the values determined?
> No unit, it's a level, may be treat it as an index to select different
> threshold.

So this is a register value of some sort? What is the actual threshold
measured in?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [RESEND PATCH 1/2] dt-bindings: phy: mediatek,xsphy: add property to set disconnect threshold

[Chunfeng Yun (云春峰)]

On Tue, 2025-02-11 at 18:30 +0000, Conor Dooley wrote:
> On Sun, Feb 09, 2025 at 03:34:12AM +0000, Chunfeng Yun (云春峰) wrote:
> > On Mon, 2025-01-13 at 18:30 +0000, Conor Dooley wrote:
> > > On Sat, Jan 11, 2025 at 10:15:41PM +0800, Chunfeng Yun wrote:
> > > > Add a property to tune usb2 phy's disconnect threshold.
> > > > And add a compatible for mt8196.
> > > > 
> > > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > > > ---
> > > > based on kernel 6.13-rc1
> > > > 
> > > > this property is porting from t-phy driver, due to the u2 phy
> > > > are
> > > > similar.
> > > > ---
> > > >  Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml | 8
> > > > ++++++++
> > > >  1 file changed, 8 insertions(+)
> > > > 
> > > > diff --git
> > > > a/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml
> > > > b/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml
> > > > index a9e3139fd421..2e012d5e1da1 100644
> > > > --- a/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml
> > > > +++ b/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml
> > > > @@ -49,6 +49,7 @@ properties:
> > > >        - enum:
> > > >            - mediatek,mt3611-xsphy
> > > >            - mediatek,mt3612-xsphy
> > > > +          - mediatek,mt8196-xsphy
> > > >        - const: mediatek,xsphy
> > > >  
> > > >    reg:
> > > > @@ -129,6 +130,13 @@ patternProperties:
> > > >          minimum: 1
> > > >          maximum: 7
> > > >  
> > > > +      mediatek,discth:
> 
> Just make it "disconnect-threshold" please.
Ohhh, Ok, I'll modify it
> 
> > > > +        description:
> > > > +          The selection of disconnect threshold (U2 phy)
> > > > +        $ref: /schemas/types.yaml#/definitions/uint32
> > > > +        minimum: 1
> > > > +        maximum: 15
> > > 
> > > What unit is this? Unitless? How are the values determined?
> > 
> > No unit, it's a level, may be treat it as an index to select
> > different
> > threshold.
> 
> So this is a register value of some sort? 
Yes, the big value means higher threshold.
> What is the actual threshold
> measured in?
I think that is mV in fact.

Thanks

Re: [RESEND PATCH 1/2] dt-bindings: phy: mediatek,xsphy: add property to set disconnect threshold

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 2465 bytes --]

On Sat, Feb 22, 2025 at 08:30:00AM +0000, Chunfeng Yun (云春峰) wrote:
> On Tue, 2025-02-11 at 18:30 +0000, Conor Dooley wrote:
> > On Sun, Feb 09, 2025 at 03:34:12AM +0000, Chunfeng Yun (云春峰) wrote:
> > > On Mon, 2025-01-13 at 18:30 +0000, Conor Dooley wrote:
> > > > On Sat, Jan 11, 2025 at 10:15:41PM +0800, Chunfeng Yun wrote:
> > > > > Add a property to tune usb2 phy's disconnect threshold.
> > > > > And add a compatible for mt8196.
> > > > > 
> > > > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > > > > ---
> > > > > based on kernel 6.13-rc1
> > > > > 
> > > > > this property is porting from t-phy driver, due to the u2 phy
> > > > > are
> > > > > similar.
> > > > > ---
> > > > >  Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml | 8
> > > > > ++++++++
> > > > >  1 file changed, 8 insertions(+)
> > > > > 
> > > > > diff --git
> > > > > a/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml
> > > > > b/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml
> > > > > index a9e3139fd421..2e012d5e1da1 100644
> > > > > --- a/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml
> > > > > +++ b/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml
> > > > > @@ -49,6 +49,7 @@ properties:
> > > > >        - enum:
> > > > >            - mediatek,mt3611-xsphy
> > > > >            - mediatek,mt3612-xsphy
> > > > > +          - mediatek,mt8196-xsphy
> > > > >        - const: mediatek,xsphy
> > > > >  
> > > > >    reg:
> > > > > @@ -129,6 +130,13 @@ patternProperties:
> > > > >          minimum: 1
> > > > >          maximum: 7
> > > > >  
> > > > > +      mediatek,discth:
> > 
> > Just make it "disconnect-threshold" please.
> Ohhh, Ok, I'll modify it
> > 
> > > > > +        description:
> > > > > +          The selection of disconnect threshold (U2 phy)
> > > > > +        $ref: /schemas/types.yaml#/definitions/uint32
> > > > > +        minimum: 1
> > > > > +        maximum: 15
> > > > 
> > > > What unit is this? Unitless? How are the values determined?
> > > 
> > > No unit, it's a level, may be treat it as an index to select
> > > different
> > > threshold.
> > 
> > So this is a register value of some sort? 
> Yes, the big value means higher threshold.
> > What is the actual threshold
> > measured in?
> I think that is mV in fact.

Can you put it in terms of uV then? The -microvolt suffix is standard in property-units.yaml

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]