From: Conor Dooley <conor@kernel.org>
To: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>
Cc: "James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
Helge Deller <deller@gmx.de>, Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
Anna-Maria Behnsen <anna-maria@linutronix.de>,
Frederic Weisbecker <frederic@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Theodore Ts'o <tytso@mit.edu>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Huacai Chen <chenhuacai@kernel.org>,
WANG Xuerui <kernel@xen0n.name>,
Russell King <linux@armlinux.org.uk>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Naveen N Rao <naveen@kernel.org>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Arnd Bergmann <arnd@arndb.de>, Guo Ren <guoren@kernel.org>,
linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-riscv@lists.infradead.org, loongarch@lists.linux.dev,
linux-s390@vger.kernel.org, linux-mips@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-arch@vger.kernel.org,
Nam Cao <namcao@linutronix.de>,
linux-csky@vger.kernel.org
Subject: Re: [PATCH v2 09/18] riscv: vdso: Switch to generic storage implementation
Date: Tue, 14 Jan 2025 10:33:53 +0000 [thread overview]
Message-ID: <20250114-lustily-nuttiness-3bb7646515d5@spud> (raw)
In-Reply-To: <20250114093609-6cb25835-f912-4f64-9ba7-54c67d4e2904@linutronix.de>
[-- Attachment #1: Type: text/plain, Size: 1198 bytes --]
On Tue, Jan 14, 2025 at 09:40:11AM +0100, Thomas Weißschuh wrote:
> On Mon, Jan 13, 2025 at 07:48:15PM +0000, Conor Dooley wrote:
> > On Fri, Jan 10, 2025 at 04:23:48PM +0100, Thomas Weißschuh wrote:
> > > The generic storage implementation provides the same features as the
> > > custom one. However it can be shared between architectures, making
> > > maintenance easier.
> > >
> > > Co-developed-by: Nam Cao <namcao@linutronix.de>
> > > Signed-off-by: Nam Cao <namcao@linutronix.de>
> > > Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
> >
> > For rv64, nommu:
> > LD vmlinux
> > ld.lld: error: undefined symbol: vmf_insert_pfn
> > >>> referenced by datastore.c
> > >>> lib/vdso/datastore.o:(vvar_fault) in archive vmlinux.a
> >
> > ld.lld: error: undefined symbol: _install_special_mapping
> > >>> referenced by datastore.c
> > >>> lib/vdso/datastore.o:(vdso_install_vvar_mapping) in archive vmlinux.a
> >
> > Later patches in the series don't make it build again.
> > rv32 builds now though, so thanks for fixing that.
>
> Thanks for the report.
> Can you try to diff below?
Ye, that resolved it. Thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2025-01-14 10:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-10 15:23 [PATCH v2 00/18] vDSO: Introduce generic data storage Thomas Weißschuh
2025-01-10 15:23 ` [PATCH v2 01/18] x86/vdso: Fix latent bug in vclock_pages calculation Thomas Weißschuh
2025-01-10 15:23 ` [PATCH v2 02/18] parisc: Remove unused symbol vdso_data Thomas Weißschuh
2025-01-10 15:23 ` [PATCH v2 03/18] vdso: Introduce vdso/align.h Thomas Weißschuh
2025-01-10 15:23 ` [PATCH v2 04/18] vdso: Rename included Makefile Thomas Weißschuh
2025-01-10 15:23 ` [PATCH v2 05/18] vdso: Add generic time data storage Thomas Weißschuh
2025-01-10 15:23 ` [PATCH v2 06/18] vdso: Add generic random " Thomas Weißschuh
2025-01-10 15:23 ` [PATCH v2 07/18] vdso: Add generic architecture-specific " Thomas Weißschuh
2025-01-10 15:23 ` [PATCH v2 08/18] arm64: vdso: Switch to generic storage implementation Thomas Weißschuh
2025-01-10 15:23 ` [PATCH v2 09/18] riscv: " Thomas Weißschuh
2025-01-13 19:48 ` Conor Dooley
2025-01-14 8:40 ` Thomas Weißschuh
2025-01-14 10:33 ` Conor Dooley [this message]
2025-01-10 15:23 ` [PATCH v2 10/18] LoongArch: vDSO: " Thomas Weißschuh
2025-01-10 15:23 ` [PATCH v2 11/18] arm: vdso: " Thomas Weißschuh
2025-01-10 15:23 ` [PATCH v2 12/18] s390/vdso: " Thomas Weißschuh
2025-01-10 15:23 ` [PATCH v2 13/18] MIPS: vdso: " Thomas Weißschuh
2025-01-10 15:23 ` [PATCH v2 14/18] powerpc/vdso: " Thomas Weißschuh
2025-01-10 15:23 ` [PATCH v2 15/18] x86/vdso: " Thomas Weißschuh
2025-01-10 15:23 ` [PATCH v2 16/18] x86/vdso/vdso2c: Remove page handling Thomas Weißschuh
2025-01-10 15:23 ` [PATCH v2 17/18] vdso: Remove remnants of architecture-specific random state storage Thomas Weißschuh
2025-01-10 15:23 ` [PATCH v2 18/18] vdso: Remove remnants of architecture-specific time storage Thomas Weißschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250114-lustily-nuttiness-3bb7646515d5@spud \
--to=conor@kernel.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=Jason@zx2c4.com \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=anna-maria@linutronix.de \
--cc=aou@eecs.berkeley.edu \
--cc=arnd@arndb.de \
--cc=borntraeger@linux.ibm.com \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=chenhuacai@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=dave.hansen@linux.intel.com \
--cc=deller@gmx.de \
--cc=frederic@kernel.org \
--cc=gor@linux.ibm.com \
--cc=guoren@kernel.org \
--cc=hca@linux.ibm.com \
--cc=hpa@zytor.com \
--cc=kernel@xen0n.name \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=loongarch@lists.linux.dev \
--cc=luto@kernel.org \
--cc=maddy@linux.ibm.com \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=namcao@linutronix.de \
--cc=naveen@kernel.org \
--cc=npiggin@gmail.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=svens@linux.ibm.com \
--cc=tglx@linutronix.de \
--cc=thomas.weissschuh@linutronix.de \
--cc=tsbogend@alpha.franken.de \
--cc=tytso@mit.edu \
--cc=vincenzo.frascino@arm.com \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox