Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/3] Misc MMC updates
@ 2024-10-14 19:47 Judith Mendez
  2024-10-14 19:47 ` [PATCH 1/3] arm64: dts: ti: k3-am6*: Remove disable-wp for eMMC Judith Mendez
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Judith Mendez @ 2024-10-14 19:47 UTC (permalink / raw)
  To: Nishanth Menon, Vignesh Raghavendra, Judith Mendez,
	Bryan Brattlof
  Cc: Tero Kristo, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	linux-arm-kernel, devicetree, linux-kernel

In this patch series we remove/add MMC DT
properties:

- disable-wp
- non-removable
- ti,itap-del-sel-legacy
- ti,itap-del-sel-mmc-hs

for am62x, am62ax, am64x, and/or am65x family devices.

Patches 1/3 and 3/3 have only been built tested.
Patch 2/3 has been boot tested on am64x IDK board.

Judith Mendez (3):
  arm64: dts: ti: k3-am6*: Remove disable-wp for eMMC
  arm64: dts: ti: k3-am65-main: Add missing itapdly to sdhci0
  arm64: dts: ti: k3-am62*: Add non-removable flag for eMMC

 arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts | 2 +-
 arch/arm64/boot/dts/ti/k3-am62a7-sk.dts        | 1 -
 arch/arm64/boot/dts/ti/k3-am62p5-sk.dts        | 2 +-
 arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi | 2 +-
 arch/arm64/boot/dts/ti/k3-am642-evm.dts        | 1 -
 arch/arm64/boot/dts/ti/k3-am65-main.dtsi       | 2 ++
 arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 1 -
 7 files changed, 5 insertions(+), 6 deletions(-)


base-commit: 5b035d14a508efd065895607ae7a6f913b26fef8
-- 
2.47.0



^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/3] arm64: dts: ti: k3-am6*: Remove disable-wp for eMMC
  2024-10-14 19:47 [PATCH 0/3] Misc MMC updates Judith Mendez
@ 2024-10-14 19:47 ` Judith Mendez
  2024-10-14 19:47 ` [PATCH 2/3] arm64: dts: ti: k3-am65-main: Add missing itapdly to sdhci0 Judith Mendez
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 6+ messages in thread
From: Judith Mendez @ 2024-10-14 19:47 UTC (permalink / raw)
  To: Nishanth Menon, Vignesh Raghavendra, Judith Mendez,
	Bryan Brattlof
  Cc: Tero Kristo, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	linux-arm-kernel, devicetree, linux-kernel

Remove disable-wp flag for eMMC nodes since this flag is
only applicable to SD.

For eMMC, this flag should be ignored but lets remove
anyways to cleanup sdhci nodes.

Signed-off-by: Judith Mendez <jm@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts | 1 -
 arch/arm64/boot/dts/ti/k3-am62a7-sk.dts        | 1 -
 arch/arm64/boot/dts/ti/k3-am62p5-sk.dts        | 1 -
 arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi | 1 -
 arch/arm64/boot/dts/ti/k3-am642-evm.dts        | 1 -
 arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 1 -
 6 files changed, 6 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts b/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts
index 70de288d728e4..092d7713e6209 100644
--- a/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts
+++ b/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts
@@ -820,7 +820,6 @@ &sdhci0 {
 	bootph-all;
 	pinctrl-names = "default";
 	pinctrl-0 = <&emmc_pins_default>;
-	disable-wp;
 	status = "okay";
 };
 
diff --git a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
index 67faf46d7a35a..748cd7ac2646e 100644
--- a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
+++ b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
@@ -602,7 +602,6 @@ &sdhci0 {
 	non-removable;
 	pinctrl-names = "default";
 	pinctrl-0 = <&main_mmc0_pins_default>;
-	disable-wp;
 };
 
 &sdhci1 {
diff --git a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
index 3efa12bb72546..efedf226addcb 100644
--- a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
+++ b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
@@ -445,7 +445,6 @@ &main_i2c2 {
 &sdhci0 {
 	status = "okay";
 	ti,driver-strength-ohm = <50>;
-	disable-wp;
 	bootph-all;
 };
 
diff --git a/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi b/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi
index 44ff67b6bf1e4..e903382c0caba 100644
--- a/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi
@@ -418,7 +418,6 @@ &sdhci0 {
 	status = "okay";
 	pinctrl-names = "default";
 	pinctrl-0 = <&main_mmc0_pins_default>;
-	disable-wp;
 };
 
 &sdhci1 {
diff --git a/arch/arm64/boot/dts/ti/k3-am642-evm.dts b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
index 97ca16f00cd26..95c20e39342cc 100644
--- a/arch/arm64/boot/dts/ti/k3-am642-evm.dts
+++ b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
@@ -584,7 +584,6 @@ &sdhci0 {
 	status = "okay";
 	non-removable;
 	ti,driver-strength-ohm = <50>;
-	disable-wp;
 	bootph-all;
 };
 
diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
index aa7139cc8a92b..c30425960398e 100644
--- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
@@ -456,7 +456,6 @@ &sdhci0 {
 	bus-width = <8>;
 	non-removable;
 	ti,driver-strength-ohm = <50>;
-	disable-wp;
 };
 
 /*
-- 
2.47.0



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/3] arm64: dts: ti: k3-am65-main: Add missing itapdly to sdhci0
  2024-10-14 19:47 [PATCH 0/3] Misc MMC updates Judith Mendez
  2024-10-14 19:47 ` [PATCH 1/3] arm64: dts: ti: k3-am6*: Remove disable-wp for eMMC Judith Mendez
@ 2024-10-14 19:47 ` Judith Mendez
  2024-10-14 19:47 ` [PATCH 3/3] arm64: dts: ti: k3-am62*: Add non-removable flag for eMMC Judith Mendez
  2025-01-17 15:11 ` [PATCH 0/3] Misc MMC updates Judith Mendez
  3 siblings, 0 replies; 6+ messages in thread
From: Judith Mendez @ 2024-10-14 19:47 UTC (permalink / raw)
  To: Nishanth Menon, Vignesh Raghavendra, Judith Mendez,
	Bryan Brattlof
  Cc: Tero Kristo, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	linux-arm-kernel, devicetree, linux-kernel

For am65x, add missing ITAP delay values for sdhci0
node according to the device datasheet [0].

[0] https://www.ti.com/lit/ds/symlink/am6548.pdf
Signed-off-by: Judith Mendez <jm@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
index 1f1af7ea23305..0534b53483473 100644
--- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
@@ -449,6 +449,8 @@ sdhci0: mmc@4f80000 {
 		ti,otap-del-sel-mmc-hs = <0x0>;
 		ti,otap-del-sel-ddr52 = <0x5>;
 		ti,otap-del-sel-hs200 = <0x5>;
+		ti,itap-del-sel-legacy = <0xa>;
+		ti,itap-del-sel-mmc-hs = <0x1>;
 		ti,itap-del-sel-ddr52 = <0x0>;
 		dma-coherent;
 		status = "disabled";
-- 
2.47.0



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 3/3] arm64: dts: ti: k3-am62*: Add non-removable flag for eMMC
  2024-10-14 19:47 [PATCH 0/3] Misc MMC updates Judith Mendez
  2024-10-14 19:47 ` [PATCH 1/3] arm64: dts: ti: k3-am6*: Remove disable-wp for eMMC Judith Mendez
  2024-10-14 19:47 ` [PATCH 2/3] arm64: dts: ti: k3-am65-main: Add missing itapdly to sdhci0 Judith Mendez
@ 2024-10-14 19:47 ` Judith Mendez
  2025-01-17 15:11 ` [PATCH 0/3] Misc MMC updates Judith Mendez
  3 siblings, 0 replies; 6+ messages in thread
From: Judith Mendez @ 2024-10-14 19:47 UTC (permalink / raw)
  To: Nishanth Menon, Vignesh Raghavendra, Judith Mendez,
	Bryan Brattlof
  Cc: Tero Kristo, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	linux-arm-kernel, devicetree, linux-kernel

EMMC device is non-removable so add 'non-removable' DT
property to avoid having to redetect the eMMC after
suspend/resume.

Signed-off-by: Judith Mendez <jm@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts | 1 +
 arch/arm64/boot/dts/ti/k3-am62p5-sk.dts        | 1 +
 arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi | 1 +
 3 files changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts b/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts
index 092d7713e6209..7f9332fd4c3ad 100644
--- a/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts
+++ b/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts
@@ -818,6 +818,7 @@ &main_spi2 {
 
 &sdhci0 {
 	bootph-all;
+	non-removable;
 	pinctrl-names = "default";
 	pinctrl-0 = <&emmc_pins_default>;
 	status = "okay";
diff --git a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
index efedf226addcb..b94093a7a392a 100644
--- a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
+++ b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
@@ -444,6 +444,7 @@ &main_i2c2 {
 
 &sdhci0 {
 	status = "okay";
+	non-removable;
 	ti,driver-strength-ohm = <50>;
 	bootph-all;
 };
diff --git a/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi b/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi
index e903382c0caba..3314955a94995 100644
--- a/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi
@@ -416,6 +416,7 @@ &main_i2c2 {
 &sdhci0 {
 	bootph-all;
 	status = "okay";
+	non-removable;
 	pinctrl-names = "default";
 	pinctrl-0 = <&main_mmc0_pins_default>;
 };
-- 
2.47.0



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/3] Misc MMC updates
  2024-10-14 19:47 [PATCH 0/3] Misc MMC updates Judith Mendez
                   ` (2 preceding siblings ...)
  2024-10-14 19:47 ` [PATCH 3/3] arm64: dts: ti: k3-am62*: Add non-removable flag for eMMC Judith Mendez
@ 2025-01-17 15:11 ` Judith Mendez
  2025-01-17 19:13   ` Nishanth Menon
  3 siblings, 1 reply; 6+ messages in thread
From: Judith Mendez @ 2025-01-17 15:11 UTC (permalink / raw)
  To: Nishanth Menon, Vignesh Raghavendra
  Cc: Tero Kristo, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	linux-arm-kernel, devicetree, linux-kernel, Bryan Brattlof

Hi all,

Is there any issue with these patches?

Thanks (:

~ Judith

On 10/14/24 2:47 PM, Judith Mendez wrote:
> In this patch series we remove/add MMC DT
> properties:
> 
> - disable-wp
> - non-removable
> - ti,itap-del-sel-legacy
> - ti,itap-del-sel-mmc-hs
> 
> for am62x, am62ax, am64x, and/or am65x family devices.
> 
> Patches 1/3 and 3/3 have only been built tested.
> Patch 2/3 has been boot tested on am64x IDK board.
> 
> Judith Mendez (3):
>    arm64: dts: ti: k3-am6*: Remove disable-wp for eMMC
>    arm64: dts: ti: k3-am65-main: Add missing itapdly to sdhci0
>    arm64: dts: ti: k3-am62*: Add non-removable flag for eMMC
> 
>   arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts | 2 +-
>   arch/arm64/boot/dts/ti/k3-am62a7-sk.dts        | 1 -
>   arch/arm64/boot/dts/ti/k3-am62p5-sk.dts        | 2 +-
>   arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi | 2 +-
>   arch/arm64/boot/dts/ti/k3-am642-evm.dts        | 1 -
>   arch/arm64/boot/dts/ti/k3-am65-main.dtsi       | 2 ++
>   arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 1 -
>   7 files changed, 5 insertions(+), 6 deletions(-)
> 
> 
> base-commit: 5b035d14a508efd065895607ae7a6f913b26fef8



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/3] Misc MMC updates
  2025-01-17 15:11 ` [PATCH 0/3] Misc MMC updates Judith Mendez
@ 2025-01-17 19:13   ` Nishanth Menon
  0 siblings, 0 replies; 6+ messages in thread
From: Nishanth Menon @ 2025-01-17 19:13 UTC (permalink / raw)
  To: Judith Mendez
  Cc: Vignesh Raghavendra, Tero Kristo, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel, devicetree,
	linux-kernel, Bryan Brattlof

On 09:11-20250117, Judith Mendez wrote:
> Hi all,
> 
> Is there any issue with these patches?
> 
> Thanks (:
> 
> ~ Judith
> 
> On 10/14/24 2:47 PM, Judith Mendez wrote:
> > In this patch series we remove/add MMC DT
> > properties:
> > 
> > - disable-wp
> > - non-removable
> > - ti,itap-del-sel-legacy
> > - ti,itap-del-sel-mmc-hs
> > 
> > for am62x, am62ax, am64x, and/or am65x family devices.
> > 
> > Patches 1/3 and 3/3 have only been built tested.
> > Patch 2/3 has been boot tested on am64x IDK board.
> > 
> > Judith Mendez (3):
> >    arm64: dts: ti: k3-am6*: Remove disable-wp for eMMC
> >    arm64: dts: ti: k3-am65-main: Add missing itapdly to sdhci0
> >    arm64: dts: ti: k3-am62*: Add non-removable flag for eMMC
> > 
> >   arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts | 2 +-
> >   arch/arm64/boot/dts/ti/k3-am62a7-sk.dts        | 1 -
> >   arch/arm64/boot/dts/ti/k3-am62p5-sk.dts        | 2 +-
> >   arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi | 2 +-
> >   arch/arm64/boot/dts/ti/k3-am642-evm.dts        | 1 -
> >   arch/arm64/boot/dts/ti/k3-am65-main.dtsi       | 2 ++
> >   arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 1 -
> >   7 files changed, 5 insertions(+), 6 deletions(-)


Test logs will be helpful, also please rebase once 6.14-rc1 is
tagged and resubmit. looks like it fell through the cracks.

Will be good to get additional reviews on the patches.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2025-01-17 19:14 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-14 19:47 [PATCH 0/3] Misc MMC updates Judith Mendez
2024-10-14 19:47 ` [PATCH 1/3] arm64: dts: ti: k3-am6*: Remove disable-wp for eMMC Judith Mendez
2024-10-14 19:47 ` [PATCH 2/3] arm64: dts: ti: k3-am65-main: Add missing itapdly to sdhci0 Judith Mendez
2024-10-14 19:47 ` [PATCH 3/3] arm64: dts: ti: k3-am62*: Add non-removable flag for eMMC Judith Mendez
2025-01-17 15:11 ` [PATCH 0/3] Misc MMC updates Judith Mendez
2025-01-17 19:13   ` Nishanth Menon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox