Re: [PATCH] arm64: defconfig: Enable PCI_J721E

Re: [PATCH] arm64: defconfig: Enable PCI_J721E

[Daniel Schultz]

can someone please apply this patch? It's actually required by all TI 
AM6 devices with PCIe, e.g. AM64x.

- Daniel

On 07.08.24 22:15, Andrew Halaney wrote:
> Enable PCI_J721E for usage in both host and endpoint modes.
> This is used by boards such as Texas Instrument's SK-AM69 and
> J784S4XEVM.
>
> Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
Tested-By: Daniel Schultz <d.schultz@phytec.de>
> ---
>   arch/arm64/configs/defconfig | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 01dd286ba7ef0..e5222dbedd387 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -225,6 +225,8 @@ CONFIG_PCIE_RCAR_HOST=y
>   CONFIG_PCIE_RCAR_EP=y
>   CONFIG_PCIE_ROCKCHIP_HOST=m
>   CONFIG_PCI_XGENE=y
> +CONFIG_PCI_J721E_HOST=y
> +CONFIG_PCI_J721E_EP=y
>   CONFIG_PCI_IMX6_HOST=y
>   CONFIG_PCI_LAYERSCAPE=y
>   CONFIG_PCI_HISI=y
>
> ---
> base-commit: eec5d86d5bac6b3e972eb9c1898af3c08303c52d
> change-id: 20240807-pci-j721e-defconfig-7bfbd95b6f93
>
> Best regards,

Re: [PATCH] arm64: defconfig: Enable PCI_J721E

[Nishanth Menon]

On 14:53-20250122, Daniel Schultz wrote:
> can someone please apply this patch? It's actually required by all TI 
> AM6 devices with PCIe, e.g. AM64x.
> 
> - Daniel
> 
> On 07.08.24 22:15, Andrew Halaney wrote:
> > Enable PCI_J721E for usage in both host and endpoint modes.
> > This is used by boards such as Texas Instrument's SK-AM69 and
> > J784S4XEVM.
> >
> > Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
> Tested-By: Daniel Schultz <d.schultz@phytec.de>
> > ---
> >   arch/arm64/configs/defconfig | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > index 01dd286ba7ef0..e5222dbedd387 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -225,6 +225,8 @@ CONFIG_PCIE_RCAR_HOST=y
> >   CONFIG_PCIE_RCAR_EP=y
> >   CONFIG_PCIE_ROCKCHIP_HOST=m
> >   CONFIG_PCI_XGENE=y
> > +CONFIG_PCI_J721E_HOST=y
> > +CONFIG_PCI_J721E_EP=y
> >   CONFIG_PCI_IMX6_HOST=y
> >   CONFIG_PCI_LAYERSCAPE=y
> >   CONFIG_PCI_HISI=y

please make them as modules. no point in growing the default Image file.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

Re: [PATCH] arm64: defconfig: Enable PCI_J721E

[Andrew Halaney]

On Wed, Jan 22, 2025 at 08:58:22AM -0600, Nishanth Menon wrote:
> On 14:53-20250122, Daniel Schultz wrote:
> > can someone please apply this patch? It's actually required by all TI 
> > AM6 devices with PCIe, e.g. AM64x.
> > 
> > - Daniel
> > 
> > On 07.08.24 22:15, Andrew Halaney wrote:
> > > Enable PCI_J721E for usage in both host and endpoint modes.
> > > This is used by boards such as Texas Instrument's SK-AM69 and
> > > J784S4XEVM.
> > >
> > > Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
> > Tested-By: Daniel Schultz <d.schultz@phytec.de>
> > > ---
> > >   arch/arm64/configs/defconfig | 2 ++
> > >   1 file changed, 2 insertions(+)
> > >
> > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > > index 01dd286ba7ef0..e5222dbedd387 100644
> > > --- a/arch/arm64/configs/defconfig
> > > +++ b/arch/arm64/configs/defconfig
> > > @@ -225,6 +225,8 @@ CONFIG_PCIE_RCAR_HOST=y
> > >   CONFIG_PCIE_RCAR_EP=y
> > >   CONFIG_PCIE_ROCKCHIP_HOST=m
> > >   CONFIG_PCI_XGENE=y
> > > +CONFIG_PCI_J721E_HOST=y
> > > +CONFIG_PCI_J721E_EP=y
> > >   CONFIG_PCI_IMX6_HOST=y
> > >   CONFIG_PCI_LAYERSCAPE=y
> > >   CONFIG_PCI_HISI=y
> 
> please make them as modules. no point in growing the default Image file.
> 

The PCI_J721E_HOST config only supports builtin, which I think has
something to do with [0] (but I only re-skimmed that this morning
briefly). I don't have the hardware any more, so I can't test what goes
on if you make it a module etc unfortunately.

[0] https://lore.kernel.org/all/86o73j3vea.wl-maz@kernel.org/

Re: [PATCH] arm64: defconfig: Enable PCI_J721E

[Nishanth Menon]

On 07:38-20250130, Andrew Halaney wrote:
> On Wed, Jan 22, 2025 at 08:58:22AM -0600, Nishanth Menon wrote:
> > On 14:53-20250122, Daniel Schultz wrote:
> > > can someone please apply this patch? It's actually required by all TI 
> > > AM6 devices with PCIe, e.g. AM64x.
> > > 
> > > - Daniel
> > > 
> > > On 07.08.24 22:15, Andrew Halaney wrote:
> > > > Enable PCI_J721E for usage in both host and endpoint modes.
> > > > This is used by boards such as Texas Instrument's SK-AM69 and
> > > > J784S4XEVM.
> > > >
> > > > Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
> > > Tested-By: Daniel Schultz <d.schultz@phytec.de>
> > > > ---
> > > >   arch/arm64/configs/defconfig | 2 ++
> > > >   1 file changed, 2 insertions(+)
> > > >
> > > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > > > index 01dd286ba7ef0..e5222dbedd387 100644
> > > > --- a/arch/arm64/configs/defconfig
> > > > +++ b/arch/arm64/configs/defconfig
> > > > @@ -225,6 +225,8 @@ CONFIG_PCIE_RCAR_HOST=y
> > > >   CONFIG_PCIE_RCAR_EP=y
> > > >   CONFIG_PCIE_ROCKCHIP_HOST=m
> > > >   CONFIG_PCI_XGENE=y
> > > > +CONFIG_PCI_J721E_HOST=y
> > > > +CONFIG_PCI_J721E_EP=y
> > > >   CONFIG_PCI_IMX6_HOST=y
> > > >   CONFIG_PCI_LAYERSCAPE=y
> > > >   CONFIG_PCI_HISI=y
> > 
> > please make them as modules. no point in growing the default Image file.
> > 
> 
> The PCI_J721E_HOST config only supports builtin, which I think has
> something to do with [0] (but I only re-skimmed that this morning
> briefly). I don't have the hardware any more, so I can't test what goes
> on if you make it a module etc unfortunately.
> 
> [0] https://lore.kernel.org/all/86o73j3vea.wl-maz@kernel.org/

https://lore.kernel.org/all/20230817120823.1158766-1-a-verma1@ti.com/
needs to be refreshed. With that we can go ahead and enable PCIE as
module. I have requested TI teams to get it back on radar.

To give a context on why: Overall, we are pushing as a armv8 community
to lower the size of Image and move the drivers to modules overall -
this is to facilitate other platforms and armv9 architectures to also
be enabled in out default defconfig.

https://lore.kernel.org/linux-arm-kernel/20240821110054.35u5ubgaogzjv6c4@rover/
was a discussion on the topic previously. my stance that I articulated
in the thread has been: if not mmc/NFS needs, please convert the driver
to be capable of modules and request to enable it.

However, I want to be able to move to initramfs default with all drivers
(8250, tisci, ....) also as modules.. Upstream poky builds of
genericarm64 is trying to get there.. but there are few more drivers to
finish the conversion before we flip the in upstream defconfig towards
initramfs. I did give a headsup on #linux-ti IRC that this change is
incoming, to allow folks to be prepared for it.. hopefully we get there
in the next 1-2 windows.

So, stuff like PCIe, I cannot accept as built-in :(

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D