* [PATCH] dt-bindings: imx: fsl,aips-bus: Ensure all properties are defined
@ 2025-02-03 21:30 Rob Herring (Arm)
2025-02-04 0:32 ` Peng Fan
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Rob Herring (Arm) @ 2025-02-03 21:30 UTC (permalink / raw)
To: Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Peng Fan
Cc: devicetree, imx, linux-arm-kernel, linux-kernel
Device specific schemas should not allow undefined properties which is
what 'additionalProperties: true' allows. Add a reference to
simple-bus.yaml which has the additional properties used, and fix this
constraint.
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
Documentation/devicetree/bindings/soc/imx/fsl,aips-bus.yaml | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,aips-bus.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,aips-bus.yaml
index 80d99861fec5..70a4af650110 100644
--- a/Documentation/devicetree/bindings/soc/imx/fsl,aips-bus.yaml
+++ b/Documentation/devicetree/bindings/soc/imx/fsl,aips-bus.yaml
@@ -22,6 +22,9 @@ select:
required:
- compatible
+allOf:
+ - $ref: /schemas/simple-bus.yaml#
+
properties:
compatible:
items:
@@ -35,7 +38,7 @@ required:
- compatible
- reg
-additionalProperties: true
+unevaluatedProperties: false
examples:
- |
--
2.47.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH] dt-bindings: imx: fsl,aips-bus: Ensure all properties are defined
2025-02-03 21:30 [PATCH] dt-bindings: imx: fsl,aips-bus: Ensure all properties are defined Rob Herring (Arm)
@ 2025-02-04 0:32 ` Peng Fan
2025-02-04 19:39 ` Conor Dooley
2025-02-11 16:07 ` Rob Herring (Arm)
2 siblings, 0 replies; 4+ messages in thread
From: Peng Fan @ 2025-02-04 0:32 UTC (permalink / raw)
To: Rob Herring (Arm), Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
Cc: devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
> Subject: [PATCH] dt-bindings: imx: fsl,aips-bus: Ensure all properties are
> defined
>
> Device specific schemas should not allow undefined properties which is
> what 'additionalProperties: true' allows. Add a reference to simple-
> bus.yaml which has the additional properties used, and fix this
> constraint.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Acked-by: Peng Fan <peng.fan@nxp.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: imx: fsl,aips-bus: Ensure all properties are defined
2025-02-03 21:30 [PATCH] dt-bindings: imx: fsl,aips-bus: Ensure all properties are defined Rob Herring (Arm)
2025-02-04 0:32 ` Peng Fan
@ 2025-02-04 19:39 ` Conor Dooley
2025-02-11 16:07 ` Rob Herring (Arm)
2 siblings, 0 replies; 4+ messages in thread
From: Conor Dooley @ 2025-02-04 19:39 UTC (permalink / raw)
To: Rob Herring (Arm)
Cc: Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Peng Fan, devicetree, imx,
linux-arm-kernel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 408 bytes --]
On Mon, Feb 03, 2025 at 03:30:26PM -0600, Rob Herring (Arm) wrote:
> Device specific schemas should not allow undefined properties which is
> what 'additionalProperties: true' allows. Add a reference to
> simple-bus.yaml which has the additional properties used, and fix this
> constraint.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: imx: fsl,aips-bus: Ensure all properties are defined
2025-02-03 21:30 [PATCH] dt-bindings: imx: fsl,aips-bus: Ensure all properties are defined Rob Herring (Arm)
2025-02-04 0:32 ` Peng Fan
2025-02-04 19:39 ` Conor Dooley
@ 2025-02-11 16:07 ` Rob Herring (Arm)
2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring (Arm) @ 2025-02-11 16:07 UTC (permalink / raw)
To: Rob Herring (Arm)
Cc: devicetree, imx, linux-kernel, Pengutronix Kernel Team,
linux-arm-kernel, Fabio Estevam, Sascha Hauer, Shawn Guo,
Krzysztof Kozlowski, Conor Dooley, Peng Fan
On Mon, 03 Feb 2025 15:30:26 -0600, Rob Herring (Arm) wrote:
> Device specific schemas should not allow undefined properties which is
> what 'additionalProperties: true' allows. Add a reference to
> simple-bus.yaml which has the additional properties used, and fix this
> constraint.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> Documentation/devicetree/bindings/soc/imx/fsl,aips-bus.yaml | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-02-11 16:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-03 21:30 [PATCH] dt-bindings: imx: fsl,aips-bus: Ensure all properties are defined Rob Herring (Arm)
2025-02-04 0:32 ` Peng Fan
2025-02-04 19:39 ` Conor Dooley
2025-02-11 16:07 ` Rob Herring (Arm)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox