* [PATCH v2] PCI: mediatek-gen3: Remove leftover mac_reset assert for Airoha EN7581 SoC.
@ 2025-02-01 11:00 Lorenzo Bianconi
2025-02-01 11:50 ` Philipp Zabel
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Lorenzo Bianconi @ 2025-02-01 11:00 UTC (permalink / raw)
To: Ryder Lee, Jianjun Wang, Lorenzo Pieralisi,
Krzysztof Wilczyński, Manivannan Sadhasivam, Rob Herring,
Bjorn Helgaas, Philipp Zabel, Matthias Brugger,
AngeloGioacchino Del Regno
Cc: linux-pci, linux-mediatek, linux-arm-kernel, Lorenzo Bianconi
Remove a leftover assert for mac_reset line in mtk_pcie_en7581_power_up().
This is not harmful since EN7581 does not requires mac_reset and
mac_reset is not defined in EN7581 device tree.
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
---
Changes in v2:
- fix typo in commit log
---
drivers/pci/controller/pcie-mediatek-gen3.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c b/drivers/pci/controller/pcie-mediatek-gen3.c
index aa24ac9aaecc749b53cfc4faf6399913d20cdbf2..0f64e76e2111468e6a453889ead7fbc75804faf7 100644
--- a/drivers/pci/controller/pcie-mediatek-gen3.c
+++ b/drivers/pci/controller/pcie-mediatek-gen3.c
@@ -940,7 +940,6 @@ static int mtk_pcie_en7581_power_up(struct mtk_gen3_pcie *pcie)
*/
reset_control_bulk_assert(pcie->soc->phy_resets.num_resets,
pcie->phy_resets);
- reset_control_assert(pcie->mac_reset);
/* Wait for the time needed to complete the reset lines assert. */
msleep(PCIE_EN7581_RESET_TIME_MS);
---
base-commit: 647d69605c70368d54fc012fce8a43e8e5955b04
change-id: 20250201-pcie-en7581-remove-mac_reset-16e7b6e3ef06
Best regards,
--
Lorenzo Bianconi <lorenzo@kernel.org>
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] PCI: mediatek-gen3: Remove leftover mac_reset assert for Airoha EN7581 SoC.
2025-02-01 11:00 [PATCH v2] PCI: mediatek-gen3: Remove leftover mac_reset assert for Airoha EN7581 SoC Lorenzo Bianconi
@ 2025-02-01 11:50 ` Philipp Zabel
2025-02-07 17:38 ` Manivannan Sadhasivam
2025-02-21 5:47 ` Krzysztof Wilczyński
2 siblings, 0 replies; 4+ messages in thread
From: Philipp Zabel @ 2025-02-01 11:50 UTC (permalink / raw)
To: Lorenzo Bianconi
Cc: Ryder Lee, Jianjun Wang, Lorenzo Pieralisi,
Krzysztof Wilczyński, Manivannan Sadhasivam, Rob Herring,
Bjorn Helgaas, Matthias Brugger, AngeloGioacchino Del Regno,
linux-pci, linux-mediatek, linux-arm-kernel
On Sat, Feb 01, 2025 at 12:00:18PM +0100, Lorenzo Bianconi wrote:
> Remove a leftover assert for mac_reset line in mtk_pcie_en7581_power_up().
> This is not harmful since EN7581 does not requires mac_reset and
> mac_reset is not defined in EN7581 device tree.
>
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
regards
Philipp
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] PCI: mediatek-gen3: Remove leftover mac_reset assert for Airoha EN7581 SoC.
2025-02-01 11:00 [PATCH v2] PCI: mediatek-gen3: Remove leftover mac_reset assert for Airoha EN7581 SoC Lorenzo Bianconi
2025-02-01 11:50 ` Philipp Zabel
@ 2025-02-07 17:38 ` Manivannan Sadhasivam
2025-02-21 5:47 ` Krzysztof Wilczyński
2 siblings, 0 replies; 4+ messages in thread
From: Manivannan Sadhasivam @ 2025-02-07 17:38 UTC (permalink / raw)
To: Lorenzo Bianconi
Cc: Ryder Lee, Jianjun Wang, Lorenzo Pieralisi,
Krzysztof Wilczyński, Rob Herring, Bjorn Helgaas,
Philipp Zabel, Matthias Brugger, AngeloGioacchino Del Regno,
linux-pci, linux-mediatek, linux-arm-kernel
On Sat, Feb 01, 2025 at 12:00:18PM +0100, Lorenzo Bianconi wrote:
> Remove a leftover assert for mac_reset line in mtk_pcie_en7581_power_up().
> This is not harmful since EN7581 does not requires mac_reset and
> mac_reset is not defined in EN7581 device tree.
>
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
- Mani
> ---
> Changes in v2:
> - fix typo in commit log
> ---
> drivers/pci/controller/pcie-mediatek-gen3.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c b/drivers/pci/controller/pcie-mediatek-gen3.c
> index aa24ac9aaecc749b53cfc4faf6399913d20cdbf2..0f64e76e2111468e6a453889ead7fbc75804faf7 100644
> --- a/drivers/pci/controller/pcie-mediatek-gen3.c
> +++ b/drivers/pci/controller/pcie-mediatek-gen3.c
> @@ -940,7 +940,6 @@ static int mtk_pcie_en7581_power_up(struct mtk_gen3_pcie *pcie)
> */
> reset_control_bulk_assert(pcie->soc->phy_resets.num_resets,
> pcie->phy_resets);
> - reset_control_assert(pcie->mac_reset);
>
> /* Wait for the time needed to complete the reset lines assert. */
> msleep(PCIE_EN7581_RESET_TIME_MS);
>
> ---
> base-commit: 647d69605c70368d54fc012fce8a43e8e5955b04
> change-id: 20250201-pcie-en7581-remove-mac_reset-16e7b6e3ef06
>
> Best regards,
> --
> Lorenzo Bianconi <lorenzo@kernel.org>
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] PCI: mediatek-gen3: Remove leftover mac_reset assert for Airoha EN7581 SoC.
2025-02-01 11:00 [PATCH v2] PCI: mediatek-gen3: Remove leftover mac_reset assert for Airoha EN7581 SoC Lorenzo Bianconi
2025-02-01 11:50 ` Philipp Zabel
2025-02-07 17:38 ` Manivannan Sadhasivam
@ 2025-02-21 5:47 ` Krzysztof Wilczyński
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Wilczyński @ 2025-02-21 5:47 UTC (permalink / raw)
To: Lorenzo Bianconi
Cc: Ryder Lee, Jianjun Wang, Lorenzo Pieralisi, Manivannan Sadhasivam,
Rob Herring, Bjorn Helgaas, Philipp Zabel, Matthias Brugger,
AngeloGioacchino Del Regno, linux-pci, linux-mediatek,
linux-arm-kernel
Hello,
> Remove a leftover assert for mac_reset line in mtk_pcie_en7581_power_up().
> This is not harmful since EN7581 does not requires mac_reset and
> mac_reset is not defined in EN7581 device tree.
Applied to controller/mediatek, thank you!
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-02-21 5:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-01 11:00 [PATCH v2] PCI: mediatek-gen3: Remove leftover mac_reset assert for Airoha EN7581 SoC Lorenzo Bianconi
2025-02-01 11:50 ` Philipp Zabel
2025-02-07 17:38 ` Manivannan Sadhasivam
2025-02-21 5:47 ` Krzysztof Wilczyński
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox