* Re: [PATCH v3 1/3] dt-bindings: reset: Add compatible for Amlogic A4/A5 Reset Controller
[not found] ` <20240918-delirious-skiing-224172be96d4@squawk>
@ 2025-03-11 9:48 ` Kelvin Zhang
2025-03-12 20:31 ` Conor Dooley
0 siblings, 1 reply; 3+ messages in thread
From: Kelvin Zhang @ 2025-03-11 9:48 UTC (permalink / raw)
To: Conor Dooley, Philipp Zabel
Cc: zelong dong, Neil Armstrong, Kevin Hilman, Rob Herring,
Martin Blumenstingl, Jerome Brunet, Krzysztof Kozlowski,
linux-kernel, linux-amlogic, linux-arm-kernel, devicetree,
Conor Dooley
On 2024/9/18 16:01, Conor Dooley wrote:
> On Wed, Sep 18, 2024 at 09:51:28AM +0200, Philipp Zabel wrote:
>> On Mi, 2024-09-18 at 15:42 +0800, zelong dong wrote:
>>> From: Zelong Dong<zelong.dong@amlogic.com>
>>>
>>> Add new compatible for Amlogic A4/A5 Reset Controller
>>>
>>> Signed-off-by: Zelong Dong<zelong.dong@amlogic.com>
>>> Acked-by: Conor Dooley<conor.dooley@microchip.com>
>>> ---
>>> .../bindings/reset/amlogic,meson-reset.yaml | 23 ++++++++++++-------
>>> 1 file changed, 15 insertions(+), 8 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml b/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml
>>> index 695ef38a7bb3..0ad81fe7b629 100644
>>> --- a/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml
>>> +++ b/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml
>>> @@ -12,14 +12,21 @@ maintainers:
>>>
>>> properties:
>>> compatible:
>>> - enum:
>>> - - amlogic,meson8b-reset # Reset Controller on Meson8b and compatible SoCs
>>> - - amlogic,meson-gxbb-reset # Reset Controller on GXBB and compatible SoCs
>>> - - amlogic,meson-axg-reset # Reset Controller on AXG and compatible SoCs
>>> - - amlogic,meson-a1-reset # Reset Controller on A1 and compatible SoCs
>>> - - amlogic,meson-s4-reset # Reset Controller on S4 and compatible SoCs
>>> - - amlogic,c3-reset # Reset Controller on C3 and compatible SoCs
>>> - - amlogic,t7-reset
>>> + oneOf:
>>> + - items:
>> I'm not well versed in preferred dt-bindings style, but this items
>> looks superfluous to me. It only contains a single enum.
> Oh, ye. Good spot.
Hello Philipp, Conor,
Sorry for the late reply.
Do you mean to use 'amlogic,meson-s4-reset' for A4 and A5 directly,
without the fallback?
--
Best regards,
Kelvin Zhang
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3 1/3] dt-bindings: reset: Add compatible for Amlogic A4/A5 Reset Controller
2025-03-11 9:48 ` [PATCH v3 1/3] dt-bindings: reset: Add compatible for Amlogic A4/A5 Reset Controller Kelvin Zhang
@ 2025-03-12 20:31 ` Conor Dooley
2025-03-13 1:48 ` Kelvin Zhang
0 siblings, 1 reply; 3+ messages in thread
From: Conor Dooley @ 2025-03-12 20:31 UTC (permalink / raw)
To: Kelvin Zhang
Cc: Philipp Zabel, zelong dong, Neil Armstrong, Kevin Hilman,
Rob Herring, Martin Blumenstingl, Jerome Brunet,
Krzysztof Kozlowski, linux-kernel, linux-amlogic,
linux-arm-kernel, devicetree, Conor Dooley
[-- Attachment #1: Type: text/plain, Size: 2387 bytes --]
On Tue, Mar 11, 2025 at 05:48:26PM +0800, Kelvin Zhang wrote:
>
>
> On 2024/9/18 16:01, Conor Dooley wrote:
> > On Wed, Sep 18, 2024 at 09:51:28AM +0200, Philipp Zabel wrote:
> > > On Mi, 2024-09-18 at 15:42 +0800, zelong dong wrote:
> > > > From: Zelong Dong<zelong.dong@amlogic.com>
> > > >
> > > > Add new compatible for Amlogic A4/A5 Reset Controller
> > > >
> > > > Signed-off-by: Zelong Dong<zelong.dong@amlogic.com>
> > > > Acked-by: Conor Dooley<conor.dooley@microchip.com>
> > > > ---
> > > > .../bindings/reset/amlogic,meson-reset.yaml | 23 ++++++++++++-------
> > > > 1 file changed, 15 insertions(+), 8 deletions(-)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml b/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml
> > > > index 695ef38a7bb3..0ad81fe7b629 100644
> > > > --- a/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml
> > > > +++ b/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml
> > > > @@ -12,14 +12,21 @@ maintainers:
> > > > properties:
> > > > compatible:
> > > > - enum:
> > > > - - amlogic,meson8b-reset # Reset Controller on Meson8b and compatible SoCs
> > > > - - amlogic,meson-gxbb-reset # Reset Controller on GXBB and compatible SoCs
> > > > - - amlogic,meson-axg-reset # Reset Controller on AXG and compatible SoCs
> > > > - - amlogic,meson-a1-reset # Reset Controller on A1 and compatible SoCs
> > > > - - amlogic,meson-s4-reset # Reset Controller on S4 and compatible SoCs
> > > > - - amlogic,c3-reset # Reset Controller on C3 and compatible SoCs
> > > > - - amlogic,t7-reset
> > > > + oneOf:
> > > > + - items:
> > > I'm not well versed in preferred dt-bindings style, but this items
> > > looks superfluous to me. It only contains a single enum.
> > Oh, ye. Good spot.
>
> Hello Philipp, Conor,
> Sorry for the late reply.
>
> Do you mean to use 'amlogic,meson-s4-reset' for A4 and A5 directly, without
> the fallback?
No. We are saying that
+ - items:
+ - enum:
+ - amlogic,meson8b-reset # Reset Controller on Meson8b and compatible SoCs
is pointless duplication, because your "items" list only has only
entry in it (the enum) and you could just remove the "- items" line
entirely and have the same outcome.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3 1/3] dt-bindings: reset: Add compatible for Amlogic A4/A5 Reset Controller
2025-03-12 20:31 ` Conor Dooley
@ 2025-03-13 1:48 ` Kelvin Zhang
0 siblings, 0 replies; 3+ messages in thread
From: Kelvin Zhang @ 2025-03-13 1:48 UTC (permalink / raw)
To: Conor Dooley
Cc: Philipp Zabel, zelong dong, Neil Armstrong, Kevin Hilman,
Rob Herring, Martin Blumenstingl, Jerome Brunet,
Krzysztof Kozlowski, linux-kernel, linux-amlogic,
linux-arm-kernel, devicetree, Conor Dooley
On 2025/3/13 04:31, Conor Dooley wrote:
> On Tue, Mar 11, 2025 at 05:48:26PM +0800, Kelvin Zhang wrote:
>>
>> On 2024/9/18 16:01, Conor Dooley wrote:
>>> On Wed, Sep 18, 2024 at 09:51:28AM +0200, Philipp Zabel wrote:
>>>> On Mi, 2024-09-18 at 15:42 +0800, zelong dong wrote:
>>>>> From: Zelong Dong<zelong.dong@amlogic.com>
>>>>>
>>>>> Add new compatible for Amlogic A4/A5 Reset Controller
>>>>>
>>>>> Signed-off-by: Zelong Dong<zelong.dong@amlogic.com>
>>>>> Acked-by: Conor Dooley<conor.dooley@microchip.com>
>>>>> ---
>>>>> .../bindings/reset/amlogic,meson-reset.yaml | 23 ++++++++++++-------
>>>>> 1 file changed, 15 insertions(+), 8 deletions(-)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml b/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml
>>>>> index 695ef38a7bb3..0ad81fe7b629 100644
>>>>> --- a/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml
>>>>> +++ b/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml
>>>>> @@ -12,14 +12,21 @@ maintainers:
>>>>> properties:
>>>>> compatible:
>>>>> - enum:
>>>>> - - amlogic,meson8b-reset # Reset Controller on Meson8b and compatible SoCs
>>>>> - - amlogic,meson-gxbb-reset # Reset Controller on GXBB and compatible SoCs
>>>>> - - amlogic,meson-axg-reset # Reset Controller on AXG and compatible SoCs
>>>>> - - amlogic,meson-a1-reset # Reset Controller on A1 and compatible SoCs
>>>>> - - amlogic,meson-s4-reset # Reset Controller on S4 and compatible SoCs
>>>>> - - amlogic,c3-reset # Reset Controller on C3 and compatible SoCs
>>>>> - - amlogic,t7-reset
>>>>> + oneOf:
>>>>> + - items:
>>>> I'm not well versed in preferred dt-bindings style, but this items
>>>> looks superfluous to me. It only contains a single enum.
>>> Oh, ye. Good spot.
>> Hello Philipp, Conor,
>> Sorry for the late reply.
>>
>> Do you mean to use 'amlogic,meson-s4-reset' for A4 and A5 directly, without
>> the fallback?
> No. We are saying that
>
> + - items:
> + - enum:
> + - amlogic,meson8b-reset # Reset Controller on Meson8b and compatible SoCs
>
> is pointless duplication, because your "items" list only has only
> entry in it (the enum) and you could just remove the "- items" line
> entirely and have the same outcome.
Got it.
Thanks!
--
Best regards,
Kelvin Zhang
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-13 1:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20240918074211.8067-1-zelong.dong@amlogic.com>
[not found] ` <20240918074211.8067-2-zelong.dong@amlogic.com>
[not found] ` <a5d9b775dd860d8f2bbf174300a2e3161b654035.camel@pengutronix.de>
[not found] ` <20240918-delirious-skiing-224172be96d4@squawk>
2025-03-11 9:48 ` [PATCH v3 1/3] dt-bindings: reset: Add compatible for Amlogic A4/A5 Reset Controller Kelvin Zhang
2025-03-12 20:31 ` Conor Dooley
2025-03-13 1:48 ` Kelvin Zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox